Developers August 2011

developers@phpmyadmin.net

17 participants
77 discussions

[Phpmyadmin-devel] Problem with "Advisor" unit tests
by Rouslan Placella 17 Aug '11

17 Aug '11

Hi there, On my computer there is a problem with the unit tests for "Advisor". If I just run the advisor test, everything is fine, it's run very quickly and succeeds. But if I run all unit tests in one go, then the "Advisor" unit test takes over a minute and eats up well over 1GB of my memory (which is unacceptable). However I can't see this issue on ci.phpmyadmin.net, where all tests complete within 25s and using only 85MB of memory. Can anyone else confirm this behaviour? Any ideas what could be the cause of this problem? I've attached 2 screenshots as proof, one at the beginning of the tests and one just before the Advisor test has finished running. Rouslan

3 5

[Phpmyadmin-devel] backquotes in SQL query
by Dieter Adriaenssens 16 Aug '11

16 Aug '11

Hi, I noticed Piotr removed back quotes from a few fields in an SQL query. They were fixed strings (no variables), so they don't really need escaping, but I was under the impression that it is good practice to add back quotes to every field/table/database name in a SQL query, not only the dynamic ones? -- Kind regards, Dieter Adriaenssens

4 4

[Phpmyadmin-devel] Any last wishes?
by Tyron Madlener 16 Aug '11

16 Aug '11

Since the google summer of code is ending and my project of supplying phpMyAdmin users with tools to help them improve their database performance is as good as completed, I'd like to ask the devs if there's anything important missing for my proposal? Maybe some feature that would greatly help with optimizing the server, lacking documentation on how the tools work, bugs that would need fixing or issues with the code? The recommendation don't necessarily need to fit into the last week of GSoC as I do not plan to completely stop my contributions right after GSoC.

3 5

Re: [Phpmyadmin-devel] Any last wishes?
by Tyron Madlener 16 Aug '11

16 Aug '11

Resending to devlist... On Mon, Aug 15, 2011 at 3:53 PM, Tyron Madlener <tyronx(a)gmail.com> wrote: > On Mon, Aug 15, 2011 at 11:19 AM, Michal Čihař <michal(a)cihar.com> wrote: >> Hi >> >> what I would like to see: >> >> - improve page load speed, currently it takes quite long till tabs are >> initialized > > - Do you have any knowledge about js/config.js? It doesn't look like > it's needed on the status page at all. Maybe we could include this > file only where it's needed. > > - I could load the status variables on demand (when the user clicks > the tab), I guess that would be the next best speed improvement. > > Apart from these two optimizations I'm not sure whether there's > anything left to optimize that would result in big loading speed > improvements. Well I could also load the query statistics on demand. > But having almost every tab load on demand only shifts the loading > time to a later point. > > Also I'm not sure whether it's really necessary for the status page to > load so quick. Each tab has some sort of refresh functionality so you > never have to fully reload the page anyway. > >> - automatically start monitor when switching to monitor tab >> > > I'm also not so sure about this. The Monitor adds some overhead to the > mysql server as well as to your client browser, through the regular > refreshes. > Having it start automatically it will be more likely that people will > have the monitor running without actually needing it. > > Though, I do agree that showing an empty page instead isn't very nice either. > >> -- >> Michal Čihař | http://cihar.com | http://phpmyadmin.cz >> >

3 4

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Operations->table maintenance
by Thilanka Kaushalya 15 Aug '11

15 Aug '11

Hi Mac, > I think all the options in "*Table maintenance*" section need ajax > > behavior (process without reloading the page). If you find any of the > > above mentioned options need changes can you please comment on those. > > I'll work with ajaxifying the "*Table maintenance*" section and update > > you as soon as possible. > > In Table maintenance's current non-Ajax behavior, the results page > contains unneeded parts. > > For example, choosing "Check table" does this: > - display the generated query (ok) > - show the results containing status (ok) > - show Query results operations (unneeded) > - show Bookmark section (unneeded) > > This is because tbl_operations.php calls sql.php when > $_REQUEST['table_maintenance'] is set. > > Try to remove the unneeded parts, at least for the new Ajax bahavior. > > I worked with this feature and pushed my changes to the repo. Since I'm not very much familiar with the back end logic related with these features can you please check the operations and comment on the results. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

2 6

[Phpmyadmin-devel] Variables duplicated in config.default.php and data_mysql.inc.php
by Michal Čihař 15 Aug '11

15 Aug '11

Hi what is actually reason for duplicating variables in config.default.php and data_mysql.inc.php? -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

2 2

Re: [Phpmyadmin-devel] Remember the last way user sorted tables
by Aris Feryanto 12 Aug '11

12 Aug '11

On 24 Mei 2011, at 18:56, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > 2011/5/24 Aris Feryanto <aris_feryanto(a)yahoo.com>: > Remember that when storing data per table you will have to set some > upper limit, or you may have data in which half of the tables don't > exist. Limiting eg. to 100 takes care of dealing with removed tables - > after some time you will just "forget" about them (they get pushed out > of saved table list). Thank you for the good suggestion, Piotr. I will limit the records if I store them per table. -- Aris Feryanto

2 2

Re: [Phpmyadmin-devel] Merging grid editing
by Aris Feryanto 12 Aug '11

12 Aug '11

On 12 Agu 2011, at 01:14, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > > On 12 Agu 2011, at 01:01, Marc Delisle <marc(a)infomarc.info> wrote: > >> Aris Feryanto a écrit : >>>> From: Marc Delisle <marc(a)infomarc.info> >>> >>>> Aris Feryanto a écrit : >>>>> Hi Marc, >>>>> >>>>>> From: Marc Delisle <marc(a)infomarc.info> Aris Feryanto a écrit : >>>>>> >>>>>>> Hi Marc, >>>>>>> >>>>>>>> From: Marc Delisle <marc(a)infomarc.info> Aris, I would >>>> like to >>>>>>>> merge this feature but I get merge conflicts, can you have >>>>>>>> a look at this? >>>>>>>> >>>>>>> I just fixed the merge conflict in my master branch. Kindly >>>>>>> merge the grid editing from there. The master branch also >>>>>>> contain some fix for recent tables and configuration for qTip >>>>>>> hint. Thanks. >>>>>> Done. >>>>>>> Btw, I'm currently refactoring and cleaning code in >>>>>>> js/makegrid.js and there will be a significant code structure >>>>>>> changes in that file. I'll update you once it is finished. >>>>>> OK. >>>>>> >>>>> I finished cleaning code in js/makegrid.js and pushed the changes >>>>> to my git repo. >>>>> >>>>> I change the structure of the code to match existing PMA code, >>>>> but I still keep the OOP style inside the function. The new >>>>> PMA_makegrid() function can accept some optional parameters, in >>>>> order to adjust which functionality (resize, reorder, show/hide, >>>>> grid edit) that want to be enabled for a table. This may be >>>>> useful for applying some features for other types of table (other >>>>> than the one generated while browsing database). >>>>> >>>>> -- Aris Feryanto >>>> Pushed, thanks. >>>> >>>> I am making a last attempt about this issue: do you have an idea >>>> about advertising (for example with a tip) about grid editing? >>>> >>> >>> Oh, right. Adding tooltips in every editable cells will be >>> disturbing, IMO. >>> >>> How about add a hint tooltip in "Edit" link in table's rows? Maybe >>> some hint like: "You can also edit a field by clicking directly on a >>> cell in the table.". Actually, we may add more hint to tell the users >>> that grid editing doesn't work for BLOB data type, but the hint will >>> be too long to be displayed. >> >> Good idea, but I suggest "You can also edit most columns by clicking >> directly on their content." >> >> These are columns, not fields; and using "most" explains in a short way >> that not everything is editable. >> > > Great! I think that will work. I'll add this soon. > Added in my git and updated on the demo server. The tooltip should look more fancy (like the old tooltip before using qTip), after Tyron's branch is merged. -- Aris Feryanto

2 1

[Phpmyadmin-devel] column reorder potential problem
by Marc Delisle 11 Aug '11

11 Aug '11

Aris, please have a look at [0]. It's interesting to see your code being tested by many users at such an earlier stage. [0] https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3386436&group_… -- Marc Delisle http://infomarc.info

2 5

[Phpmyadmin-devel] Merging grid editing
by Marc Delisle 11 Aug '11

11 Aug '11

Aris, I would like to merge this feature but I get merge conflicts, can you have a look at this? -- Marc Delisle http://infomarc.info

3 11

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers August 2011