April 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Refactoring: Displaying query results
by Chanaka Dharmarathna 25 May '12

25 May '12

Hi Michal, I'm identifying the refactoring points in 'display_tbl.lib.php' file. I am trying to break the tasks on following areas. * As a library file this should not render the HTML codes in functions it selves. First, all the HTML content in functions stored in string and render at the bottom of the function. Next, return the string having the HTML content, instead of rendering it inside the function itself and, from the calling end render that content. Probably method names will be modified with adding 'get' phrase. * Some naming conventions are used incorrectly. For method name in lib file, naming convention is used generally used as 'PMA_methodName'. But some are not following this. While correcting them, suggested conventions in my proposal [0] is going to applied. * There are several functions having more than 200 lines. I'm intending to divide those functions to smaller ones. (PMA_displayTableNavigation(), PMA_displayTableHeaders(), PMA_displayTableBody(), PMA_displayVerticalTable(), PMA_displayTable()) I am looking for your suggestions to identify more important points and modifications on suggested points. So that I can do more research by digging code more. As well, I'm using NetBeans IDE with PHP support, meld tool, Mozilla Firefox with Firebug, command line git client in Linux environment. Are there any other special tools which are more useful ? [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka7… Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

5 53

[Phpmyadmin-devel] Gsoc 2012 - Refactoring Insert/edit, Operations, Privilege and Structure sections in phpMyAdmin
by Thilina Buddika Abeyrathna 05 May '12

05 May '12

Hi Marc, I'm trying to start refactoring for Insert/edit section. There are main three scripts to refactor. But before that, I need your suggestion to start coding. -- Regards. Thilina Buddika Abeyrathna, Department of Computer Engineering, Faculty Of Engineering, University of Peradeniya, Sri Lanka.

2 12

[Phpmyadmin-devel] about the "\n"
by Marc Delisle 04 May '12

04 May '12

Hi, When touching a piece of code, if you see a "\n" generated for HTML, it's pretty much safe to remove it (if proven otherwise, we'll build a wiki page documenting those cases). The reason was to generate more readable HTML code; now that we (hopefully) use Firebug to look at the generated HTML, these "\n" are no longer needed. -- Marc Delisle http://infomarc.info

4 16

[Phpmyadmin-devel] Automated Testing - GSoC 2012
by yasitha pandithawatta 02 May '12

02 May '12

Hi Michal, In the community bonding period I would like to sort out the issues I face when I install the Jenkins server. I refer to this tutorial [0] for installation. Once I installed the Jenkins server I couldn't restart the Apache server. So I re-installed Apache. Can you suggest any manual installing instruction or a tutorial that can I use and get familiar with Jenkins. Regards, -- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka [0] - https://wiki.jenkins-ci.org/display/JENKINS/Installing+Jenkins+on+Ubuntu

3 3

[Phpmyadmin-devel] Checkstyle warning for @subpackage
by J.M. 02 May '12

02 May '12

File comments for @subpackage should not trigger as 'unknown tag/wrong indentation'. Issue like this: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1346/checkstyleResult/HI…

2 1

[Phpmyadmin-devel] GSoC student repositories and branching
by Marc Delisle 02 May '12

02 May '12

Hi, I got a question from a student I am mentoring, about using many feature branches in his tree. Here is the answer that apply (at least) to the two students I mentor. Because the sub-projects on the schedule are linear, my opinion is that it will be simpler to just use the master branch, completing one feature before starting the next one. Of course, the student has to frequently merge origin/master (origin being [0]) to his master branch or to all of his feature branches, to keep up with what happens in the "common" tree. Moreover, if the student has many branches and modifies the same file in more than one branch, cross-merging between his branches has to be done and this require more planning. There won't be a "final" merging at the end of GSoC. From the student guide [1], "Push every change you've done so that we can track your progress. GSoC has few deadlines, but we want to see and merge your code continuously! " [0] git@github.com:phpmyadmin/phpmyadmin.git [1] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide -- Marc Delisle http://infomarc.info

3 3

[Phpmyadmin-devel] guidelines for avoiding security pitfalls
by Dieter Adriaenssens 29 Apr '12

29 Apr '12

Hi, As discussed on the team meeting in February, I started creating a wiki page with some guidelines for avoiding security bugs [0]. The page is not finished yet, I just set out some ideas, that I will work out in the next few days. Feel free to comment, improve or add guidelines as you see fit. [0] http://wiki.phpmyadmin.net/pma/Security_pitfalls -- Kind regards, Dieter Adriaenssens

4 8

[Phpmyadmin-devel] [ phpmyadmin-Feature Requests-3522109 ] Inline editing by double click
by J.M. Rütter 29 Apr '12

29 Apr '12

> -----Original Message----- > From: SourceForge.net [mailto:noreply@sourceforge.net] > Sent: Saturday, April 28, 2012 12:36 AM > To: SourceForge.net > Subject: [Phpmyadmin-trk-featreq] [ phpmyadmin-Feature Requests-3522109 ] > Inline editing by double click > > Feature Requests item #3522109, was opened at 2012-04-27 14:23 > Message generated for change (Comment added) made by arcadius-radius > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i > d=23067 > > Please note that this message will contain a full copy of the comment thread, > including the initial issue submission, for this request, > not just the latest update. > Category: Interface Improvements > Group: None > Status: Open > Resolution: None > Priority: 5 > Private: No > Submitted By: arcadius (arcadius-radius) > Assigned to: Nobody/Anonymous (nobody) > Summary: Inline editing by double click > > Initial Comment: > Currently (pma 3.5.0) grid editing in browse mode is started on click. > This can be annoying for some users, f.e., they fear important table data can be > accidentally damaged. > Another bad thing is unexpected starting edit mode when trying to select some > text in grid (to copy it to clipboard). > > It would be good to support 3 configuration modes of Grid editing: > - On click (current behavior), > - On double click, > - Disable. > > While there's no this useful setting, I replaced in /js/makegrid.js: > $(g).find("td.data").click > .. with: > $(g).find("td.data").dblclick > > ---------------------------------------------------------------------- > > >Comment By: arcadius (arcadius-radius) > Date: 2012-04-27 15:36 > > Message: > Usual action on double click is selecting all text, on 3-click – > selecting all line... > So ideal shortcut for starting inline editing would be Ctrl+Click, if it > possible. > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_i > d=23067 Would introducing a new configuration option, as suggested by arcadius, be a good idea? IMHO changing the click behavior for 4.0 would consist a rather big change for people used to 3.5, wouldn't it? -- Jo Michael

3 2

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1340
by michal＠cihar.com 29 Apr '12

29 Apr '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1340/changes> Changes: [ruleant] fix indentation [ruleant] improve docblocks [ruleant] wrap long lines ------------------------------------------ Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@6688cf9e Using strategy: Default Last Built Revision: Revision 6281b4f9418323c6bb8b661a0885a2c509b750e3 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 229cb53101bbef35a95418514202cd5812519110 (origin/master) Checking out Revision 229cb53101bbef35a95418514202cd5812519110 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson7548124272846965827.sh + ./scripts/generate-mo --quiet po/fi.po:3: header field `PO-Revision-Date' missing in header [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHP Parse error: syntax error, unexpected '$local_query' (T_VARIABLE) in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/List_Databa…> on line 508 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:139 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:671 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:776 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:848 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:419 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:358 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 17 exact clones with 1080 duplicated lines in 10 files: [exec] [exec] - /libraries/export/htmlword.php:206-223 [exec] /libraries/export/htmlword.php:336-353 [exec] [exec] - /libraries/export/odt.php:270-282 [exec] /libraries/export/odt.php:415-427 [exec] [exec] - /libraries/export/texytext.php:203-217 [exec] /libraries/export/texytext.php:332-346 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-478 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:435-442 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:627-652 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:631-656 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Svg_Relation_Schema.class.php:390-406 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Svg_Relation_Schema.class.php:440-448 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-656 [exec] /libraries/schema/Svg_Relation_Schema.class.php:587-637 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:423-439 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:471-479 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:606-662 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:580-601 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1282 [exec] /themes/original/css/theme_right.css.php:1265-1286 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1691 [exec] /themes/original/css/theme_right.css.php:2393-2823 [exec] [exec] - /themes/original/css/theme_right.css.php:1205-1313 [exec] /themes/pmahomme/css/theme_right.css.php:1584-1692 [exec] [exec] - /themes/original/css/theme_right.css.php:1261-1514 [exec] /themes/pmahomme/css/theme_right.css.php:3097-3350 [exec] [exec] 0.92% duplicated lines out of 117706 total lines of code. [exec] [exec] Time: 20 seconds, Memory: 101.00Mb [exec] Result: 1 phpcs: [exec] Time: 01:53, Memory: 57.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 24 [exec] Files: 321 [exec] [exec] Lines of Code (LOC): 117706 [exec] Cyclomatic Complexity / Lines of Code: 0.16 [exec] Comment Lines of Code (CLOC): 35210 [exec] Non-Comment Lines of Code (NCLOC): 82496 [exec] [exec] Namespaces: 0 [exec] Interfaces: 0 [exec] Classes: 81 [exec] Abstract: 2 (2.47%) [exec] Concrete: 79 (97.53%) [exec] Average Class Length (NCLOC): 210 [exec] Methods: 771 [exec] Scope: [exec] Non-Static: 678 (87.94%) [exec] Static: 93 (12.06%) [exec] Visibility: [exec] Public: 636 (82.49%) [exec] Non-Public: 135 (17.51%) [exec] Average Method Length (NCLOC): 22 [exec] Cyclomatic Complexity / Number of Methods: 3.70 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 754 [exec] [exec] Constants: 122 [exec] Global constants: 107 [exec] Class constants: 15 BUILD SUCCESSFUL Total time: 2 minutes 25 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 10150 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1339 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 32 warnings. [DRY] Computing warning deltas based on reference build #1339 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 429 files to scan for tasks [TASKS] Found 204 open tasks. [TASKS] Computing warning deltas based on reference build #1339 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1339 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-04-28_23-31-43/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.4 (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 2

[Phpmyadmin-devel] bug in move columns functionality
by Rouslan Placella 27 Apr '12

27 Apr '12

Hi there, Just spotted an issue with the new "move columns" functionality. After you add or drop a column, if you click on the "Move columns" link, you will be shown a dialog with the old columns instead of the new ones. Bye, Rouslan

2 5