June 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Inline JPEG transformation fails
by Marc Delisle 22 Jul '12

22 Jul '12

Hi Alex, please have a look at [0]. [0] https://sourceforge.net/tracker/?func=detail&aid=3538666&group_id=23067&ati… -- Marc Delisle http://infomarc.info

3 17

[Phpmyadmin-devel] Refactoring: Displaying query results
by Chanaka Dharmarathna 14 Jul '12

14 Jul '12

Hi All, I have a doubt of using *@see* tag in Docblock comments for functions. In the comments of functions PMA_getTable() and PMA_getTableBody() in display_tbl.lib.php file, @see tag is used for different purposes. As I feel PMA_getTableBody() used that corrrectly. What should be the actual behavior ? Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

8 48

[Phpmyadmin-devel] server_privileges refactoring
by Thilina Buddika Abeyrathna 01 Jul '12

01 Jul '12

Hi Marc, There are two hard coded values in server_privileges.lib.php script which username and hostname lengths. (line 849). Can we define those values in a config file and access using $GLOBAL['cfg']['username_length'] and $GLOBAL['cfg']['hostname_length'], Then it'll maintainable. -- Regards. Thilina Abeyrathna Gtalk : thilinaabeyrathna skype: thilinabuddika88 thilinaa.wordpress.com

2 6

[Phpmyadmin-devel] about Thilina's schedule
by Marc Delisle 01 Jul '12

01 Jul '12

Hi Thilina, I prefer that you fix bugs in your previous refactoring before starting a new sub-project (you have started work on server_privileges.php) Please compile a list of these bugs, open artefacts on our bug tracker and reply here references to these bugs, in one post. I will then verify to ensure we did not miss anything. -- Marc Delisle http://infomarc.info

2 9

[Phpmyadmin-devel] Upload progress
by Michal Čihař 30 Jun '12

30 Jun '12

Hi Alex here is another bug for you :-) https://sourceforge.net/tracker/?func=detail&aid=3538914&group_id=23067&ati… -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 4

[Phpmyadmin-devel] Plugins and OOP
by Alex Marin 28 Jun '12

28 Jun '12

Hi everyone, I have implemented a good deal of the object oriented plugins system. All of the plugins can be found in the /libraries/plugins/ folder in my git repo [1]. There are two important things that are missing right now: - The update() methods in the Observer pattern. - Serious testing. I think that my code is safe to be merged now. There are probably still a few bugs left, but more people having them will pop them out faster. I hope there are not so many, though. And I also believe that new development can be done over my classes without problems. What do you think? Also, I was thinking that, maybe, Yasitha, is there any way you can work with me and integrate some tests for the import, export, transformations and auth plugins with your GSoC project? And, of course, any suggestions are welcome. [1] https://github.com/alexukf/phpmyadmin/tree/plugins-and-OOP -- Alex

2 4

[Phpmyadmin-devel] ready for 3.5.2-rc1 ?
by Marc Delisle 27 Jun '12

27 Jun '12

Hi, I hoped to completely remove usage of Highcharts for 3.5.2 but I am stuck on a problem. Therefore I suggest to release 3.5.2-rc1 with the current state of QA_3_5 branch. -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] phpMyAdmin 3.5.2-rc1 is released
by Marc Delisle 26 Jun '12

26 Jun '12

Welcome to the first release candidate for phpMyAdmin 3.5.2, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] testing PHP 5.4-based upload progress
by Marc Delisle 25 Jun '12

25 Jun '12

Hi Jo, I'm using PHP 5.4.4 and testing your newest commits. After the POST to import.php, I immediately see GET import_status.php with this JSON response: {"id":"4fe8b2f19bc80","finished":true,"percent":100,"total":0,"complete":0,"plugin":"PHP_SESSION_UPLOAD_PROGRESS"} Then, another GET to import_status.php which does not return. Meanwhile, I see in my upload directory the file still being received. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Cross framing protection
by Rouslan Placella 25 Jun '12

25 Jun '12

Hi Dieter, I've just dropped the cross_framing_protection.js script in my branch. However there is the below bit of code from Header.class.php that I'm not too sure what to do with. > /* Prevent against ClickJacking by allowing frames only from same origin */ > if (! $GLOBALS['cfg']['AllowThirdPartyFraming']) { > header( > "X-Content-Security-Policy: allow 'self'; " > . "options inline-script eval-script; " > . "frame-ancestors 'self'; img-src 'self' data:; " > . "script-src 'self' http://www.phpmyadmin.net" > ); > header( > "X-WebKit-CSP: allow 'self' http://www.phpmyadmin.net; " > . "options inline-script eval-script" > ); > } I'm guessing that we need CSP for the version checker (or do we?), but we don't really need the configuration directive for it. Not sure how to proceed here. Any help appreciated, thanks. Bye, Rouslan

2 2