Developers August 2012

developers@phpmyadmin.net

9 participants
32 discussions

[Phpmyadmin-devel] Upgrading sf.net project
by Michal Čihař 16 Nov '12

16 Nov '12

Hi maybe you've noticed, maybe not, but sf.net is slowly moving to new platform called Allura [1] and projects can opt in for upgrading. There seems to be quite a lot of improvements [2], especially in the Issue tracking (you can see Allura's own tickes [3] as an example). There are upgrading information on separate page [4] and none of not migrated things does not affect us, so I'd go for upgrade. Any comments on that? [1]:https://sourceforge.net/p/allura/ [2]:https://sourceforge.net/p/allura/wiki/Features/ [3]:https://sourceforge.net/p/allura/tickets/ [4]:https://sourceforge.net/p/upgrade/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 9

[Phpmyadmin-devel] grid editing not with single-click?
by Marc Delisle 20 Oct '12

20 Oct '12

Hi, After reading [0] I am almost convinced that grid editing with a single-click is not the best idea. So, for 4.0, I suggest to switch to some other action to activate grid editing. [0] https://sourceforge.net/tracker/?func=detail&atid=377411&aid=3522109&group_… -- Marc Delisle http://infomarc.info

3 4

[Phpmyadmin-devel] PMA_CommonFunctions
by Dieter Adriaenssens 17 Sep '12

17 Sep '12

Hi Chanaka, I stumbled upon this piece of code (random pick) : PMA_CommonFunctions::getInstance()->backquote($_REQUEST['view']['name']) and it made me wonder if using a singleton for PMA_CommonFunctions is necessary, because basicaly PMA_Commonfunctions is a collection of methods, not really a 'living' object. So then I had a look at the class, and I discovered that the class has no class variables (apart from the _instance variable) and an empty constructor. So basicly this should be a static class, with static methods, because no instance is needed for it to work. And the above piece of code will become : PMA_CommonFunctions::backquote($_REQUEST['view']['name']) BTW: If you convert it to a static class, don't forget to replace the $this->method() calls by the static equivalent self::method(). BTW2 : you forgot to add the if (! defined('PHPMYADMIN')), check in the beginning of the file, see [0]. [0] http://wiki.phpmyadmin.net/pma/File_template -- Kind regards, Dieter Adriaenssens

6 14

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1863
by michal＠cihar.com 27 Aug '12

27 Aug '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1863/changes> Changes: [weblate] Translated using Weblate. [weblate] Translated using Weblate. [weblate] Translated using Weblate. [madhura.cj] bug #3561224 [edit] cell edit date field with empty date fills in current date ------------------------------------------ Started by GitHub push by Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@582d0ceb Using strategy: Default Last Built Revision: Revision 2069f77e571519251a5fec79f91522856dae2dd9 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 9bb9d62b951d38c7e4122eceda733935319b265b (origin/master) Checking out Revision 9bb9d62b951d38c7e4122eceda733935319b265b (origin/master) FATAL: Unable to produce a script file hudson.util.IOException2: Failed to create a temp file on <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> at hudson.FilePath.createTextTempFile(FilePath.java:1090) at hudson.tasks.CommandInterpreter.createScriptFile(CommandInterpreter.java:104) at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66) at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:58) at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:19) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:717) at hudson.model.Build$BuildExecution.build(Build.java:199) at hudson.model.Build$BuildExecution.doRun(Build.java:160) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1502) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:236) Caused by: java.io.IOException: No space left on device at java.io.FileOutputStream.writeBytes(Native Method) at java.io.FileOutputStream.write(FileOutputStream.java:297) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:220) at sun.nio.cs.StreamEncoder.implClose(StreamEncoder.java:315) at sun.nio.cs.StreamEncoder.close(StreamEncoder.java:148) at java.io.OutputStreamWriter.close(OutputStreamWriter.java:233) at hudson.FilePath$14.invoke(FilePath.java:1084) at hudson.FilePath$14.invoke(FilePath.java:1068) at hudson.FilePath.act(FilePath.java:842) at hudson.FilePath.act(FilePath.java:824) at hudson.FilePath.createTextTempFile(FilePath.java:1068) ... 12 more Build step 'Execute shell' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 19 warnings. [DRY] Computing warning deltas based on reference build #1862 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1862 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run? * <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 1 day 20 hr old [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 3

[Phpmyadmin-devel] QA_3_5 merge
by Michal Čihař 22 Aug '12

22 Aug '12

Hi please try to merge every change done in QA_3_5 into master so that future changes can be merged easier. Today I was unable to do merge because these commits (second one is just a fix for first one) do not apply at all. In case the changes should not be merge at all, just do: git checkout master git merge -s ours origin/QA_3_5 This will tell git that it should not care about extra commits in QA_3_5 anymore. So master is now missing following commits and I have no clue if there is something needed there or not: commit a483935cf8aac81a2d87390af36f387100f3bdf2 Author: J.M <me(a)mynetx.net> Date: Wed Aug 22 11:14:45 2012 +0200 bug #3559925 [privileges] Incorrect updating of the list of users commit e0383e6b1938dd5a5fd377e27d04c3880b6c2d6d Author: Marc Delisle <marc(a)infomarc.info> Date: Wed Aug 22 06:35:26 2012 -0400 Remove extraneous characters -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 2

[Phpmyadmin-devel] "Display chart" and number of rows
by Marc Delisle 21 Aug '12

21 Aug '12

Hi, I'm getting familiar with tbl_chart.* to port the feature to jqplot. This "Query results operations>Display chart" feature was a GSoC 2010 project and is documented at [0]. I just noticed that tbl_chart.php fetches the whole data set generated by the query and puts it into an array. Then, this is passed to the js level for chart generation. Evidently, the web server's process and the browser itself hit memory limits, even for medium tables (sakila.film_actor). I'm not sure what the user expects when clicking on Display chart in terms of the number of rows, because, for example "Query results operations>Print view" only displays the current rows on screen (30 by default). So I suggest to do something similar to what was done in Search>Zoom search: to have in the chart interface a control for the maximum number of rows, with 500 as the default value. Comments? [0] http://wiki.phpmyadmin.net/pma/Charts -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Cannot edit db-specific privileges
by Marc Delisle 20 Aug '12

20 Aug '12

Hi Thilina, please open a bug artifact. I found that since this commit: https://github.com/thilinaa/phpmyadmin/commit/42860cf4f0b1c4c0b8bf7a67b4e3a… it's not possible to edit db-specific privileges. A panel to edit global privileges is incorrectly shown. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] phpmyadmin accident....
by Michael Gesundheit 19 Aug '12

19 Aug '12

This is a desperate request for help. I'm fighting the issue for 2 days!! I installed TomCat on Ubuntu (an Amazon instance) and since then lost my phpmyadmin access to my DB. I keep on getting: "Forbidden You don't have permission to access /phpmyadmin on this server." I googled the subject to death and checked, virtually, everything against another Amazon instance were things are fine. I'll pay for help! Thanks in advance! -Michael

2 1

[Phpmyadmin-devel] Issues with refactoring of tbl_structure
by Rouslan Placella 18 Aug '12

18 Aug '12

Hi all, I've found some obviously broken HTML tags on tbl_structure.php and I assume that this is due to the recent refactoring of this page. I couldn't find where the issue is in the code, but it manifests itself in the "more" dropdown as links there are now not clickable. Screenshot attached. Another thing that I noticed in the new *_structure code are the new function names. Not sure if it's just me, but after a 2 minute look I found all of these functions where IMO the names can be improved: PMA_getHtmlForPrintViewAndDataDictionaryLinks - too long? PMA_SortableTableHeader - starts with a capital unlike others PMA_getAliasAndTruename - incorrect camel case PMA_getStuffForEnginetable - meaningless + incorrect camel case PMA_getHtmlForCheckAlltableColumn - incorrect camel case PMA_getHtmlForSomeLinks - meaningless PMA_getHtmlForRowStatstableRow - incorrect camel case getHtmlForRowStatsTable - no PMA_ prefix PMA_getHtmlForDistincValueAction - spelling: "Distinct" PMA_getHtmlForActionsIntableStructure - incorrect camel case Bye, Rouslan

3 8

[Phpmyadmin-devel] tbl_operation - Bug Fixing
by Thilina Buddika Abeyrathna 18 Aug '12

18 Aug '12

Hi Marc, I'm looking [1] bug in the table operation page, I 'git checkout' to very old commit and check the same bug in there, But still this bug was there, I found that, first bad commit was 4d2fcd910bc7e07114fcc76f55705c1a6e8c685e (This is not a my commit) I can't figure out where is this error happen. [1] - http://sourceforge.net/tracker/?func=detail&aid=3555235&group_id=23067&atid… -- Regards. Thilina Abeyrathna Gtalk : thilinaabeyrathna skype: thilinabuddika88 thilinaa.wordpress.com

3 8

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers August 2012