Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Issues with refactoring of tbl_structure
by Rouslan Placella 18 Aug '12

18 Aug '12

Hi all, I've found some obviously broken HTML tags on tbl_structure.php and I assume that this is due to the recent refactoring of this page. I couldn't find where the issue is in the code, but it manifests itself in the "more" dropdown as links there are now not clickable. Screenshot attached. Another thing that I noticed in the new *_structure code are the new function names. Not sure if it's just me, but after a 2 minute look I found all of these functions where IMO the names can be improved: PMA_getHtmlForPrintViewAndDataDictionaryLinks - too long? PMA_SortableTableHeader - starts with a capital unlike others PMA_getAliasAndTruename - incorrect camel case PMA_getStuffForEnginetable - meaningless + incorrect camel case PMA_getHtmlForCheckAlltableColumn - incorrect camel case PMA_getHtmlForSomeLinks - meaningless PMA_getHtmlForRowStatstableRow - incorrect camel case getHtmlForRowStatsTable - no PMA_ prefix PMA_getHtmlForDistincValueAction - spelling: "Distinct" PMA_getHtmlForActionsIntableStructure - incorrect camel case Bye, Rouslan

3 8

[Phpmyadmin-devel] tbl_operation - Bug Fixing
by Thilina Buddika Abeyrathna 18 Aug '12

18 Aug '12

Hi Marc, I'm looking [1] bug in the table operation page, I 'git checkout' to very old commit and check the same bug in there, But still this bug was there, I found that, first bad commit was 4d2fcd910bc7e07114fcc76f55705c1a6e8c685e (This is not a my commit) I can't figure out where is this error happen. [1] - http://sourceforge.net/tracker/?func=detail&aid=3555235&group_id=23067&atid… -- Regards. Thilina Abeyrathna Gtalk : thilinaabeyrathna skype: thilinabuddika88 thilinaa.wordpress.com

3 8

[Phpmyadmin-devel] Bug with properties system
by Marc Delisle 17 Aug '12

17 Aug '12

Hi, since this commit, the db Export panel no longer shows the SQL choice: 9458f9d06263822558d39e2a52fabafe40259bf1 is the first bad commit commit 9458f9d06263822558d39e2a52fabafe40259bf1 Author: Alex Marin <alex.ukf(a)gmail.com> Date: Tue Jul 17 13:32:13 2012 +0300 oop: integrate the properties system for ExportXml -- Marc Delisle http://infomarc.info

4 14

Re: [Phpmyadmin-devel] [Phpmyadmin-git] [phpmyadmin/phpmyadmin] f50b45: remove duplicates, remove some HTML tags and funct...
by Michal Čihař 16 Aug '12

16 Aug '12

Hi Dne Thu, 16 Aug 2012 03:39:02 -0700 Thilina Buddika <thilinaabeyrathna(a)gmail.com> napsal(a): > Commit: ecf1462c1d0cf6e4ecb955a47f8b28a7960f0114 > https://github.com/phpmyadmin/phpmyadmin/commit/ecf1462c1d0cf6e4ecb955a47f8… > Author: Thilina Buddika <thilinaabeyrathna(a)gmail.com> > Date: 2012-08-15 (Wed, 15 Aug 2012) > > Changed paths: > M ChangeLog > M js/db_structure.js > M js/tbl_gis_visualization.js > M libraries/CommonFunctions.class.php > M libraries/DisplayResults.class.php > M libraries/plugin_interface.lib.php > M libraries/plugins/export/ExportCodegen.class.php > M libraries/plugins/export/ExportLatex.class.php > M libraries/plugins/export/ExportSql.class.php > M libraries/rte/rte_triggers.lib.php > M libraries/structure.lib.php > M phpunit.xml.dist > M po/th.po > M po/zh_CN.po > R po/zh_TW.po Please check what changes are you actually pushing, deleting translation file was hardly intended here... -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 6

[Phpmyadmin-devel] Error in master branch
by Michal Čihař 16 Aug '12

16 Aug '12

Hi again one error which happens quite often on demo server: PHP Fatal error: Call to a member function getPath() on a non-object in libraries/CommonFunctions.class.php on line 183 Still I didn't investigate how to reproduce it. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

1 0

[Phpmyadmin-devel] phpMyAdmin 3.4.11.1 and 3.5.2.2 are released
by Marc Delisle 12 Aug '12

12 Aug '12

Welcome to phpMyAdmin 3.4.11.1 and 3.5.2.2, two security releases. Please refer to the upcoming PMASA-2012-4 announcement on http://www.phpmyadmin.net/home_page/security. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] demo server
by Rouslan Placella 10 Aug '12

10 Aug '12

Hi Michal, I just noticed that my demo server is running a git revision from last week. Any ideas what the problem is? Thanks for any help you may give me with this. Bye, Rouslan

2 1

[Phpmyadmin-devel] PHP errors in master
by Michal Čihař 10 Aug '12

10 Aug '12

Hi on demo server I can still see following PHP errors: PHP Fatal error: Call to a member function getText() on a non-object in libraries/plugin_interface.lib.php on line 192#012 PHP Fatal error: Call to undefined function getTableDefStandIn() in libraries/plugins/export/ExportSql.class.php on line 1398#012 Not sure how to trigger them, but still it looks like bug somewhere... -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

1 0

[Phpmyadmin-devel] Dead code in master
by Rouslan Placella 09 Aug '12

09 Aug '12

Hi all, I think that the code at [0] is dead and should be removed. The first reason is that the checked variables were probably removed together with grab globals and secondly, there is no 'submitcomment' parameter in a tbl_operations form anyway. Bye, Rouslan [0]: https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/tbl_info.inc…

2 2

[Phpmyadmin-devel] table comments in serverinfo div
by Marc Delisle 09 Aug '12

09 Aug '12

Hi Rouslan, git bisect tells me that since your ae6e50a8a82a70a1bff90cadc200f06819306615, table comments are no longer displayed next to the table name, in the serverinfo div. -- Marc Delisle http://infomarc.info

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers