- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] PMA_CommonFunctions
by Dieter Adriaenssens 17 Sep '12

17 Sep '12

Hi Chanaka, I stumbled upon this piece of code (random pick) : PMA_CommonFunctions::getInstance()->backquote($_REQUEST['view']['name']) and it made me wonder if using a singleton for PMA_CommonFunctions is necessary, because basicaly PMA_Commonfunctions is a collection of methods, not really a 'living' object. So then I had a look at the class, and I discovered that the class has no class variables (apart from the _instance variable) and an empty constructor. So basicly this should be a static class, with static methods, because no instance is needed for it to work. And the above piece of code will become : PMA_CommonFunctions::backquote($_REQUEST['view']['name']) BTW: If you convert it to a static class, don't forget to replace the $this->method() calls by the static equivalent self::method(). BTW2 : you forgot to add the if (! defined('PHPMYADMIN')), check in the beginning of the file, see [0]. [0] http://wiki.phpmyadmin.net/pma/File_template -- Kind regards, Dieter Adriaenssens

6 14

[Phpmyadmin-devel] jqplot last conversion step
by Marc Delisle 16 Sep '12

16 Sep '12

Atul, I have been exchanging mails with you, about the conversion, and I think we should go public on this. We are working on Status>Monitor. One of the features there, is to be able to select a time span and fetch the related queries from the slow log or the general log. After some research, it seems that the jqplotMouseDown and jqplotMouseUp events will be helpful to return the starting and ending positions for the time span; however, as you said, it would be interesting to change the color in the dragged region. This example [0] is promising, but I'm not sure it would work on a chart that is still moving. The jqplotMouseMove event could be used instead of .mousemove(), to get x/y coordinates relative to the chart itself. [0] http://motyar.blogspot.ca/2010/02/draw-rectangle-with-jquery.html -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] time span selection and rectangle
by Marc Delisle 16 Sep '12

16 Sep '12

Hi, starting from Atul's example, I added the rectangle-drawing code in [0]. Here you can draw many rectangles, but when this is integrated to js/server_status_monitor.js, the jqplotMouseUp() will show the "Log statistics" dialog and will erase the rectangle. [0] http://jsfiddle.net/lem9/N4Pst/3/ -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] SourceForge interview with Marc about GSoC
by Dieter Adriaenssens 10 Sep '12

10 Sep '12

Hi all, Marc was interviewed by SourceForge about GSoC : http://sourceforge.net/blog/phpmyadmin-gsoc/?utm_source=rss&utm_medium=rss&… -- Kind regards, Dieter Adriaenssens

1 0

[Phpmyadmin-devel] cleaning up mixed html and php
by Dieter Adriaenssens 06 Sep '12

06 Sep '12

Hi, When fixing coding style issues, I noticed a lot of mixed php and html, especially in the files in the rootdir of the pma. F.e. : <div id='<?php echo htmlentities($name); ?>' class='someclass'> or even worse : <?php if ($something) { ?>Some conditional text <?php } ?> Some unconditional text It generates a lot of codingstyle errors : too long lines, wrong indentation, ... it is badly structured and thus difficult to read and to be honest, is ugly. I'm thinking of starting to clean it up towards 4.0, using either echo's or assigning the output html to a string and add it to the appropriate Response class method. f.e. : <?php $response = PMA_Response::getInstance(); $output = ""; \\ some code in between if (something) { $output .= "Some conditional text"; } $output .= "Some unconditional text"; \\ some code in between $response->addHTML($output); ?> Any thoughts? -- Kind regards, Dieter Adriaenssens

3 3

[Phpmyadmin-devel] status merging GSoC code and code quality
by Dieter Adriaenssens 04 Sep '12

04 Sep '12

Hi all, I was wondering how much of the different GSoC projects is merged in master already? I know about Rouslan's project, not being completely merged. Regarding code quality. I noticed that some of the new code fails a lot of code quality tests (mainly from Code Sniffer). So please run PHPCS (Code Sniffer) [0] on your code and fix the issues. [0] http://wiki.phpmyadmin.net/pma/CodeSniffer -- Kind regards, Dieter Adriaenssens

4 6

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1863
by michal＠cihar.com 27 Aug '12

27 Aug '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1863/changes> Changes: [weblate] Translated using Weblate. [weblate] Translated using Weblate. [weblate] Translated using Weblate. [madhura.cj] bug #3561224 [edit] cell edit date field with empty date fills in current date ------------------------------------------ Started by GitHub push by Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@582d0ceb Using strategy: Default Last Built Revision: Revision 2069f77e571519251a5fec79f91522856dae2dd9 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 9bb9d62b951d38c7e4122eceda733935319b265b (origin/master) Checking out Revision 9bb9d62b951d38c7e4122eceda733935319b265b (origin/master) FATAL: Unable to produce a script file hudson.util.IOException2: Failed to create a temp file on <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> at hudson.FilePath.createTextTempFile(FilePath.java:1090) at hudson.tasks.CommandInterpreter.createScriptFile(CommandInterpreter.java:104) at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66) at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:58) at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:19) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:717) at hudson.model.Build$BuildExecution.build(Build.java:199) at hudson.model.Build$BuildExecution.doRun(Build.java:160) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1502) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:236) Caused by: java.io.IOException: No space left on device at java.io.FileOutputStream.writeBytes(Native Method) at java.io.FileOutputStream.write(FileOutputStream.java:297) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:220) at sun.nio.cs.StreamEncoder.implClose(StreamEncoder.java:315) at sun.nio.cs.StreamEncoder.close(StreamEncoder.java:148) at java.io.OutputStreamWriter.close(OutputStreamWriter.java:233) at hudson.FilePath$14.invoke(FilePath.java:1084) at hudson.FilePath$14.invoke(FilePath.java:1068) at hudson.FilePath.act(FilePath.java:842) at hudson.FilePath.act(FilePath.java:824) at hudson.FilePath.createTextTempFile(FilePath.java:1068) ... 12 more Build step 'Execute shell' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 19 warnings. [DRY] Computing warning deltas based on reference build #1862 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1862 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run? * <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 1 day 20 hr old [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 3

[Phpmyadmin-devel] QA_3_5 merge
by Michal Čihař 22 Aug '12

22 Aug '12

Hi please try to merge every change done in QA_3_5 into master so that future changes can be merged easier. Today I was unable to do merge because these commits (second one is just a fix for first one) do not apply at all. In case the changes should not be merge at all, just do: git checkout master git merge -s ours origin/QA_3_5 This will tell git that it should not care about extra commits in QA_3_5 anymore. So master is now missing following commits and I have no clue if there is something needed there or not: commit a483935cf8aac81a2d87390af36f387100f3bdf2 Author: J.M <me(a)mynetx.net> Date: Wed Aug 22 11:14:45 2012 +0200 bug #3559925 [privileges] Incorrect updating of the list of users commit e0383e6b1938dd5a5fd377e27d04c3880b6c2d6d Author: Marc Delisle <marc(a)infomarc.info> Date: Wed Aug 22 06:35:26 2012 -0400 Remove extraneous characters -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 2

[Phpmyadmin-devel] "Display chart" and number of rows
by Marc Delisle 21 Aug '12

21 Aug '12

Hi, I'm getting familiar with tbl_chart.* to port the feature to jqplot. This "Query results operations>Display chart" feature was a GSoC 2010 project and is documented at [0]. I just noticed that tbl_chart.php fetches the whole data set generated by the query and puts it into an array. Then, this is passed to the js level for chart generation. Evidently, the web server's process and the browser itself hit memory limits, even for medium tables (sakila.film_actor). I'm not sure what the user expects when clicking on Display chart in terms of the number of rows, because, for example "Query results operations>Print view" only displays the current rows on screen (30 by default). So I suggest to do something similar to what was done in Search>Zoom search: to have in the chart interface a control for the maximum number of rows, with 500 as the default value. Comments? [0] http://wiki.phpmyadmin.net/pma/Charts -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Cannot edit db-specific privileges
by Marc Delisle 20 Aug '12

20 Aug '12

Hi Thilina, please open a bug artifact. I found that since this commit: https://github.com/thilinaa/phpmyadmin/commit/42860cf4f0b1c4c0b8bf7a67b4e3a… it's not possible to edit db-specific privileges. A panel to edit global privileges is incorrectly shown. -- Marc Delisle http://infomarc.info

2 1