Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Create table seems broken again
by Isaac Bennetch 27 Oct '11

27 Oct '11

Hi, I'm unable to create a new table in Safari or Internet Explorer. After clicking the "Create table" link in the navigation frame or filling in a name and number of columns in a database's Structure tab, I get a blank page displayed in the main frame.

3 4

[Phpmyadmin-devel] new enum editor works well
by Marc Delisle 26 Oct '11

26 Oct '11

Rouslan, the new enum/set editor is a good improvement, thanks. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] best approach about jQuery dialogs' title bar?
by Marc Delisle 24 Oct '11

24 Oct '11

Hi, Tyron Madlener suggested to get rid of the title bar in the create table dialog. I've come up with this patch (done here just for pmahomme): diff --git a/js/functions.js b/js/functions.js index 19ab7ce..d171496 100644 --- a/js/functions.js +++ b/js/functions.js @@ -1514,7 +1514,6 @@ function PMA_createTableDialog( $div, url , target) $div .append(data.error) .dialog({ - title: PMA_messages['strCreateTable'], height: 230, width: 900, open: PMA_verifyColumnsProperties, @@ -1528,7 +1527,7 @@ function PMA_createTableDialog( $div, url , target) $div .append(data) .dialog({ - title: PMA_messages['strCreateTable'], + dialogClass: 'create-table', resizable: false, draggable: false, modal: true, diff --git a/js/messages.php b/js/messages.php index 96f759b..71afc05 100644 --- a/js/messages.php +++ b/js/messages.php @@ -222,7 +222,6 @@ $js_messages['strReloadDatabase'] = __('Reload Database'); $js_messages['strCopyingDatabase'] = __('Copying Database'); $js_messages['strChangingCharset'] = __('Changing Charset'); $js_messages['strTableMustHaveAtleastOneColumn'] = __('Table must have at least one column'); -$js_messages['strCreateTable'] = __('Create Table'); $js_messages['strYes'] = __('Yes'); $js_messages['strNo'] = __('No'); diff --git a/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css b/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css index a712408..a087015 100644 --- a/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css +++ b/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css @@ -437,6 +437,7 @@ button.ui-button::-moz-focus-inner { border: 0; padding: 0; } /* reset extra pad */ .ui-dialog { position: absolute; padding: .2em; width: 300px; overflow: hidden; } .ui-dialog .ui-dialog-titlebar { padding: .4em 1em; position: relative; } +div.create-table .ui-dialog-titlebar {display: none; } .ui-dialog .ui-dialog-title { float: left; margin: .1em 16px .1em 0; } .ui-dialog .ui-dialog-titlebar-close { position: absolute; right: .3em; top: 50%; width: 19px; margin: -10px 0 0 0; padding: 1px; height: 18px; } .ui-dialog .ui-dialog-titlebar-close span { display: block; margin: 1px; } Questions: 1. What do you think of this patch? 2. Should we instead remove the title bar for all our jQuery dialogs? P.S. We'll need to be extra careful when updating the jquery ui, by reinserting phpMyAdmin's customizations under themes. -- Marc Delisle http://infomarc.info

5 14

[Phpmyadmin-devel] about the Privileges menu
by Marc Delisle 24 Oct '11

24 Oct '11

Hi, I got a suggestion at the GSoC mentor summit: replace the Privileges menu (the one in server view) with Users. I suggest that for 3.5 we replace it with "Users/Privileges" to ease the transition. -- Marc Delisle http://infomarc.info

4 6

[Phpmyadmin-devel] phpMyAdmin 3.4.7 is released
by Marc Delisle 23 Oct '11

23 Oct '11

Welcome to phpMyAdmin 3.4.7, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Changing ENUM/SET editor dialog
by Rouslan Placella 21 Oct '11

21 Oct '11

Hi all, I'm thinking of switching the ENUM/SET editor from a custom dialog to a modal jQuery-UI dialog for 3.5.0. Any objections to this? Rouslan

2 1

[Phpmyadmin-devel] phpMyAdmin 3.4.7-rc1 is released
by Marc Delisle 19 Oct '11

19 Oct '11

Welcome to the first release candidate of phpMyAdmin 3.4.7, a bugfix release. We plan to release 3.4.7 on Sunday the 23rd, so we expect you to test the rc1 before Sunday :) Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] ready for 3.4.7-rc1?
by Marc Delisle 19 Oct '11

19 Oct '11

Hi, due to the bzip2 export problem in 3.4.6, I propose a shorter cycle for 3.4.7, for example 3.4.7-rc1 today and 3.4.7 during the week-end. By the way, QA_3_4 already has nine fixes. We could also release 3.4.6.1 but users would think there was a security problem. -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] phpMyAdmin 3.4.6 is released
by Marc Delisle 18 Oct '11

18 Oct '11

Welcome to phpMyAdmin 3.4.6, a bugfix and minor security release. Please refer to the upcoming PMASA-2011-15 and -16 announcements on http://www.phpmyadmin.net/home_page/security. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

4 9

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #579
by michal＠cihar.com 16 Oct '11

16 Oct '11

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/579/> ------------------------------------------ Started by an SCM change Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@266bd4a9 Using strategy: Default Last Built Revision: Revision 4d16994ffe7f59770cfc7a1e6ee59827596d78b7 (origin/master) Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@266bd4a9 Fetching changes from the remote Git repository Fetching upstream changes from git://phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin Commencing build of Revision 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f (origin/master) Checking out Revision 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f (origin/master) FATAL: Could not checkout null with start point 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f hudson.plugins.git.GitException: Could not checkout null with start point 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f at hudson.plugins.git.GitAPI.checkoutBranch(GitAPI.java:829) at hudson.plugins.git.GitSCM$4.invoke(GitSCM.java:1136) at hudson.plugins.git.GitSCM$4.invoke(GitSCM.java:1120) at hudson.FilePath.act(FilePath.java:785) at hudson.FilePath.act(FilePath.java:767) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1120) at hudson.model.AbstractProject.checkout(AbstractProject.java:1193) at hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:566) at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:454) at hudson.model.Run.run(Run.java:1403) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:230) Caused by: hudson.plugins.git.GitException: Error performing command: git checkout -f 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f Command "git checkout -f 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f" returned status code 128: fatal: bad revision 'refs/tags/jenkins-phpMyAdmin-continuous-566' at hudson.plugins.git.GitAPI.launchCommandIn(GitAPI.java:742) at hudson.plugins.git.GitAPI.launchCommand(GitAPI.java:707) at hudson.plugins.git.GitAPI.launchCommand(GitAPI.java:717) at hudson.plugins.git.GitAPI.checkoutBranch(GitAPI.java:816) ... 12 more Caused by: hudson.plugins.git.GitException: Command "git checkout -f 2e19a6753f51d7f73e8794af3dc71e65b04dbc6f" returned status code 128: fatal: bad revision 'refs/tags/jenkins-phpMyAdmin-continuous-566' at hudson.plugins.git.GitAPI.launchCommandIn(GitAPI.java:737) ... 15 more

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers