- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Server status Monitor: Query Analyzer Dialog
by Tyron Madlener 21 Jul '11

21 Jul '11

Just some news about my progress: I've spent the last few days fiddling around with regular expressions and dialogs to add another feature which I called 'Query Analyzer', here's an example screenshot: http://www.tyron.at/tmp/query_analyzer.png You can reach this dialog by going to the Monitor Tab, start the monitoring, retrieve some log data (need to enable stuff in setup first), then click on a select statement in the resulting table. I've added some very basic sql formatter to pretty-print the sql query inside an codemirror textarea, so one can fiddle with the query and re-analyze it. Current "bugs": - Parts of the formatted query in the textarea are sometimes white, making them unreadable. Selecting and deselecting fixes it. Looks like a codemirror bug to me. - l10n is incomplete for the query analyzer feature. Further plans: - Analyzed queries are always executed with SQL_NO_CACHE, probably should mention that somewhere - Displaying 'affected rows' probably would be useful - Add some sort of interpretation / advisories on the results, like following performance issues: - 'Using filesort', 'Using temporary' in Explain->Extra - Long query execution time - 'ALL' in explain->type (= full table scan) - Suggestions from you guys ;-) Other things I did this week: - Invested a lot of time in a new log table filter "Group queries, ignoring variable data in WHERE statements" which uses regexps to remove variable data in WHERE statements, so that they can be grouped together, allowing one to see how much similar queries are being executed. - Fixed some bugs with the 'count' column in the log table. Feedback is very welcome.

1 0

Re: [Phpmyadmin-devel] Some bugs in master
by Michal Čihař 20 Jul '11

20 Jul '11

Hi You again missed reply to list, moving discussion back there :-). Dne Tue, 12 Jul 2011 18:48:57 +0300 Tyron Madlener <tyronx(a)gmail.com> napsal(a): > On Tue, Jul 12, 2011 at 3:49 PM, Michal Čihař <michal(a)cihar.com> wrote: > > Hi > > > > Dne Tue, 12 Jul 2011 13:08:37 +0300 > > Tyron Madlener <tyronx(a)gmail.com> napsal(a): > > > >> And one more suggestion: > >> > >> Counting rows in big tables that use CSV as Engine (such as the > >> general_log) seem very slow. Maybe rows should not be counted > >> automatically for CSV Tables and only done upon user request. > >> In my test I counted 36k rows on the demo server, that takes around > >> 250ms, so imagine the general_log running all day. Then you will have > >> 1mil+ rows, which then requires ~6-8 seconds to count. > > > > There is already similar logic for InnoDB or views, so only another > > engine should be added here. > > Do you know in which file/line this is? It should be libraries/display_tbl.lib.php somewhere near usage of MaxExactCount. > Next suggestion :D > Just saw in header_scripts.inc.php that codemirror.js and mysql.js is > included globally. Isn't that a bit overkill? Not every page (like my > status page) requires codemirror. I don't think it hurts that much (browser should have that file in cache), generally I was too lazy to figure out in which all places SQL box needing highlighting might appear. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

3 6

[Phpmyadmin-devel] problem with column dragging
by Marc Delisle 19 Jul '11

19 Jul '11

Tyron, could you have a look at your commit a5df22ced5067260b5edbb3d95b83cc8050d21a9 ? In my tests, this commit breaks column dragging. For example, in sakila.actor, try to drag actor_id to the rightmost position. -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] Undefined variable in zip.lib.php
by Piotr Przybylski 18 Jul '11

18 Jul '11

Hi, file() method in zip.lib.php refers to an undefined variable $data. Michal, can you take a look at it? -- Regards, Piotr Przybylski

2 1

[Phpmyadmin-devel] Better chart reordering for monitor tab
by Tyron Madlener 18 Jul '11

18 Jul '11

Just built a reusable jquery plugin for elegant reordering of table cells. I will be using it for the Monitor Tab as it greatly improves the usability of chart reordering (mainly because I want the user to select a column width and have automatic chart size, instead of setting a chart size and have automatic column width): http://www.tyron.at/tmp/ts.html There is still a bug when an element is dropped before the 'preview animation' is over (200ms). But apart from that it's kinda fun to play with, thus I'm posting it here ;-)

6 20

[Phpmyadmin-devel] Unit testing
by Michal Čihař 18 Jul '11

18 Jul '11

Hi all (and especially Zarubin :-)) I started to setup testing server, however I'm somehow stuck. I followed http://wiki.phpmyadmin.net/pma/TestingEnvironment and I believe I have all components in place. However running all tests is something I can not manage. http://wiki.phpmyadmin.net/pma/UnitTesting mentions some configuration files, but no matter what I try, the tests are not run. Running single test seems to work: $ phpunit test/libraries/core/PMA_isValid_test.php PHPUnit 3.5.5 by Sebastian Bergmann. PMA_isValid_test testNoVarType ............ .................... testSimilarType ...... . Time: 0 seconds, Memory: 8.25Mb OK (39 tests, 68 assertions) Writing code coverage data to XML file, this may take a moment. Generating code coverage report, this may take a moment. However there seems to be wrong configuration somewhere using backslashes instead of slashes so it creates files like build\logs\junit.xml -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 7

[Phpmyadmin-devel] XML export
by Piotr Przybylski 15 Jul '11

15 Jul '11

Hi, Is XML export used at all? It was missing data escaping in many places, and structure (table, function, ...) export was just broken. I fixed it a bit, but there are still some problems that remain: - escaping of table/db names and data in other encodings than ISO-8859-1 - it uses SHOW CREATE TABLE without any required fixes File format itself is interesting. I don't expect XML Schema for it to exist, but at least namespace usage should be consistent. I think fixing this and rewriting output format to be more consistent should appear on Tasks for junior developers. And maybe extending it to output data in more concise format, eg.: <table name=""> <row> <column_name>value</column_name> ... </row> ... </table> -- Regards, Piotr Przybylski

3 13

Re: [Phpmyadmin-devel] zoom-search and editing
by Ammar Yasir 15 Jul '11

15 Jul '11

On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir <ammaryasir.88(a)gmail.com>wrote: > > > On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir <ammaryasir.88(a)gmail.com>wrote: > >> >> >> On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir <ayax88(a)gmail.com> wrote: >> >>> >>> >>> On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle <marc(a)infomarc.info>wrote: >>> >>>> Le 2011-07-11 21:26, Ammar Yasir a écrit : >>>> > >>>> > >>>> > On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc(a)infomarc.info >>>> > <mailto:marc@infomarc.info>> wrote: >>>> > >>>> > Le 2011-07-09 22:59, Ammar Yasir a écrit : >>>> > > >>>> > > >>>> > > I've done a basic version of edit functionality. I added a >>>> unique >>>> > > identifier for each row in the query result data by using the >>>> > > PMA_getUniqueCondition() from the common.lib.php file >>>> > (where_clause). I >>>> > > then generate the update query in the edit submit event using >>>> > this where >>>> > > clause and post it to sql.php. The return data is added to the >>>> > > <sqlqueryresult> div to show the query executed and the >>>> message. The >>>> > > plot also updates on submit if one of the axes is updated. Is >>>> my >>>> > logic >>>> > > is okay? >>>> > > I've pushed my work and you can try scenarios on the film_actor >>>> > table in >>>> > > the sakila database. >>>> > >>>> > Ammar, >>>> > I tried with the film table, changing the "title" column and got >>>> > this error: >>>> > value is undefined at line 177 in js/tbl_zoom_plot.js. >>>> > >>>> > Fixed some issues and pushed it to my repo. Had to add checkboxes for >>>> > null condition on fields (in Data point content section). >>>> >>>> It works fine now. >>>> Please don't forget the issue of generating the default data label based >>>> on the "display field". >>>> >>> >> Fixed this, default label is taken from table display field. >> Also changed the type of xAxis to linear (t defaulted to timeline >> earlier). >> >> There was a small thing I noticed on the row edit feature. >> When the form is displayed for row edit and some field is null, the 'Null' >> checkbox is checked. When we select some value it is unchecked. It should be >> checked again if we select the value empty or null but it does not. If we >> forget to check it back this will give an SQL error. >> Screenshot attached for the sakila db film table where >> original_language_id is null, and if I miss checking it back I'll get an SQL >> error. >> > Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/ > > >> >>>> Yes, working on it now. >>> >>>> -- >>>> Marc Delisle >>>> http://infomarc.info >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> All of the data generated in your IT infrastructure is seriously >>>> valuable. >>>> Why? It contains a definitive record of application performance, >>>> security >>>> threats, fraudulent activity, and more. Splunk takes this data and makes >>>> sense of it. IT sense. And common sense. >>>> http://p.sf.net/sfu/splunk-d2d-c2 >>>> _______________________________________________ >>>> Phpmyadmin-devel mailing list >>>> Phpmyadmin-devel(a)lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> AppSumo Presents a FREE Video for the SourceForge Community by Eric >>> Ries, the creator of the Lean Startup Methodology on "Lean Startup >>> Secrets Revealed." This video shows you how to validate your ideas, >>> optimize your ideas and identify your business strategy. >>> http://p.sf.net/sfu/appsumosfdev2dev >>> >>> _______________________________________________ >>> Phpmyadmin-devel mailing list >>> Phpmyadmin-devel(a)lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >>> >>> >> >

2 12

[Phpmyadmin-devel] zoom-search: need to push code?
by Marc Delisle 14 Jul '11

14 Jul '11

Hi Ammar, from your week 5 report, it seems that some of the code has not been pushed. Your repo's last push is: commit eaea0030641c6be215915684bcd40930ae2d61c8 Author: Ammar Yasir <ammaryasir.88(a)gmail.com> Date: Tue Jun 21 05:04:00 2011 +0530 -- Marc Delisle http://infomarc.info

3 14

[Phpmyadmin-devel] Monitor and js error
by Marc Delisle 13 Jul '11

13 Jul '11

Tyron, as tested in FF 5.0 / Windows XP: when I change the number of columns, I get "destroy is not defined" from js/jquery/jquery.sortableTable.js at line 110. Latest commit 564150bd5267a75e0ebbf732ec74acfe43d34562. -- Marc Delisle http://infomarc.info

2 2