- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Support for Routines, Triggers and Events merged into master
by Rouslan Placella 13 Jul '11

13 Jul '11

Hi there, Just to let you know that support for Routines, Triggers and Events has been merged into master. I would appreciate if you had a look at it and let me know your opinion and/or any issues you may find. Thanks. Bye, Rouslan

1 0

[Phpmyadmin-devel] Some bugs in master
by Tyron Madlener 12 Jul '11

12 Jul '11

While working on the Status page monitor I noticed some bugs in the current master demo: - In table structure and table browse, the functions you can use on multiple rows ( Check All / Uncheck all With selected: [ the links here ]) are not marked as links anymore. The cursor doesn't turn into a hand either when hovering over. Also there's lots of unnecessary horizontal space between the links. - Create following table: CREATE TABLE IF NOT EXISTS `test` ( `test` datetime NOT NULL, `idx` int(11) NOT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1; then go to the SQL tab and execute the following: INSERT INTO `test` VALUES('0000-00-00 00:00:00', 1); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 2); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 3); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 4); INSERT INTO `test` VALUES('0000-00-00 00:00:00', 5); This will cause the loading message to appear and disappear a second later with no feedback of whether the query was successful - On my thinkpad with a resolution of 1024x768 its almost impossible to create a table, since both 'create table' links now open a jquery dialog. We really need to fix that create table dialog. - On the table structure page: Maybe there should be a bit of vertical space between the table links and the "table structure html table". And the oversize "Indexes" Title seems very out of place there. "show/hide indexes" should also hide the create index box. Why does the 'create index' need that big empty box anyway? This could be replaced with a 'Create index' link altogether, that opens up a jquery dialog containing a link "add another index" that adds another row to the html table there. But yea, that's not a bug :D

3 5

[Phpmyadmin-devel] Obsoleting 2.11
by Michal Čihař 12 Jul '11

12 Jul '11

Hi all I think it's time to officially obsolete 2.11 branch. The PHP and MySQL versions it supports are anyway no longer supported by their upstreams. Any objections to removing all mentions of 2.11 from website? -- Michal Čihař | http://cihar.com | http://blog.cihar.com

5 13

Re: [Phpmyadmin-devel] Zoom Search
by Ammar Yasir 12 Jul '11

12 Jul '11

On Sat, Jun 4, 2011 at 9:57 PM, Ammar Yasir <ammaryasir.88(a)gmail.com> wrote: > > > On Wed, Jun 1, 2011 at 7:47 PM, Madhura Jayaratne <madhura.cj(a)gmail.com>wrote: > >> >> >> On Wed, Jun 1, 2011 at 5:30 PM, Marc Delisle <marc(a)infomarc.info> wrote: >> >>> Madhura Jayaratne a écrit : >>> > >>> > >>> > On Wed, Jun 1, 2011 at 4:30 PM, Madhura Jayaratne < >>> madhura.cj(a)gmail.com >>> > <mailto:madhura.cj@gmail.com>> wrote: >>> > >>> > >>> > >>> > On Wed, Jun 1, 2011 at 2:10 AM, Ammar Yasir < >>> ammaryasir.88(a)gmail.com >>> > <mailto:ammaryasir.88@gmail.com>> wrote: >>> > >>> > >>> > >>> > On Wed, Jun 1, 2011 at 1:55 AM, Marc Delisle < >>> marc(a)infomarc.info >>> > <mailto:marc@infomarc.info>> wrote: >>> > >>> > Ammar Yasir a écrit : >>> > > >>> > > >>> > > On Tue, May 31, 2011 at 10:14 PM, Marc Delisle >>> > <marc(a)infomarc.info <mailto:marc@infomarc.info> >>> > > <mailto:marc@infomarc.info <mailto:marc@infomarc.info >>> >>> >>> > wrote: >>> > > >>> > > Ammar Yasir a écrit : >>> > > >>> > > > Parts refactored are: >>> > > > - Setting titles (titles['Browse']]) >>> > > > - getting fields list (getting column details) >>> > > > - setting sub-tabs (Table search and Zoom search) >>> > > > - setting table header of QBE display >>> > > > - displaying foreign data >>> > > > - search criteria input elements (HTML content >>> > generation for the >>> > > input >>> > > > elements) >>> > > >>> > > Very good! >>> > > >>> > > Another trick you can use: when a function returns >>> an >>> > array, like your >>> > > PMA_tbl_getFields(), to fill all the returned values >>> > in one statement >>> > > you can use this syntax: >>> > > >>> > > list($fields_list, $fields_type, $fields_collation, >>> > $fields_null) = >>> > > PMA_tbl_getFields($table,$db); >>> > > >>> > > >>> > > I made some more changes. >>> > >>> > OK. There are still a few tab characters (found some in >>> > libraries/tbl_select.lib.php). >>> > >>> > > Should I proceed now to try the charting libraries? >>> > >>> > Yes but in your proposal you wrote that you preferred >>> > jQuery-SVG so I >>> > assume you'll try this one first? >>> > >>> > I'll try SVG first. I'm following what others have to say about >>> > SVG, Madhura is using it for his GIS visualization. Tyron >>> > proposed real-time charting but I don't think it'll be of much >>> > help in our case. >>> > >>> > >>> > Hi Ammar, >>> > >>> > I'm not sure what exactly your requirement is. But pls have a look >>> > at the visualization of data at [1] by clicking on the 'Visualize >>> > GIS data' link in the 'Query results operations' section towards >>> the >>> > bottom of the page. Try out zooming by double clicking and panning >>> > by dragging. I believe you are looking for something like this for >>> > your zoom search feature. >>> >>> Madhura, >>> >>> I have issues operating panning and zooming. Here is the scenario: >>> >>> 1. Browse world_cities and click Visualize GIS data >>> 2. Click-drag: pans OK >>> 3. Double-click: this is a zoom out, I guess >>> 4. Click-drag: no panning >>> 5. Click "zoom out": data points are enlarging, isn't this a zoom-in? >>> >>> Marc, >> >> This is a Firefox compatibility problem. Resolved and pushed to the repo. >> Demo will take some time to upgrade to the new version. Meanwhile if you >> have Chrome, you can still experience what it's suppose to do. >> >> >> -- >> Thanks and Regards, >> >> Madhura Jayaratne >> >> >> Hi, > I was looking up jQuery-SVG and SVG past two days. There has been a > discussion going on in the list about whether to include a different > plotting library than existing(pChart). For now, instead of including > another plotting library, I've developed a prototype that creates the plot > using just SVG. I'll push it to my repo sometime later today. > >> >> Hi, I've pushed my work. The basic plot functionality is implemented along with classes for the same. Currently it works only for numeric fields, I'll add support for other data types after some testing. You can try scenarios in 'sakila' database and search 'films' or 'film_actor' table. Regards, Ammar Yasir > >> ------------------------------------------------------------------------------ >> Simplify data backup and recovery for your virtual environment with >> vRanger. >> Installation's a snap, and flexible recovery options mean your data is >> safe, >> secure and there when you need it. Data protection magic? >> Nope - It's vRanger. Get your free trial download today. >> http://p.sf.net/sfu/quest-sfdev2dev >> _______________________________________________ >> Phpmyadmin-devel mailing list >> Phpmyadmin-devel(a)lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel >> >> >

4 15

[Phpmyadmin-devel] i10n: String formatting in JS?
by Tyron Madlener 11 Jul '11

11 Jul '11

In PHP we have sprintf / printf to properly format language strings, but do we got any equivalent for javascript? There's nothing documented about it on the wiki.

3 13

[Phpmyadmin-devel] About the AJAXification of the index editor
by Rouslan Placella 11 Jul '11

11 Jul '11

Hi Thilanka (and everyone else), You filed bug #3350790 on the tracker, which I looked into and fixed earlier. This also gave me a chance to look at the AJAXification of the index editor, which as I can see from your blog you have deemed completed. Anyway, I found some issues in your implementation and thought you might want to know about them. First, the JS errors from bug #3350790 are gone, but the functionality from checkIndexName() function in indexes.js only works in the QA_3_4 branch. This is due to the AJAXification that you did. That function was written in plain JS, when there was no jQuery or AJAX. Line 44 in that file should have been a dead giveaway that the function was about to break (onload = checkIndexName;), since a browser does not fire an onload event for AJAX requests. Anyway, I think that the checkIndexName() function should be rewritten in jQuery and then called inside the AJAX request from tbl_structure.js. Also there is some inline JS in tbl_indexes.php, which you may want to rewrite in jQuery if you will be rewriting checkIndexName(). Now for the fun stuff... Try this: * go to `sakila` db * go to `actor` table * go to structure tab * click on "Edit" link for the primary key * in the ajax dialog click 'Cancel' * click again on "Edit" link for the primary key * in the dialog click on "Go" (to add more rows to the table) Expected result: * 1 row is added to the table of indices Actual result: * The table of indices is cloned and 1 row is added to the first table Another thing is that the AJAX dialog should really be modal (you can make the dialog modal by adding "modal: true," to the dialog options in jQuery). Try this: * go to `sakila` db * go to `actor` table * go to structure tab * click on "Edit" link for the primary key * without closing the AJAX dialog, move it out of the way * click on "Edit" link for the `idx_actor_last_name` index * inside this new dialog click "Save" Expected result: * the dialog for `idx_actor_last_name` is submitted Actual result: * the dialog for the primary key is submitted Another bug: * go to `sakila` db * go to `actor` table * go to structure tab * click on "Edit" link for the primary key * set all rows in the table to "--ignore--" * click "Save" Expected result: * An error message Actual result: * An empty AJAX message Another thing is that the new function that you wrote to handle the SPATIAL indices doesn't actually work. The problem is that its event is attached using jQuery's 'bind' method, which is unsuitable for your purposes. I think that you should use the 'live' method that allows for late binding. After you do that, you will notice that the function still doesn't work as expected. This is because in this function you assume that you will always have one instance of each element that you reference by ID. However once the DOM has registered an element with a particular ID (open a dialog), even if you destroy that element and recreate it (close dialog/ open new dialog), the DOM will still reference the original, and now non-existent, element. The best way to deal with this is to use classes, then search for objects inside some common parent element. I guess that this is quite a mouthful of an email, hope it helps. Bye, Rouslan

3 15

[Phpmyadmin-devel] Stopping promotion of phpMyAdmin 2.11
by Marc Delisle 11 Jul '11

11 Jul '11

Hi, on http://www.phpmyadmin.net/home_page/downloads.php I suggest to remove the 2.11.x section. It looks like we are promoting it (along with older PHP and MySQL versions). The "Older releases" section should be enough. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Importing GIS data from ESRI shape files
by Madhura Jayaratne 11 Jul '11

11 Jul '11

Hi all, During the last two weeks I worked on the above feature and now it is ready and you can test it on the demo server. [1] Though normally .shp files are referred to as shape files, shape files consist of a set of files and out of those .shp and .dbf files contains data important to us. Since the import feature in PMA does not support importing multiple files you can either zip them into a zip archive or upload them the UploadDir in advance and then use them for the purpose of importing. However you can still import only the .shp file and this will import the GIS data in it. You can read more details about this feature in my blog posts [2] and [3]. I have added the tracker artifact [4] which contains few ESRI shape files you can use to check this feature. Any feedback on this is highly appreciated. -- Thanks and Regards, Madhura Jayaratne [1] http://demo.phpmyadmin.net/gsoc-madhura/index.php [2] http://madhuracj.blogspot.com/2011/07/sixth-week-of-gsoc.html [3] http://madhuracj.blogspot.com/2011/07/seventh-week-of-gsoc.html [4] https://sourceforge.net/tracker/?func=detail&aid=3362549&group_id=23067&ati…

1 0

Re: [Phpmyadmin-devel] Show/hide column feature
by Aris Feryanto 11 Jul '11

11 Jul '11

----- Original Message ----- > From: Piotr Przybylski <piotr.prz(a)gmail.com> > > 2011/7/10 Aris Feryanto <aris_feryanto(a)yahoo.com>: >> Hi Piotr, >>> >>> 2. Clickable area with column name may not span correctly in available >>> space if columns have short names [1]. It may not look too bad in >>> English, but in Polish "Show all" translates to much longer >>> "Pokaż >>> wszystkie". Maybe checkboxes should be inside <label>s with >>> display:block instead of using table for layout? Or styled <dl>, > but >>> this would require much more CSS to make it look right. >>> >>> [1] http://img829.imageshack.us/img829/1531/hidecolumns.png >>> >> >> Fixed in my git [1]. For the fix, I use nested div, instead of table for > layout. >> > > One more thing. > > + $(listElmt).html('<input type="checkbox" ' > + > (g.colVisib[i] ? 'checked="checked" ' : '') + > '/>' + > + $(currHeader).text()); > > You use raw text - $(currHeader).text() - as HTML code. If a column is > named "buggy<!--" then it isn't displayed properly in column > list. Use > $element.text('here goes any text') to set element's text. In this > version you just lose part of the column, but before this commit the > entire list after such column was broken. > > You can use this SQL to create test table: > create table escape_test (`buggy<!--` int, second int); > insert into escape_test values(1,1); Hi Piotr, That's right. I didn't know that we can use some special characters in column's name. I fixed it in my git. Thank you for your feedback. -- Aris Feryanto

1 0

[Phpmyadmin-devel] Ajax and "Insert for a table in Database structure"
by Marc Delisle 09 Jul '11

09 Jul '11

Thilanka, There is a problem with this feature: when the table has a DATETIME column, the picker icon does not show up. Have a look at [0] where Rouslan explains that he fixed a similar problem in his repository. [0] https://sourceforge.net/tracker/index.php?func=detail&aid=3354360&group_id=… -- Marc Delisle http://infomarc.info

3 7