Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] git help -- finding in which tag/release a revision occurs
by Isaac Bennetch 06 Aug '10

06 Aug '10

Hi, hopefully one of you can help me figure out a git question I have. I know the specific revision where a change occurred -- for example rRELEASE_3_3_4-5777-gd7192b3 (DefaultCharset depreciated), but what I want to know is what release version that change will affect. Any hints how I can figure out in which release this will occur? Thanks, ~isaac

3 5

[Phpmyadmin-devel] Inline editing and updated values
by Ninad Pundalik 05 Aug '10

05 Aug '10

Hi, During the saving of an inline edit, I'm generating the update query with JavaScript on the client side, and posting it to tbl_replace.php, which prepares some variables for sql.php. sql.php then executes the update query, and generates an output in JSON, which is evaluated by jQuery at the client side. If the query has been successful, the values that were in the textarea/input fields, are taken as the new value for that field and the HTML is updated to that effect. The above process creates a few problems for me. When the table being edited has a foreign key or transformed field, the javascript does not know what is the value to be displayed after a successful edit. For the foreign keys, I am generating the anchor at the server side in sql.php and adding it to the JSON output. However, the anchor is not being generated correctly, as the WHERE clause is missing. After the query has been executed, sql.php does not know the values of individual fields, and hence, I cannot generate the WHERE clause necessary for the anchor. Similarly, for transformations, I don't have the value of the field, and hence, I cannot transform the new value to generate the HTML, which I can add to the JSON output. In libraries/display_tbl.lib.php, the WHERE clause is generated on the fly for each field, as '= <field's value>', while the transformation is done in the function PMA_prepare_row_data(). The solution I have in mind for the transformation problem is to post an associative array to tbl_replace.php containing the field name and it's new value, which I'll use after the query has been executed and generate the HTML with this array. As for the first problem (foreign key's anchor), I've been stuck at it for some time and can't see a way out. Could someone suggest a better solution? Thanks! -- Ninad S. Pundalik

2 7

[Phpmyadmin-devel] Continue support for IE6?
by Lori Lee 04 Aug '10

04 Aug '10

I encountered a bug in IE6 where the z-index of <select> elements is always higher than of other elements, regardless of their z-index, i.e. <select> elements always appear on top of everything else. This is a problem for PMA because the tooltip feature becomes blocked and you can't read the text inside: http://lorilee1.files.wordpress.com/2010/08/ie_edit-e1280869355294.png http://lorilee1.files.wordpress.com/2010/08/ie_export-e1280869331806.png <http://lorilee1.files.wordpress.com/2010/08/ie_export-e1280869331806.png>The fix for this is to position an iframe directly on top of every single <select> element to just cover it, though it's really just an hack. I'm wondering if it's even necessary to continue supporting IE6. (Google stopped supporting it for YouTube...) -- Thanks, Lori

2 2

[Phpmyadmin-devel] Session expiration
by Marc Delisle 01 Aug '10

01 Aug '10

Hi, is someone able to reproduce this problem? https://sourceforge.net/tracker/index.php?func=detail&aid=3037078&group_id=… Please add your comments in the tracker, thanks. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Inline editing and relational data
by Marc Delisle 30 Jul '10

30 Jul '10

Ninad, just to be sure you are aware of all the issues, here is a little overview. When you do "normal" edit of data, relational data (not just foreign keys) is fetched. It can come from foreign keys (InnoDB, PBXT), or from phpMyAdmin's configuration storage, see libraries/relation.lib.php in PMA_getForeigners() and the "source" parameter. Also, $cfg['ForeignKeyMaxLimit'] plays an important role. This is because we don't way to display a too big drop-down for the possible values. If these are more than this limit, a link to browse_foreigners.php is displayed, showing a distinct window with search capabilities. There is also a "display field" that represents each row (for example, the key would be "id" and the display field would be "city name"). How do you plan to present relational data in the inline interface? -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] "_gat is not defined" and other javascript errors
by Lori Lee 29 Jul '10

29 Jul '10

I have been doing some browser testing and found some errors that pop up in IE8 and some older versions of IE. These are the messages and snippets of code that they come from (I found them using DebugBar). *code*: <script type="text/javascript" id="ga"> var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www."); //document.write(unescape("%3Cscript src='" + gaJsHost + " google-analytics.com/ga.js' type='text/javascript'%3E%3C/script%3E")); var tag = document.createElement("script"); tag.setAttribute("src", gaJsHost + "google-analytics.com/ga.js"); tag.setAttribute("type", 'text/javascript'); *document.getElementById("ga").insertBefore(tag, document.getElementById("ga-script"));* </script> *error*: "Unexpected call to method or property access." * * *code*: <script type="text/javascript" id="ga-script"> *var pageTracker = _gat._getTracker("UA-2718724-5");* window.google_analytics_uacct = "UA-2718724-5"; pageTracker._trackPageview(); </script> *error*: "_gat is undefined" *code*: <script type="text/javascript" id="ga-script"> var pageTracker = _gat._getTracker("UA-2718724-5"); window.google_analytics_uacct = "UA-2718724-5"; *pageTracker._trackPageview();* </script> *error: *"pageTracker is null or not an object" (propagated from the previous error I am assuming) *code*: <script type="text/javascript" id="piwik"> var pkBaseURL = (("https:" == document.location.protocol) ? " https://stats.cihar.com/" : "http://stats.cihar.com/"); //document.write(unescape("%3Cscript src='" + pkBaseURL + "piwik.js' type='text/javascript'%3E%3C/script%3E")); var tag = document.createElement("script"); tag.setAttribute("src", pkBaseURL + "piwik.js"); tag.setAttribute("type", 'text/javascript'); *document.getElementById("piwik").insertBefore(tag, document.getElementById("piwik-script"));* </script> *error: *"Unexpected call to method or property access." I haven't been able to fix these but I thought it was worth bringing up. The first and last errors seem to be essentially the same error. -- Thanks, Lori

2 2

Re: [Phpmyadmin-devel] Martynas tree - minor points
by Herman van Rink 29 Jul '10

29 Jul '10

On 07/29/2010 03:26 PM, Martynas Mickevičius wrote: > I fixed the first two points. Could you post an image of that squeezed > title text? I also get a little bit different rendering on my local > machine and on the demo server. But the ones in the demo server are > still readable. Here is an attachment, showing the squeezed text. I use the Debian version: php5-gd 5.2.6.dfsg.1-1+lenny8 After pulling your latest update and refreshing it looks better.... I'm not sure why, but that's the Screenshot-1.png file -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions > > 2010/7/29 Herman van Rink <rink(a)initfour.nl <mailto:rink@initfour.nl>> > > Martynas, > > A few minor points I ran into while clicking through your tree. > > * libraries/chart/pma_pchart_chart.php > Maybe the render() function could use a bit of comment > > * tbl_chart.php > Contains un-translated strings > > * The title of the top of the chart images is not readable for > me... it > looks like the text is squeezed somehow. > > Overall I'd say: Nice going > > -- > > Met vriendelijke groet / Regards, > > Herman van Rink > Initfour websolutions > >

1 0

Re: [Phpmyadmin-devel] Martynas tree - Git merge
by Martynas Mickevičius 29 Jul '10

29 Jul '10

Thanks for this message. I completely forgot about the Master. I merged my fork with the master and pushed the changes now. 2010/7/29 Herman van Rink <rink(a)initfour.nl> > Martynas, > > I tried to merge the current master into your branch, just for the fun > of it. Only server_status.php had a merge conflict, just the added > require_once './libraries/chart.lib.php'; and it's comment block which > interfered with another change. > So maybe it's a good idea to merge master every now and then. > I'd hate to have a problem later when we try to merge your tree back > into master. > > -- > > Met vriendelijke groet / Regards, > > Herman van Rink > Initfour websolutions > > >

1 0

[Phpmyadmin-devel] Piotr's tree and sensible options
by Marc Delisle 27 Jul '10

27 Jul '10

Hi Piotr, is there a way for a sysadmin (of a shared phpMyAdmin installation) to indicate which setting is available or not for "normal" users? I'm asking because I know, for example, that some sysadmins want to disable the "Show detailed MySQL server info" for all their users. I'm not saying that we need such mechanism, but we'll have to be careful in the choices we give to users if they are perceived by sysadmins as related to security. -- Marc Delisle http://infomarc.info

2 11

[Phpmyadmin-devel] User configurability of SQL validator
by Michal Čihař 27 Jul '10

27 Jul '10

Hi does it make sense to include SQL validator in user settings? First it has some dependencies (SOAP) and it really does not make sense to allow user to enable it unless they are satisfied (he will get only errors). The more important is that I believe this is something what admin should control, as it makes connection to untrusted server, which could be easily used to some exploit if exploitable bug is found in SOAP extension or lower functions which SOAP extension do use. Also sending queries to third party is again something admin might don't want but user won't see it problematic. So I think this option could be controlled by user only once admin has allowed it. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers