- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] User configurability of SQL validator
by Michal Čihař 27 Jul '10

27 Jul '10

Hi does it make sense to include SQL validator in user settings? First it has some dependencies (SOAP) and it really does not make sense to allow user to enable it unless they are satisfied (he will get only errors). The more important is that I believe this is something what admin should control, as it makes connection to untrusted server, which could be easily used to some exploit if exploitable bug is found in SOAP extension or lower functions which SOAP extension do use. Also sending queries to third party is again something admin might don't want but user won't see it problematic. So I think this option could be controlled by user only once admin has allowed it. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 2

[Phpmyadmin-devel] Lori tree and views
by Michal Čihař 27 Jul '10

27 Jul '10

Hi Lori tree (table overview) seems to have problems in handling views: Notice in ./tbl_structure.php#485 Undefined variable: unique_enabled Notice in ./tbl_structure.php#497 Undefined variable: index_enabled Notice in ./tbl_structure.php#509 Undefined variable: fulltext_enabled Can be seen here: http://demo.phpmyadmin.net/gsoc-lorilee/tbl_structure.php?db=sakila&table=c… (The first two errors are coming from master, reported as bug #3035300.) -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 1

[Phpmyadmin-devel] Moving Drop/Truncate to operations
by Michal Čihař 27 Jul '10

27 Jul '10

Hi it has been already opened in another thread, but just to make the discussion separate, I start it again. I don't think there is much sense having Drop/Truncate as tabs. First of all these are not tabs leading to some specific page, but rather an actions. Second I think these are quite rarely used actions so they don't deserve such prominent place. How about moving these to Operations tab, just like other things to do with table/database? -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 9

[Phpmyadmin-devel] Inconsistent format strings
by Michal Čihař 27 Jul '10

27 Jul '10

Hi for several times I wondered why we use so many different ways to create format strings, let's take three examples: $cfg['DefaultQueryTable'] = 'SELECT * FROM %t WHERE 1'; where * %d will be replaced by the database name. * %t will be replaced by the table name. * %f will be replaced by a list of field names. $cfg['Export']['file_template_table'] = '__TABLE__'; where __TABLE__, __DB__ and __SERVER__ are used $cfg['TitleTable'] = '@HTTP_HOST@ / @VSERVER@ / @DATABASE@ / @TABLE@ | @PHPMYADMIN@'; where @HTTP_HOST@, @SERVER@, @VERBOSE@, @VSERVER@, @DATABASE@, @TABLE@ and @PHPMYADMIN@ can be used How about making use just single way to do this and create common function which will do the formatting? I'm somehow more inclined to use %x, however @SOMETHING@ is more self documenting, while __SOMETHING__ looks just too long to me. I know this would be incompatible change, but it looks like we're making enough other big changes for next major version so that it won't be that big issue. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 6

[Phpmyadmin-devel] Top menus redesign
by Piotr Przybylski 26 Jul '10

26 Jul '10

Hi, I want to change top menus to hide some rarely used settings [1] and make it fit in one line. Currently I do it by a short JS code which takes a few tabs and places them under the "More" menu, but I'm thinking about outputting final HTML code and making it a pure CSS menu (using a:hover on "More" to show it). Should I go on with it? [1] http://img338.imageshack.us/img338/7941/newtabs.png (still requires some more styling) -- Piotr Przybylski

4 21

[Phpmyadmin-devel] phpMyAdmin 3.3.5 is released
by Marc Delisle 26 Jul '10

26 Jul '10

Welcome to phpMyAdmin 3.3.5, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Linked-tables infrastructure
by Michal Čihař 26 Jul '10

26 Jul '10

Hi we still call it "Linked-tables infrastructure", however I think this name has gotten quite non descriptive after time. Any idea for better name? - Additional metadata tables - phpMyAdmin extended data storage ... -- Michal Čihař | http://cihar.com | http://blog.cihar.com

6 14

[Phpmyadmin-devel] document.write() and jQuery conflicts on the demo server
by Ninad Pundalik 25 Jul '10

25 Jul '10

Hi, Since yesterday, I've been trying to figure out what has been causing the blank pages on the 'Add New User' and 'Create Table' actions on the demo server [0] (while it works fine on my system). I've narrowed it down to two calls to document.write(), which are a part of the Google Analytics and Piwik code. When jQuery inserts content retrieved over an Ajax call into the DOM, it evaluates the inline javascript. [1] One possible, partial solution is to do what John Resig has shown in this blogpost [2], to write a more compliant document.write() function. However, he admits that this is only a partial solution and is not cross-browser. I've been trying to hack around, but I've not been successful in resolving this issue. Has anyone come across a better solution? ----------------------------------------------------- [0] - http://demo.phpmyadmin.net/gsoc-ninadsp/ [1] - http://api.jquery.com/jQuery.ajax/ (documentation for the dataType parameter explains how inline JS is handled) [2] - http://ejohn.org/blog/xhtml-documentwrite-and-adsense/ ----------------------------------------------------- Ninad S. Pundalik Twitter: @ni_nad | Identica : @ninad | http://ninadpundalik.co.cc/blog GPG Key Fingerprint: 2DF7 B856 C75E C9F9 0504 C0EF D456 1946 7C45 2C69

5 18

[Phpmyadmin-devel] Incorrect number of affected rows displayed after editing a row
by Ninad Pundalik 25 Jul '10

25 Jul '10

Hi, I got basic inline editing working for fields that are not transformed/relational/enum fields a while back, by posting the changes to tbl_replace.php. This is the same script that is called by tbl_change.php, the script that is used to edit a row in a table without the use of JS. After tbl_replace.php parses the request, it includes sql.php, which executes the SQL query that actually updates the table for me during the Ajax request. However, the message that is shown at the end of the Ajax request is '0 rows affected (Query took foo seconds)'. Clearly, something is not right and the $num_rows variable is not being correctly populated by PMA_DBI_affected_rows(). I used the Netbeans debugger to dig around a little, and there is no query other than the update query being executed before the call to PMA_DBI_affected_rows(). What could cause this? This behaviour can be seen in commit c0db21c to my repository. -- Ninad S. Pundalik

2 8

[Phpmyadmin-devel] Schema Export to Visio format
by Adnan 24 Jul '10

24 Jul '10

hi, I am trying to understand the XML of Visio. So, I could generate that XML for visio. But when I save VDX file in MS Visio 2010 It saves a lot of XML tags. I am researching a lot that what is best way to understand like DIA XML. I am posting here if someone could guide me. If anyone have example of generating XML for Visio using C# or any language. please forward me. Thanks -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..!

2 1