- Developers - lists.phpmyadmin.net

Re: [Phpmyadmin-devel] about PMA_THEME_VERSION
by Michal Čihař 02 Aug '06

02 Aug '06

Hi all I think this should go to -devel so I post it here :-). On Wed, 02 Aug 2006 08:23:31 -0400 Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote: > I discussed with Sebastian and I would like your opinion, since > Sebastian and I disagree. > > In the doc we say > "Themes within same generation should be backwards compatible > - theme with version 2 should work in phpMyAdmin requiring version 1. > > Themes with different generation are incompatible." > > In Config.class.php, Sebastian marked deprecated PMA_THEME_VERSION and > PMA_THEME_GENERATION. > > In Theme.class.php, there is a checkVersion() function that > 1. uses version_compare(), which would not give the level of > verification we need, and > 2. is never used :) > > Sebastian says that a user should see all the installed themes and be > able to choose them, even if they are not compatible; he says that a > user should be able to notice by himself that a theme is outdated. I think showing all themes is sensible way to go. Otherwise if user installs old theme, it is hard to find out what's going on. And I saw such problem several times. However user might not be able to notice this himself, so I'd put warning on bottom of main.php if theme is outdated (saying that some parts might be displayed wrongly due to too old theme). The only problem is how to check whether theme is compatiblem. I thought generation/version will be best solution when I wrote that code, because I expected theme changes don't have to be with each version... -- Michal Čihař | http://cihar.com | http://blog.cihar.com

4 12

[Phpmyadmin-devel] saving server, db and table in cookie
by Sebastian Mendel 02 Aug '06

02 Aug '06

Hi, i would like to introduce saving server, db and table in cookie too, but only checked in index.php so a user will always return to the last opened server/db/table // with true phpMyAdmin will save last opened server/db/table in a // cookie and restore it when phpMyAdmin re-opens $cfg['RememberLastPosition'] = true; -- Sebastian Mendel www.sebastianmendel.de

6 28

[Phpmyadmin-devel] 2.9.0-beta1 showstoppers?
by Marc Delisle 02 Aug '06

02 Aug '06

Hi, Apart from sending a message to translators and receiving their updates, I think that the auto-numbering issue in Documentation.html is the biggest (maybe the only) showstopper before 2.9.0-beta1. https://sourceforge.net/tracker/index.php?func=detail&aid=1446538&group_id=… I remind you that this feature only works in FF 1.5. I saw it non-working on IE 6 and the bug tracker has an impressive collection of non-working (or with weird results) browsers about this. In 2.8.2: FAQ numbers hard-coded, other sections are not numbered In HEAD: auto-numbers for all sections. I am volunteer to remove the auto-numbering and put back the FAQ numbers like in 2.8.2. In fact, there was an idea behind not changing the FAQ numbers over time: to ease reference for FAQ numbers mentioned in the forums. Marc

3 2

[Phpmyadmin-devel] 2.8.2.1 tomorrow and Documentation.html changes
by Marc Delisle 01 Aug '06

01 Aug '06

Hi, I just merged in HEAD a patch by Isaac about the quick installation procedure, please comment. It was suggested by Isaac and Juergen that this improved installation procedure be merged for 2.8.2.1 so I'll wait for your comments about the contents and the opportunity to backport it to 2.8.2.1 for a release tomorrow. Marc

1 0

Re: [Phpmyadmin-devel] static contents of session
by Juergen Wind 01 Aug '06

01 Aug '06

Sebastian Mendel wrote: > why not? so you don't have to read the config file every time or do all > this checks again ... > so you always only have to load the session file and nothing more hmmm, sounds reasonable i have to think about it. > > (you won't put lang messages into the session, won't you?) > > hey, good idea ... > ;-) -- Juergen . _____________________________________________________________________ Der WEB.DE SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! http://smartsurfer.web.de/?mc=100071&distributionid=000000000071

1 0

Re: [Phpmyadmin-devel] static contents of session
by Juergen Wind 01 Aug '06

01 Aug '06

sorry for having posted twice without subject, getting used to this webmail by and by ;) Sebastian wrote: >you store this session in ram? you will say you do not use the default >php session handler 'file'? i ' m experimenting yet, what's best. that's why the question arose. >and? whats wrong with this? i just don't like it ;) (i hate wasting things, i 'm from the old days, when every byte counted , you know?) >what do you think exactly should not be stored in session and why? nothing, what is already in theme files, config.inc ... (you won't put lang messages into the session, won't you?) >> on a well configured system that should already be done by disk cache. >same for session file that's right some other opinions? -- Juergen . ___________________________________________________ ______________________________________________________________ Verschicken Sie romantische, coole und witzige Bilder per SMS! Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193

2 1

[Phpmyadmin-devel] <kein Betreff>
by Juergen Wind 01 Aug '06

01 Aug '06

Sebastian wrote: >you store this session in ram? you will say you do not use the default >php session handler 'file'? i ' m experimenting yet, what's best. that's why the question arose. >and? whats wrong with this? i just don't like it ;) (i hate wasting things, i 'm from the old days, when every byte counted , you know?) >what do you think exactly should not be stored in session and why? nothing, what is already in theme files, config.inc ... (you won't put lang messages into the session, won't you?) >> on a well configured system that should already be done by disk cache. >same for session file that's right some other opinions? -- Juergen . _____________________________________________________________________ Der WEB.DE SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! http://smartsurfer.web.de/?mc=100071&distributionid=000000000071

1 0

[Phpmyadmin-devel] <kein Betreff>
by Juergen Wind 01 Aug '06

01 Aug '06

>>> Do you have the same bug as me in MAINT_2_8_2 or QA_2_8: theme dropdown is broken after switching theme? Seeing twice the same theme name? This does not happen in HEAD but I cannot find what changed :) Marc <<< i can 't confirm the bug in QA_2_8 using w2k, FF, Opera, IE6 Juergen . ______________________________________________________________________ XXL-Speicher, PC-Virenschutz, Spartarife & mehr: Nur im WEB.DE Club! Jetzt gratis testen! http://freemail.web.de/home/landingpad/?mc=021130

1 0

Re: [Phpmyadmin-devel] static contents of session
by Juergen Wind 01 Aug '06

01 Aug '06

Sebastian wrote: >15 or 150k or even more should not a problem for an ISP providing >database servers to his customers but it's per user and i f.e. store those sessions in ram (only used while browser is open). >session file needs to be loaded every time - so why not move as most as >possible into this file and try not to load additional files like >config.inc.php, themes with every request. on a well configured system that should already be done by disk cache. Juergen --------------------- provider spam: ______________________________________________________________ Verschicken Sie romantische, coole und witzige Bilder per SMS! Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193

2 1

[Phpmyadmin-devel] a typo?
by Marc Delisle 01 Aug '06

01 Aug '06

Hi, in HEAD (or MAINT_2_8_2) libraries/Theme_Manager.class.php: if (array_key_exists($PMA_Theme, $this->themes)) { $this->themes[$PMA_Theme] = $this->themes[$PMA_Theme]; continue; } I don't see what's the goal of $this->themes[$PMA_Theme] = $this->themes[$PMA_Theme]; Marc

1 0