Developers

developers@phpmyadmin.net

5 participants
7032 discussions

RE: [Phpmyadmin-devel] Re: suggestion for Documentation after 2.3

by Beck, Mike

> > My idea was to introduce something like context help in phpMyAdmin. > > I'd also add those ? icons to the interface, but instead of > jumping to an > > anchor in the documentation I'd prefer to display a short > (maybe even > > localized) text in a JS window that tells the user more a > bout a specific interface > > element. > > I'd also offer this context help for popular error messages > i.e. if the > > MySQL server refuses the username / password. > > > I definitely support this idea of context help, using the /lang files. > well i would use javascript if possible as well, but do you mean just using an alert()? i'd rather open a new window each time the user clicks on the ? instead of sending all the strings with the page when he opens it so i can just display them as a message. because otherwise we'd really have to write _very_ short helptext or we would be sending a lot of helptext data which only few users will ever see. which is also why i wouldn't put them in the normal lang files - these get included on every page, so with every page we'd be putting every available shorthelp for all pages ....

22 years, 1 month

[Phpmyadmin-devel] Just a quick note

by Robin Johnson

Hi List, Just a quick note to say I won't be around until Sunday evening. I've got a business trip combination mini-vacation I need to make. I'm leaving for it shortly. All of the SQL parser should work fine. I know of exactly one case it doesn't format properly at the moment. INSERT/REPLACE ... SELECT That will require a bit of reworking, so i'm leaving it for 2.3.1. The only think left for the parser is writing a little bit of documentation, so that is easy to do for the -rc4 release. Enjoy your weekends, everybody. Bye! -- Robin Hugh Johnson E-Mail : robbat2(a)orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639

22 years, 1 month

[Phpmyadmin-devel] Re(3): Parser and PHP3

by Loïc

Just an addendum: "ob_flush()" is used in "sqlparser.lib.php3" with no test but it requires PHP >= 4.2.0. Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 1 month

[Phpmyadmin-devel] Re: Parser and PHP3

by Loïc

Hi List! >DEBUG_TIMING and the strange order of function >declaraction inside that block is related to my testing >harness for the SQL Parser OK. ["trigger_error" problem] >This is a problem actually. I don't want to terminate the >running of the page just because my SQL Parser can't >handle something in the query. I wanted to just print out >a message as to why my parser failed and continue >execution of the page contents. OK, the we may think about a way to emulate it under PHP3. ["print_r" problem] >I've changed that to just return the array for now, and I'll >print it out from my test harness instead. Fine. ["gzcompress" and "gzcompress" problem] >Just dumping the data base64 encoded got really big, so I >was just running it thru gzcompress before doing the >base64 encoding. OK but but should only do this if the "gzcompress" function is usable ie if (PMA_PHP_INT_VERSION >= 40001 && @function_exists('gzcompress')) { $encodedstr = nl2br(chunk_split(base64_encode(gzcompress($debugstr, 9)))); } else { $encodedstr = nl2br(chunk_split(base64_encode($debugstr, 9))); } >The linux kernel has a 'BUG()' call. For some of our >PMA code, a similar thing would actually be a >very useful function call. Very interesting idea :) Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 1 month

[Phpmyadmin-devel] Documentation

by Beck, Mike

i just deleted some docu that was still referring to my old parser, and moved the part about $cfg['PmaNoRelation_DisableWarning'] up where this variable is in config.inc. what i am still missing there is $cfg['PmaAbsoluteUri_DisableWarning'] Robin: how can users change the way your parser work (apart from the color)? specifically i'd like to make him not add newlines in front of the ON in a LEFT JOIN statement as i am usually working on rather big screens -- Mike

22 years, 1 month

[Phpmyadmin-devel] Translations question

by Robin Johnson

Hi List, Just a question about the translation system. What is the procedure wrt. sync_lang.sh Eg, I just updated the estonian-iso-8859-1.inc.php file from a Translations tracker item, should I run that script now? -- Robin Hugh Johnson E-Mail : robbat2(a)orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639

22 years, 1 month

[Phpmyadmin-devel] Re: Parser and PHP3

by Robin Johnson

On Thu, 25 Jul 2002, Lo�c wrote: > Your parser is a great job :) Thanks. I tried to test it out as throughly as possible. > Marc just submitted for me some changes in your > files. They are just related to coding standard > problem except a "foreach" I replaced by a while > for PHP3 compatibility. Ok. > At the beginning of "sqlparser.lib.php3" there > is a constant I renamed from "DEBUGTIMING" to > "DEBUG_TIMING" but I can't find where it is > defined. I you can change it... DEBUG_TIMING and the strange order of function declaraction inside that block is related to my testing harness for the SQL Parser. I'm going to keep the testing harness and those calls there for the moment, while the analyzer and tweaking the Parser is in progress, and probably remove it around 2.3.2 or 2.3.3 once everything has totally stabilized out. > Now let's talk about PHP3 compliance problem > in "sqlparser.lib.php3": > > 1. I suggest to replace lines 168-170 by > $pos = strpos(' ' . $sql, $quotetype, $oldpos) - 1; > if ($pos < 0) { > Could you check if it works this way? No. This does NOT work, as we already start at $oldpos instead of zero. Instead, this works: $pos = strpos(' ' . $sql, $quotetype, $oldpos + 1) - 1; if ($pos < 0) { Merged in CVS. > It seems this is the only strpos call where we should > do different things depending on "not found" and "found > at the begenning of the string". Am I right? Presently yes, but I never did complete all of the error detection functions. > 2. "trigger_error" is a PHP4 function. Couldn't we use > "PMA_mysqlDie()" instead? This is a problem actually. I don't want to terminate the running of the page just because my SQL Parser can't handle something in the query. I wanted to just print out a message as to why my parser failed and continue execution of the page contents. triggering an error with NOTICE level so that it just prints a message seemed suitable at the time, but I think we might want to convert to just having a global variable with an error message for the parser subsystem. Like I said, I never completed the query error detection at all. > 3. "print_r" is also a PHP4 function. I suggest to display > the array "manually". I was actually just dumping the contents of the analyzer data while I was working on it. In the end, that function won't be printing any data at all, but returning it instead. I've changed that to just return the array for now, and I'll print it out from my test harness instead. Merged in CVS. > 4. "gzcompress" and "gzcompress" can't be used with PHP3 and > must be tested before use in PHP4 ie > if (function_exists('gzcompress')).... I wanted a method in which I could get a specific data dump from a user containing all the information I needed to fix the SQL Parser. Just dumping the data base64 encoded got really big, so I was just running it thru gzcompress before doing the base64 encoding. Any ideas how I could still shrink the size for the bug posting ? Considering this, I actually had a major idea. The linux kernel has a 'BUG()' call. For some of our PMA code, a similar thing would actually be a very useful function call. Ideally it would print out a human readable message about the bug first of all, probably in the current language, then a gzip+base64 data chunk, with instructions to post the chunk on the Bug tracker (maybe even a 'post' link that partly auto-fills the form ?). The data chunk can contain whatever we will need in each case. In my existing use of it, I have a CVS $Id$ tag included for version tracing. -- Robin Hugh Johnson E-Mail : robbat2(a)orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639

22 years, 1 month

[Phpmyadmin-devel] Definition question

by Robin Johnson

Hi List, Nearly completed the merge of the parser, but I have some questions/notes. Notes: 1) The Analyzer is _NOT_ working Questions: 1) Do we need the analyzer right away to get table/column/alias data for the 2.3.0 release? If not, it can wait for 2.3.1 to replace the existing data extracters in the code. 2) For the display of the formatted queries, I need to put in a batch of stylesheet rules. Where is the best place to include my dynamically generated <style>...</style> data? The only requirement that I have for it is that the functions have all be defined and that $cfg data is available. Our login and error pages provide it, but nowhere in the main code can I find it. TODO: 1) Add CSS stuff in the correct place 2) Update PMA_format_sql() function to use the new formatter 3) See if everybody likes the output format ;-) 3) Update Documentation.html 4) Update function documentation Other Notes: Many thanks to my boss for letting me work on this for all of today (and still get paid for my job) It's 5PM now, so I'm heading home. I'll be there in 90 minutes or so, hopefully somebody has suggestions on the questions about the CSS stuff, so that I can have the SQL Parser active by tommorow morning. -- Robin Hugh Johnson E-Mail : robbat2(a)orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639

22 years, 1 month

[Phpmyadmin-devel] Fix against bug #586230

by Lo�c

Hi List! I've suggested a patch against bug #586230 (Table comments not parsed for HTML) in the bug tracker. Can anybody test it and commit it if it works? Thanks, Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 1 month

[Phpmyadmin-devel] Re: RE: [Phpmyadmin-devel] RE: [Phpmyadmin-devel] suggestion for Documentation after 2.3

by Robin Johnson

On Wed, 24 Jul 2002, [utf-7] Beck, Mike wrote: > +AD4- I would actually go against that idea. Have XML master files > +AD4- instead, as > +AD4- those can be kept in CVS a lot easier than a database. Each translator > +AD4- would just open up the XML file in his editor, and update it directly, > +AD4- then post a patch to the tracker. To keep track of when > +AD4- changes are made > +AD4- to the english documentation and not the translations, I > +AD4- suggest having > +AD4- small tag in them that is noted as out of date when the > +AD4- english is updated > +AD4- and the translation isn't. > > well as has been noticed, i am not at all firm with XML yet, so i possibly i > really thought too complicated there. Trust me, writing documents in XML directly is even easier than writing HTML by hand. Since you have control over your own elements and attributes, the language is usually a lot simpler. A list might be: <list type='dot'> <item>foo</item> <item>bar</item> <list> Paragraph: <para>I'm a little paragraph. (This is actually SGML compliant I think)</para> > possibly it is even ok when we just > add the new parts to the docu at the end of the file as it is done with the > language now and when the xml is converted to html, pdf or whatever there is > a possibility to order the stuff using some tags there? can this be done > with a XSLT? Yes, that is definetly doable, but not very common. As for keeping things straight and easier to edit, the document frequently gets re-arranged to keep all of the code in the order it will come out. It is a lot easier to edit when it is already in order. But it wouldn't be too hard in our language scripting for new sections being added to be placed at the end of the master files, and then we can run another script to re-order the XML file via XSLT. The only skill/knowledge that is needed for doing hard code XML is for creating your own XSLT and XML Schema documents. Once you have those, and I can create them when I have a bit of time, you can feed them to existing tools, and use WYSIWYG XML editors. -- Robin Hugh Johnson E-Mail : robbat2(a)orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639

22 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers