Developers

developers@phpmyadmin.net

5 participants
7032 discussions

Re: [Phpmyadmin-devel] dumps and php.ini

by Loïc

Hi Marc & all! >Then a dump transmitted to a file, and not asked to be >compressed, will be always compressed. >Should we work around this? Yep, at least I think so. Loïc

23 years, 1 month

[Phpmyadmin-devel] Re[2]: split_sql_file produces sometimes wrong pieces

by Loïc

Hi list! Marc wrote: > I don't understand. I cut&paste your example in the current > cvs version and I get correct results. Benjamin fixed this bug a fews days ago. Loïc

23 years, 1 month

[Phpmyadmin-devel] MD5 for set fields in tbl_change?

by Steve Alberty

Hi, we have a problem in tbl_change in line 251-252. Set fields have not the destination name, they have a md5 of the field name and in line 251 a hidden field is defined with always an incorrect value ($set, but set is an array - line 242) is this an old debug code ? i think we must remove the hidden field, but i'm not sure .... Regards, -- Steve

23 years, 1 month

[Phpmyadmin-devel] split_sql_file produces sometimes wrong pieces

by Steve Alberty

Hi, db_readdump.php failes on the follow tabledump: --snip-- CREATE TABLE Global ( ID int(10) unsigned NOT NULL auto_increment, TSTAMP timestamp(14) NOT NULL, Keyname varchar(255) NOT NULL default '', Value mediumtext NOT NULL, Number int(10) unsigned NOT NULL default '0', PRIMARY KEY (ID), KEY Keyname (Keyname) ) TYPE=MyISAM COMMENT='global memory'; INSERT INTO Global VALUES (209,20010731131330,'Matrix','(\'dadada\')',1); INSERT INTO Global VALUES (210,20010731131330,'Matrix','dadada',2); --snap-- mysql_die results: Fehler in der Syntax bei '; INSERT INTO Global VALUES (210,20010731131330,'Matrix','dadad' in Zeile 1. ^ here is the problem. if you remove the parenthesis in the second row, readdump has no problems. The problem in split_sql_file is row 1480 which try to detect the last ')' char. also you can see another problem here. db_readdump.php3 ignore the $lang variable ... Regards, -- Steve

23 years, 1 month

[Phpmyadmin-devel] Re: tests on cvs version

by Loïc

Hi Benjamin & all! Once a day, Benjamin wrote: >- one stripSlashes() that should not be done when executing SQL > queries an a database. The query displayed in the textarea after > execution has slashes stripped off, and that should not be done. Should be fixed in the CVS. >- tbl_properties.php3: there is no link to "empty" the table. this > feature is only available in db_details.php3. why not putting it in > tbl_properties.php3? Added after "Browse - Select - Insert" links and merged into the CVS. Cheers, Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

23 years, 1 month

Re: [Phpmyadmin-devel] tests on cvs version

by Loïc

Hi All! Here it is: I'm back and up to date with the new code. So I may start to work on bugs now (just after I've finished to update 'users_details.php3'). BTW I've done some little updates on the CVS today. Note that I've removed some annoying ^M EOL from 4 files. Greets, Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

23 years, 1 month

[Phpmyadmin-devel] Changes on SET & ENUM fields failed

by Steve Alberty

Hi, three big bugs: - if you change a row with a 'set' field, phpMyAdmin saves : 'Array$' instead of the field values - on 'enum' fields tbl_change.php3 lose the enum state - the binary field protection binary varchars is not working if the $cfgProtectBlob=true. In RC3 it works fine. Regards, -- Steve

23 years, 1 month

[Phpmyadmin-devel] removing remarks is useless

by Benjamin Gandon

I forgot one more thing: - lib.inc.php3: the function remove_remarks() is bugged because if a string contains a '#' in a string, it is considered as a comment. As stated in bug #444279. I already said that comments need not being stripped off queries. Mysql works just fine if you give it all the comments. No need removing them (as is was in my 2.1.0.1 version). I made tests and removing the call to remove_remarks() does not affect queries that have comments *at all*. The call to remove_remarks() is *really* useless in db_readdump.php3. PS: sorry for double posting one of my previous messages.

23 years, 1 month

RE: [Phpmyadmin-devel] pretty code, buggy code?

by Benjamin Gandon

> No, because a single newline after the closing tag is > silently ignored. I > propose the following: > > <textarea name="fields[<?php echo urlencode($field); ?>]" > rows="<?php echo $cfgTextareaRows; ?>" > cols="<?php echo $cfgTextareaCols; ?>" > ><?php if > (!empty($special_chars)) echo $special_chars . "\n"; ?> > </textarea> Ok, but I didn't see anywhere in php documentation that trailing newlines are silently ignored. We should also be careful that problems may arise with editors using other end of lines than unix ones (dos' \r\n and mac's \r). If somebody editing the code with an editor that doesn't preserve end of lines may break it, the code becomes "text editor dependant" which is not exactly our goal... :) Benjamin

23 years, 1 month

[Phpmyadmin-devel] (no subject)

by recep

23 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers