- Developers - lists.phpmyadmin.net

RE: [Phpmyadmin-devel] pretty code, buggy code?
by Benjamin Gandon 02 Aug '01

02 Aug '01

> No, because a single newline after the closing tag is > silently ignored. I > propose the following: > > <textarea name="fields[<?php echo urlencode($field); ?>]" > rows="<?php echo $cfgTextareaRows; ?>" > cols="<?php echo $cfgTextareaCols; ?>" > ><?php if > (!empty($special_chars)) echo $special_chars . "\n"; ?> > </textarea> Ok, but I didn't see anywhere in php documentation that trailing newlines are silently ignored. We should also be careful that problems may arise with editors using other end of lines than unix ones (dos' \r\n and mac's \r). If somebody editing the code with an editor that doesn't preserve end of lines may break it, the code becomes "text editor dependant" which is not exactly our goal... :) Benjamin

6 12

[Phpmyadmin-devel] (no subject)
by recep 01 Aug '01

01 Aug '01

1 0

[Phpmyadmin-devel] cvs is open!
by Marc Delisle 31 Jul '01

31 Jul '01

Hi, Loic's version has been merged into cvs. Previous version has been tagged 'rc3' as suggested by Olivier. Have fun! Marc

5 9

RE: [Phpmyadmin-devel] pretty code, buggy code?
by Benjamin Gandon 31 Jul '01

31 Jul '01

> Correct code will not be so pretty: > > <textarea name="fields[<?php echo urlencode($field); ?>]" > rows="<?php echo $cfgTextareaRows; ?>" > cols="<?php echo $cfgTextareaCols; ?>"><?php if > (!empty($special_chars)) echo $special_chars . "\n"; ?> > </textarea> I think your code still inserts a line feed at the end of the textarea. Correct code would be even less pretty: <textarea name="fields[<?php echo urlencode($field); ?>]" rows="<?php echo $cfgTextareaRows; ?>" cols="<?php echo $cfgTextareaCols; ?>"><?php if (!empty($special_chars)) echo $special_chars . "\n"; ?></textarea>

3 2

[Phpmyadmin-devel] pretty code, buggy code?
by Marc Delisle 31 Jul '01

31 Jul '01

Hi, sometimes we want to beautify the code by inserting line feeds, like this: <textarea name="fields[<?php echo urlencode($field); ?>]" rows="<?php echo $cfgTextareaRows; ?>" cols="<?php echo $cfgTextareaCols; ?>"> <?php if (!empty($special_chars)) echo $special_chars . "\n"; ?> </textarea> The problem here is the line feed inserted before the last <?php, it inserts unwanted characters into the textarea. Correct code will not be so pretty: <textarea name="fields[<?php echo urlencode($field); ?>]" rows="<?php echo $cfgTextareaRows; ?>" cols="<?php echo $cfgTextareaCols; ?>"><?php if (!empty($special_chars)) echo $special_chars . "\n"; ?> </textarea> Marc

1 0

[Phpmyadmin-devel] Loic 7 available
by Marc Delisle 30 Jul '01

30 Jul '01

Hi, This one solves compatibility problems with PHP3. Also there was a bug that I introduced in lib.inc.php3, now there are comments in it about the required order of the sections, for compatibility with PHP3 and 4. http://phpmyadmin.sourceforge.net/phpMyAdmin-loic7.tar.gz P.S.: can we put this one in cvs? :) Marc

4 3

[Phpmyadmin-devel] reproduce this bug?
by Marc Delisle 28 Jul '01

28 Jul '01

Hi, someone can reproduce this? http://sourceforge.net/tracker/index.php?func=detail&aid=445440&group_id=23… Marc

1 0

[Phpmyadmin-devel] Security Code added
by peter revill 27 Jul '01

27 Jul '01

Ok, ive put my login script in the patches, under the name nolimits. Check it out, tell me if it works for you, scrutinize it :P and enjoy! Cheers guys Nervlord aka nolimits aka peter __________________________________________________________________ Get your free Australian email account at http://www.start.com.au

1 0

[Phpmyadmin-devel] ob question
by Marc Delisle 27 Jul '01

27 Jul '01

We got a question about a problem with ob, in the forum: https://sourceforge.net/forum/message.php?msg_id=200293 Marc

1 0

Re: [Phpmyadmin-devel] Loic 6 available, possible cvs merge/unfreeze?
by Alain 27 Jul '01

27 Jul '01

Hello Marc, >>Please test it, I would like to replace our cvs version with this one, then unfreeze cvs. Care to share the Url ? Alain. _______________________________________________________

2 1