[Phpmyadmin-devel] cvs is open!
Hi, Loic's version has been merged into cvs. Previous version has been tagged 'rc3' as suggested by Olivier. Have fun! Marc
Oh, back from a couple of days of vacation ;o)
Loic's version has been merged into cvs. Previous version has been tagged 'rc3' as suggested by Olivier.
So it seems - but I've been looking a bit around the code and one thing really annoys me about the changes - that it seems that there's no consistency in the use of outputting HTML-code - and there has been a lot of changes in that I can see... A lot of places the source code has been changed from echoing HTML - to including embedded HTML with echoing of a single PHP-variable (jumping in and out of PHP code execution). So I really think a code-cleanup in this matter is required - we eighter use: <?php echo "some_html_here_and_a_variable_here"; ?> or: ?> some_html_here_<?php echo "outputting_a_PHP_variable_here"; ?> <?php I hope you understand what I'm trying to illustrate - but in case you don't - try having a look at: <http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/phpmyadmin/phpMyAdmin/tbl_change.php3.diff?r1=1.18&r2=1.19> And specially the marked changes from Line 77 (in old version) and forward. My suggestion is to always use of echoing all output via the PHP echo function-call instead of using the jumping in and out of PHP method making it a lot easier and quick to alter PHP code in the future. -- Kind regards Geert Lund
Hi Marc,
-----Original Message----- Loic's version has been merged into cvs. Previous version has been tagged 'rc3' as suggested by Olivier.
the new verion is very nice, but a little bug in db_details.php3 prevent to link to tbl_properties.php3. The link over the Table Size is wrong. A '?' is missing. Regards, Steve
Ok I am fixing this right now. Didn't even try this link before! Marc Steve Alberty a écrit :
Hi Marc,
-----Original Message----- Loic's version has been merged into cvs. Previous version has been tagged 'rc3' as suggested by Olivier.
the new verion is very nice,
but a little bug in db_details.php3 prevent to link to tbl_properties.php3.
The link over the Table Size is wrong. A '?' is missing.
Regards,
Steve
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi all, Tow points : 1) I add a new version of bookmark support. This new version should work under advanced auth. Please, note that : - there is a new field (user) in the table. - the 'MySQL standard user' must have access (Select, Insert and Delete) under the Bookmark Db. If you could made somes tests, it would be nice. 2) In the documentation (Documentation.html), i see that : phpMyAdmin can compress (GZip format -RFC 1952- or Bzip2) dumps and CSV exports if you use PHP4 >= 4.0.4 with Zlib support (--with-zlib) ***and/or*** Bzip2 support (--with-bz2). For me, it's Zlib support **OR** BZip2 support, but never both at the same moment. I think it's not possible. It is just a detail. Regards, Armel.
On Tue, 31 Jul 2001, Armel FAUVEAU wrote:
2) In the documentation (Documentation.html), i see that :
phpMyAdmin can compress (GZip format -RFC 1952- or Bzip2) dumps and CSV exports if you use PHP4 >= 4.0.4 with Zlib support (--with-zlib) ***and/or*** Bzip2 support (--with-bz2).
For me, it's Zlib support **OR** BZip2 support, but never both at the same moment. I think it's not possible.
Yes, zlib (gz*()) and bzip2 (bz*()) support can both be in PHP at the same time. -- Ignacio Vazquez-Abrams <ignacio@openservices.net>
Armel FAUVEAU a écrit :
Hi all,
Tow points :
1) I add a new version of bookmark support. This new version should work under advanced auth. Please, note that :
- there is a new field (user) in the table. - the 'MySQL standard user' must have access (Select, Insert and Delete) under the Bookmark Db.
If you could made somes tests, it would be nice.
Armel, I tested it. Is it intentional that dbase, user, label and query are stored with backquotes surrounding them? Marc
On Tue, 31 Jul 2001, Armel FAUVEAU wrote:
Hello Ignacio,
Yes, zlib (gz*()) and bzip2 (bz*()) support can both be in PHP at the same time.
Ok. It does not work on my servers under Linux and FreeBSD. You are under Windows or Unix ?
Yours,
Armel.
Weeelll... To be honest with you I had never compiled zlib+bzip2 together, so I fired up my fast machine to build it...
From phpinfo():
System Linux rhlinux71.ignacio.lan 2.4.3-13iva #1 Thu Jul 26 21:13:35 EDT 2001 i686 unknown Build Date Jul 31 2001 ... zlib ZLib Support enabled 'zlib:' fopen wrapper enabled Compiled Version 1.1.3 Linked Version 1.1.3 ... bzip2 BZip2 support enabled BZip2 Version 1.0.1, 23-June-2000 'Nuff said ;) Windows comes precompiled, so there should be no problem there. -- Ignacio Vazquez-Abrams <ignacio@openservices.net>
Your configure lines looked a little strange, so I looked in the configure help. There is no '--with-gzip'. Do you perhaps want '--with-zlib'?
Of course. Pffft, I am stupid :( And there is no message, we can even make : './configure' '--with-apxs=/usr/local/apache/bin/apxs' '--with-mysql' '--with-gd' '--with-ftp' '--enable-versioning' '--enable-track-vars' '--with-blablah' '--with-bz2' No problem with the '--with-blahblah' ... Thanks Ignacio ! You wine a beer if you come on Paris@France :) Armel.
participants (5)
-
Armel FAUVEAU -
Geert Lund - SilverSoft Productions -
Ignacio Vazquez-Abrams -
Marc Delisle -
Steve Alberty