July 2010 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Table statistics for a newly created table?
by Ninad Pundalik 14 Jul '10

14 Jul '10

Hi, For the last few hours, I've been working on appending a newly created table's details to the list of tables we see on db_structure.php. I have been able to generate most of the HTML necessary for this in tbl_create.php, but I have not understood how the table size and overhead are calculated. Even though it's a new table and has zero rows, it would occupy some space, and it should not have any overhead. I tried understanding the code in db_structure.php that generates the HTML, but I'm slightly lost. Pointers anyone? I've pushed my changes in commit 10a9e69, so everyone can see the stage I am at. At the moment, I'm filling in a dummy value for the size column, and leaving overhead as '-'. -- Ninad S. Pundalik

2 2

[Phpmyadmin-devel] (no subject)
by Ninad Pundalik 13 Jul '10

13 Jul '10

Hi, For the last few hours, I've been working on appending a newly created table's details to the list of tables we see on db_structure.php. I have been able to generate most of the HTML necessary for this in tbl_create.php, but I have not understood how the table size and overhead are calculated. Even though it's a new table and has zero rows, it would occupy some space, and it should not have any overhead. I tried understanding the code in db_structure.php that generates the HTML, but I'm slightly lost. Pointers anyone? I've pushed my changes in commit 10a9e69, so everyone can see the stage I am at. At the moment, I'm filling in a dummy value for the size column, and leaving overhead as '-'. -- Ninad S. Pundalik

1 0

[Phpmyadmin-devel] about export and CSV
by Marc Delisle 12 Jul '10

12 Jul '10

Lori, your wrote on your blog ---- It is confusing why the default column termination symbol for CSV is a semi-colon when a comma is expected ("comma-separated values"). ---- I agree it's confusing but the semi-colon is there by default for a reason: this is the character that Excel expects and we can't deny that most users will use Excel to read back this file. -- Marc Delisle http://infomarc.info

3 3

[Phpmyadmin-devel] [ Exporting Relations Schema] Project
by ADnan 12 Jul '10

12 Jul '10

Hi, First of all, thanks for accepting my proposal. I am very delighted that I got a chance to take part in Great Google Summer of Code Program and phpMyAdmin was my favorite choice. I posted my proposal to my blog. <http://www.imblog.info/export-relations-schema-project-google-summer-of-cod…> I expect to get the feedback about my proposal from the Community :) Thanks! I will write weekly status reports at my blog and will regularly tweet my progress. My twitter: @hiddenpearls Regards Muhammad Adnan -- Failure takes you higher than success ..!

6 33

[Phpmyadmin-devel] behavior when no userconfig is possible
by Marc Delisle 10 Jul '10

10 Jul '10

Piotr, let's say pma_userconfig is undefined; you are still offering a Save button. You wrote in Documentation.html that settings will be saved in the browser's local storage or until the end of session but some users will be disappointed to see that these have not been saved permanently (some don't read the doc :) ) Maybe the "Save" button could be changed in this case to indicate the non-permanent status of this saving operation? Also, when I save I get: ---------- Could not save configuration #1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(`username`, `config_data`) VALUES ('root', 'a:1:{s:' at line 1 ---------- and ---------- Notice in ./libraries/user_preferences.lib.php#69 Undefined index: userconfig Backtrace ./prefs_forms.php#58: PMA_save_userprefs(array) ---------- -- Marc Delisle http://infomarc.info

2 3

[Phpmyadmin-devel] Martynas tree - Errorhandling and integration
by Herman van Rink 09 Jul '10

09 Jul '10

Martynas, I've seen that you implemented some error messages, especially concerning GD. However what struck me was the unconditional nature of the error messages. I see them on all pages where a chart is drawn... I guess you need to actually check for errors in PMA_handle_chart_err() The "Unknown data format." message could be more informative. It now shows up instead of a chart when the number of columns is not 2 or 3. Although I expect the number of supported data format's to increase, it is currently not clear what is used. One other thing I'm missing is a way back after choosing 'Display chart'. Do you plan to integrate this further with the query result data table? -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions

1 0

[Phpmyadmin-devel] Export tab (lirilee fork)
by Piotr Przybylski 09 Jul '10

09 Jul '10

Hi, Because Export forms are more or less finished, I wanted to share some my thoughts on it. It takes up too much vertical space. How about displaying it in two columns: Table(s) and Output in one, Format and Format-Specific Options in the other? I would like to always have Table(s) and Output shown, but form height right now annoys me more :) Is there an option in the $cfg array to have "Custom" checked by default? I would like to see something like that: $cfg['Export']['form_type'] = 'quick'; // custom, custom-no-form (like custom but Export Method is never displayed) -- Piotr Przybylski

2 2

[Phpmyadmin-devel] Broken po files in Ninad's tree
by Michal Čihař 08 Jul '10

08 Jul '10

Hi it looks like Ninad's tree has broken locales, the problem is in not cleaned up merge[0]. The root cause is that po files are quite often changing content and doing changes in both gsoc branch and master will lead to conflicts. So please follow instructions on wiki [1] and do not update po files in your private branches, this will be done once the code is merged (anyway the translations won't be sent out to translators or to translation server, so nobody will do the translation work anyway). [0]:http://repo.or.cz/w/phpmyadmin/ninadsp.git/commit/47142291a1983f2a541a947b50a6f1dba29f48d0 [1]:http://wiki.phpmyadmin.net/pma/Devel:Gettext_for_developers#Updating_.po… -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 5

[Phpmyadmin-devel] Ninad's tree and adding a user
by Marc Delisle 08 Jul '10

08 Jul '10

Ninad, using your tree with latest commit 4f1c34 (and I saw this behavior previously too), I have two problems. 1. Let's say I click on "B" in the user overview. Then I add a user "b6". I don't see it in the list of "B" users. Clicking on the Privileges tab shows all the users, including "b6" because on this server there are few users. Then clicking again on "B", user "b6" is not visible. 2. On another server having about 60 MySQL users, when clicking on any letter in the user overview, I see just the short "Loading" message but no list of users appears. I checked in Firebug with the Network tracing and I see in HTML the correct list of users for this letter, however it does not reach the displayed page. -- Marc Delisle http://infomarc.info

2 3

[Phpmyadmin-devel] Martynas tree - codingstandards
by Herman van Rink 08 Jul '10

08 Jul '10

Martynas, Unfortunately the latest git version is broken for me. At least in libraries/chart.lib.php on line 5 you use a lower case filename which does not match in case-sensitive environments. Some other points: * Please use curly braces even in situations where they are technically optional. Not: if (is_null($options)) return; but if (is_null($options)) { return; } * Please make sure you properly escape variables you print to the user. $sql_query in tbl_chart.php should probably have htmlspecialchars() In general ... distrust any data you get from the outside. Most code looks OK though, nice going. -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions

3 5