- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3814
by michal＠cihar.com 10 Jul '13

10 Jul '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3814/changes> Changes: [marc] There might be other reasons to use the SQL query box on an empty database ------------------------------------------ Started by GitHub push by lem9 Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@5b27a891 Using strategy: Default Last Built Revision: Revision 3151966439e3f41bfda78c43fdc4ac52a29e71e8 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision bbabfa80ca0110e9b00179f51b2e631aa89d807d (origin/master) Checking out Revision bbabfa80ca0110e9b00179f51b2e631aa89d807d (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson6865700869024560829.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] PHP Fatal error: Call to undefined function imagecreatetruecolor() in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/gis/PMA_…> on line 225 [exec] Result: 255 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 30 exact clones with 560 duplicated lines in 36 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-143 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2789 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:341-347 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:28-41 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:30-43 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:597-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:615-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-955 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:924-962 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-961 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:796-840 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.39% duplicated lines out of 145031 total lines of code. [exec] [exec] Time: 7 seconds, Memory: 126.75Mb [exec] Result: 1 phpcs: [exec] Time: 56 seconds, Memory: 58.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 414 [exec] [exec] Lines of Code (LOC): 145031 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 45215 [exec] Non-Comment Lines of Code (NCLOC): 99816 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 204 [exec] Abstract: 26 (12.75%) [exec] Concrete: 178 (87.25%) [exec] Average Class Length (NCLOC): 223 [exec] Methods: 1754 [exec] Scope: [exec] Non-Static: 1471 (83.87%) [exec] Static: 283 (16.13%) [exec] Visibility: [exec] Public: 1360 (77.54%) [exec] Non-Public: 394 (22.46%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.22 [exec] [exec] Anonymous Functions: 1 [exec] Functions: 646 [exec] [exec] Constants: 166 [exec] Global constants: 106 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 1 minute 13 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2835 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3813 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 51 warnings. [DRY] Computing warning deltas based on reference build #3813 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 625 files to scan for tasks [TASKS] Found 197 open tasks. [TASKS] Computing warning deltas based on reference build #3813 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3813 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 1

[Phpmyadmin-devel] Error reports
by Mohamed Ashraf 10 Jul '13

10 Jul '13

For the server side component of the error reporting system. What are the things you want to do with the reports. like for example comments, or storing status of the reports. what other things do think you would want to do on the error reporting server. What I am thinking is commenting, changing status, searching and of course viewing all the details of the report as well as related reports. Do you want the ability to delete error reports or just mark them as resolved. and while we are on the matter what are the statuses that should exist for the error reports. I am thinking at least new and resolved but I cant think of anything else;

3 13

[Phpmyadmin-devel] (no subject)
by Supun Nakandala 09 Jul '13

09 Jul '13

Hi, I am refactoring the sql.php script. In line 235 there is a condition for GLOBALS['grid_edit']==true. According to what I found this will be set only when the field has "truncated" or "transformed" css classes. I was trying to find some test cases where these classes are added to the fields, but I was not successful. I would appreciate if someone can help me to find some test cases where these classes will be added. Thank you

2 1

Re: [Phpmyadmin-devel] test case for global var grid_edit in sql.php
by Dieter Adriaenssens 09 Jul '13

09 Jul '13

2013/7/9 Supun Nakandala <supun.nakandala(a)gmail.com>: > Hi, > I am refactoring the sql.php script. In line 235 there is a condition for > GLOBALS['grid_edit']==true. According to what I found this will be set only > when the field has "truncated" or "transformed" css classes. I was trying to > find some test cases where these classes are added to the fields, but I was > not successful. I would appreciate if someone can help me to find some test > cases where these classes will be added. > > Thank you Hi Supun, Please use a subject when sending a mail, this will make it easier for other people to know what your message will be about and to follow the thread later on. -- Kind regards, Dieter Adriaenssens

1 0

Re: [Phpmyadmin-devel] SQLValidator
by Dieter Adriaenssens 08 Jul '13

08 Jul '13

2013/7/3 Ayush Chaudhary <ayushchd(a)gmail.com>: > Hi, > > Is there a reason why validation.lib.php is not a class with public static > method? Is it okay to convert it to a class with all methods' access > specifier as public static? Did you mean the PMA_SQLValidator class in libraries/sqlvalidator.class.php? I didn't find a validation.lib.php, or something similar, in the PMA codebase, that contains a class. (libraries/config/validate.lib.php doesn't contain a class) Assuming you mean PMA_SQLValidator, this is not a static class, ie. it has to be instanciated (= turned into an object), so it can't have static methods. [1] To use (or test) this class, you have to create an instance and call the methods from that instance, fe. $validator = new PMA_SQLValidator(); $validator->start(); (see libraries/sqlvalidator.lib.php for an example on how to instanciate and use the PMA_SQLValidator class) BTW : Testing a class instance can sometimes be tricky, especially if it communicates with, or uses another class. If this is the case, you will have to use Mock objects [0] and Stubs to simulate the expected behaviour of the other class. I hope this helps. [0] http://phpunit.de/manual/3.0/en/mock-objects.html [1] explanation of instances and static members. It's explained for Java so the syntax doesn't match 100% with PHP, but the concept is analogous : http://docs.oracle.com/javase/tutorial/java/javaOO/classvars.html Kind regards, Dieter > -- > Ayush Chaudhary > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel > -- Kind regards, Dieter Adriaenssens

5 7

Re: [Phpmyadmin-devel] SQLValidator
by Dieter Adriaenssens 08 Jul '13

08 Jul '13

2013/7/8 point dynamic <pointdynamicsix(a)gmail.com>: > hi can i have 2 actions on 1 form in php? Please use a new thread for a new topic.

1 0

[Phpmyadmin-devel] Error reporting server configuration
by Mohamed Ashraf 07 Jul '13

07 Jul '13

As it turns out some of the asset urls need to be hardcoded. So I was wondering what will the server configuration be. like what is the domain name. will it be hosted on the root path or will it be inside a sub path like example.com vs example.com/error-reporting.

2 2

[Phpmyadmin-devel] Unexpected javascript execution behaviour
by Supun Nakandala 06 Jul '13

06 Jul '13

Hi Devs, I am experiencing an unexpected behavior with respect to the following two cases. 1. Deleting a row from browse page. 2. Deleting a row after searching In the first case the request goes through the sql.js ajax handler. But in the second case the request doesn't go through it and the request is not an ajax request. But in both cases the tag is same ("<a class='delete_row ajax") and in both cases sql.js file is added to the responses which are displaying the results. I tried to find what is going wrong here for sometime now and I couldn't find it. I would appreciate if you can provide me some help to figure this problem. Thank You

2 2

[Phpmyadmin-devel] Renaming proxy credentials variables
by Mohamed Ashraf 05 Jul '13

05 Jul '13

Currently all variables that store proxy credentials have the prefix 'VersionCheck' assuming because this was the only part of phpmyadmin that uses these variables. However I also require those variables in my error reporting code and I did not want to use the same variable names since it is a misnomer at that point. I renamed the variables and removed all the VersionCheck prefixes so they became ProxyUrl, ProxyUser and ProxyPass. I made the changes in the version_check.php code and in the docs. I just wanted to inform you of this change since this may affect others once the error reporting system is merged with master

2 3

[Phpmyadmin-devel] (no subject)
by Supun Nakandala 04 Jul '13

04 Jul '13

Hi Marc, I identified seven situations where the method PMA_sendResponseForNoResultsReturned runs. 1-> When browsing an empty table 2-> When executing a query on a non empty table which returns zero results 3-> When executing a query on an empty table 4-> When executing an INSERT, UPDATE, DELETE query from the SQL tab 5-> When deleting a row from BROWSE tab 6-> When searching using the SEARCH tab which returns zero results 7-> When changing the structure of the table except change operation In the first case the $goto variable is not initialized. But in the second, third and fourth cases it is initialized to tbl_sql.php. In the third, fourth and fifth cases the $goto variable is initialized with sql.php itself with certain other url parameters. In the 7 th case $goto variable is set to $tbl_structure.php But I identified all these cases send Ajax responses where $goto variable or sending header location were never used. I would like to know whether my test scenarios are comprehensive if so shall I remove the redundant code segments.

2 1