- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Broken po files in Ninad's tree
by Michal Čihař 08 Jul '10

08 Jul '10

Hi it looks like Ninad's tree has broken locales, the problem is in not cleaned up merge[0]. The root cause is that po files are quite often changing content and doing changes in both gsoc branch and master will lead to conflicts. So please follow instructions on wiki [1] and do not update po files in your private branches, this will be done once the code is merged (anyway the translations won't be sent out to translators or to translation server, so nobody will do the translation work anyway). [0]:http://repo.or.cz/w/phpmyadmin/ninadsp.git/commit/47142291a1983f2a541a947b50a6f1dba29f48d0 [1]:http://wiki.phpmyadmin.net/pma/Devel:Gettext_for_developers#Updating_.po… -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 5

[Phpmyadmin-devel] Ninad's tree and adding a user
by Marc Delisle 08 Jul '10

08 Jul '10

Ninad, using your tree with latest commit 4f1c34 (and I saw this behavior previously too), I have two problems. 1. Let's say I click on "B" in the user overview. Then I add a user "b6". I don't see it in the list of "B" users. Clicking on the Privileges tab shows all the users, including "b6" because on this server there are few users. Then clicking again on "B", user "b6" is not visible. 2. On another server having about 60 MySQL users, when clicking on any letter in the user overview, I see just the short "Loading" message but no list of users appears. I checked in Firebug with the Network tracing and I see in HTML the correct list of users for this letter, however it does not reach the displayed page. -- Marc Delisle http://infomarc.info

2 3

[Phpmyadmin-devel] Martynas tree - codingstandards
by Herman van Rink 08 Jul '10

08 Jul '10

Martynas, Unfortunately the latest git version is broken for me. At least in libraries/chart.lib.php on line 5 you use a lower case filename which does not match in case-sensitive environments. Some other points: * Please use curly braces even in situations where they are technically optional. Not: if (is_null($options)) return; but if (is_null($options)) { return; } * Please make sure you properly escape variables you print to the user. $sql_query in tbl_chart.php should probably have htmlspecialchars() In general ... distrust any data you get from the outside. Most code looks OK though, nice going. -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions

3 5

Re: [Phpmyadmin-devel] [Phpmyadmin-git] [SCM] phpMyAdmin branch, QA_3_3, updated. RELEASE_3_3_4-16-g9903c5f
by Michal Čihař 07 Jul '10

07 Jul '10

Hi Dne Tue, 6 Jul 2010 20:58:22 +0000 "Marc Delisle" <lem9(a)users.sourceforge.net> napsal(a): > diff --git a/ChangeLog b/ChangeLog > index 7c019b0..9da63ad 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -13,6 +13,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA > - bug [replication] Do not offer information_schema in the list of databases > - bug [js] Avoid loading twice a js file > - bug #3024344 [setup] Setup forces numeric MemoryLimit > +- bug #3025975 [auth] Odd LoginCookieValidity default value > > 3.3.4.0 (2010-06-28) > - bug #2996161 [import] properly escape import value > diff --git a/libraries/config.default.php b/libraries/config.default.php > index de03aa2..eea22aa 100644 > --- a/libraries/config.default.php > +++ b/libraries/config.default.php > @@ -580,11 +580,11 @@ $cfg['Confirm'] = true; > $cfg['LoginCookieRecall'] = true; > > /** > - * validity of cookie login (in seconds) > + * validity of cookie login (in seconds; 1800 seconds is 30 minutes) > * > * @global integer $cfg['LoginCookieValidity'] > */ > -$cfg['LoginCookieValidity'] = 1440; > +$cfg['LoginCookieValidity'] = 1800; The "odd" value is there to match default settings for session.gc_maxlifetime, which does also limit cookie validity. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 1

[Phpmyadmin-devel] Browser compatibility issue
by ANKIT GUPTA 07 Jul '10

07 Jul '10

Hi all, i was wondering if there is a tool available to test the compatibility of javascript and CSS on different browsers. as history tab is using javascript/Jquery i want to check the result on other browses. In case if no such tool is present, on which all browsers ( with versions) should i use to test my project. thanks and regards, Ankit

1 0

[Phpmyadmin-devel] Piotr's tree and top menus
by Marc Delisle 06 Jul '10

06 Jul '10

Hi Piotr, When entering "More settings" page, we no longer see the "server" series of top menus and I'm wondering if they should stay there, over the settings tabs. Maybe there should be a "User settings" top menu too? I agree that this "server" series of menus need work to be regrouped in less choices, but I feel that now, a user could feel a bit lost when they disappear. -- Marc Delisle http://infomarc.info

2 5

Re: [Phpmyadmin-devel] Martynas tree - codingstandards
by Herman van Rink 06 Jul '10

06 Jul '10

On 06-07-10 15:32, Martynas Mickevičius wrote: > Hey, I am back on the track. > > I have fixed the case problem a while ago but it did not solve the > problem completely. > > I was wondering maybe it would be possible to enable all error > reporting on the http://demo.phpmyadmin.net/gsoc-blinky so that I can > find where the error is. The idea seems ok, and it should be possible. Lets discuss it here... It would be something for Michal to enable. > If this is not possible then an ability for me to tell the demo server > to fetch the latest revision from repository would be nice. This would > decrease debugging time substantially. I don't think that will happen very quickly. -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions

1 0

[Phpmyadmin-devel] Ninad's tree and entering SQL queries
by Marc Delisle 03 Jul '10

03 Jul '10

Hi Ninad, before your changes, when I enter a query and click Go I get a top section "Showing rows..." with stats about the range of rows displayed, total number of rows and links for Profiling, inline editing, explain, etc. With your changes, there is the benefit that the query area is still visible for me to make changes, and I can navigate in an AJAX way; however I regret to have lost the stats and other links mentionned. It's true that some links are probably no longer needed but some still are, IMO. The pretty printing of queries is also not visible. What's your plan about this? -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] Ninad's tree and privileges editing
by Marc Delisle 02 Jul '10

02 Jul '10

Hi Ninad, Let's say a user has a global SELECT privilege. When the new AJAX Edit privileges panel appears for this user, this global privilege does not show up. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] about window.frame_navigation
by Marc Delisle 02 Jul '10

02 Jul '10

Hi, someone is reporting that on his Windows 7 x64 system with Chrome 5.x, this line if (window.frame_navigation.document.getElementById(db) == null) gives an error Uncaught TypeError: Cannot call method 'getElementById' of undefined but this works: if (window.frames[0].document.getElementById(db) == null) Does someone have an idea why making a reference to the frame name would not work? Broken browser? -- Marc Delisle http://infomarc.info

3 4