- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Theme names and advertising
by Marc Delisle 17 May '07

17 May '07

Hi, I know that we have some (old) themes named WinXP-something, but here is a case I want to discuss about. We got a proposition for 2 themes and their company name is part of the theme name. I don't mind giving proper credits on the themes downloads page, including company name, but using the company name as theme name seems excessive to me. Marc

5 15

[Phpmyadmin-devel] PMA_blowfish_encrypt() and full_str_pad() instead of str_pad()?
by Sebastian Mendel 15 May '07

15 May '07

Hi, what is the difference between PHP:str_pad() and phpMyAdmin:full_str_pad()? used in PMA_blowfish_encrypt() -- Sebastian Mendel www.sebastianmendel.de

2 3

[Phpmyadmin-devel] subversion question
by Marc Delisle 09 May '07

09 May '07

Hi, I try this: svn copy https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/themes https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/branches/themes/2… -m 'initial copy for 2.10 themes' But I get branches/themes/2_10/themes/ all the themes There must be a way without having to copy each theme one by one?

1 1

[Phpmyadmin-devel] SHOW WARNINGS
by Marc Delisle 08 May '07

08 May '07

Should we test the MySQL version? This only works since MySQL 4.1.0. Or we accept to do an unneeded trip to the server? Marc

2 1

[Phpmyadmin-devel] PMA_DBI_get_warnings()
by Marc Delisle 08 May '07

08 May '07

Shouldn't we use this also in sql.php? If I type an INSERT in the query window and some values are missing, I don't get a warning. Marc

1 0

Re: [Phpmyadmin-devel] [Phpmyadmin-svn] SF.net SVN: phpmyadmin: [10336] tags/RELEASE_2_9_0_2/
by Michal Čihař 08 May '07

08 May '07

Hi On Mon, 30 Apr 2007 14:29:26 -0700 lem9(a)users.sourceforge.net wrote: > Revision: 10336 > http://svn.sourceforge.net/phpmyadmin/?rev=10336&view=rev > Author: lem9 > Date: 2007-04-30 14:29:26 -0700 (Mon, 30 Apr 2007) > > Log Message: > ----------- > unneeded > > Removed Paths: > ------------- > tags/RELEASE_2_9_0_2/ What's reason for deleting tags for old releases? They are useful to find out differences between them. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

4 8

[Phpmyadmin-devel] themes compatibility with 2.11
by Marc Delisle 08 May '07

08 May '07

Hi, For 2.11 there has been a change: phpmyadmin.css and print.css are now in the main directory. To accomodate this, a change has been made in svn trunk for all themes: - background-image: url(../<?php echo $_SESSION['PMA_Theme']->getImgPath(); ?>s_warn.png); + background-image: url(<?php echo $_SESSION['PMA_Theme']->getImgPath(); ?>s_warn.png); I would prefer if the themes in trunk can work with 2.11 and also prior versions, so I suggest we do something like this: background-image: url(<?php echo version_compare(PMA_VERSION,'2.11','lt') ? '../' : ''; echo $_SESSION['PMA_Theme']->getImgPath(); ?>s_warn.png); Too bad we did not think earlier to define a PMA_INT_VERSION. Marc

3 4

[Phpmyadmin-devel] Query Builder Ajax UI
by Dougal Matthews 07 May '07

07 May '07

Hi, I contact you all a while ago saying that I was going to attempting to create a query builder power by JavaScript for phpMyAdmin as a university project. I have been working away at it and have learned loads, this is the first time I've used JavaScript for anything serious. Anyway, I have so far created a prototype that I would like to show you. I first need to state that due to time constraint with university this prototype currently ONLY supports Firefox 2 and above (maybe 1.5 but I've been testing with version 2). It may also work in Safari and opera, I don't know. This is by no means a finished product, However, I'd like to show you have I have so far. You will run into a number of a issues, however any feedback would be appreciated. I have been having problems utilizing the functions in phpMyAdmin to use within my Ajax engine, I believe this is because of headers and cookies being sent by PHP. Any suggestions how I can get around this? Right... less talking, more prototype showing... Please read this section before visiting; Known Limitations (there are more, I've not got the list next to me, but the main problems are below); - Add remove tables can be buggy when tables are added and removed repeatedly - View SQL Query and Run SQL query are not yet working. Due to problems hooking in with the phpMyAdmin php System Requirements: - FireFox 2+ (maybe 1.5+) - A decent screen resolution, 1280 X 1024 recommended. It will work on lower but wont look as good. try going to full screen. And finally the URL is... http://www.dougalmatthews.com/hp/pma/ Depending on the feedback and what you guys think, I am hoping to continue this project in the summer and fix all the problems and add in cross browser support. I also hope to reduce the size of the JavaScript by eliminating some of the library use. Thanks Dougal

3 4

Re: [Phpmyadmin-devel] Query Builder Ajax UI
by Dougal Matthews 07 May '07

07 May '07

That's still working, I also enabled that Add/Remove tables (they get tables directly from the database now) and the generate SQL. I've not allowed the executing of the query yet as i need to do security checks and also the generation of the SQL isn't quite finished - i've not implemented the joins. By the way, when you add the tables, note that you can join tables by dragging rows from one to another. I should really add a note to tell people this because nobody thinks you would be able to do that :) Dougal On 07/05/07, Dougal Matthews <dougal85(a)gmail.com> wrote: > > Sorry, I fixed it now, I uploaded the wrong version by mistake! > My bad, It should be good to go now. > > Sorry about that. > > Dougal > > On 06/05/07, Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote: > > > > Dougal Matthews a écrit : > > > Hi, > > > > > > I contact you all a while ago saying that I was going to attempting to > > > create a query builder power by JavaScript for phpMyAdmin as a > > > university project. > > > > > > I have been working away at it and have learned loads, this is the > > first > > > time I've used JavaScript for anything serious. > > > > > > Anyway, I have so far created a prototype that I would like to show > > you. > > > I first need to state that due to time constraint with university this > > > prototype currently ONLY supports Firefox 2 and above (maybe 1.5 but > > > I've been testing with version 2). It may also work in Safari and > > opera, > > > I don't know. > > > > > > This is by no means a finished product, However, I'd like to show you > > > have I have so far. You will run into a number of a issues, however > > any > > > feedback would be appreciated. > > > > > > I have been having problems utilizing the functions in phpMyAdmin to > > use > > > within my Ajax engine, I believe this is because of headers and > > cookies > > > being sent by PHP. Any suggestions how I can get around this? > > > > > > Right... less talking, more prototype showing... > > > > > > Please read this section before visiting; > > > > > > Known Limitations (there are more, I've not got the list next to me, > > but > > > the main problems are below); > > > > > > * Add remove tables can be buggy when tables are added and removed > > > repeatedly > > > * View SQL Query and Run SQL query are not yet working. Due to > > > problems hooking in with the phpMyAdmin php > > > > > > System Requirements: > > > > > > * FireFox 2+ (maybe 1.5+) > > > * A decent screen resolution, 1280 X 1024 recommended. It will > > work > > > on lower but wont look as good. try going to full screen. > > > > > > > > > > > > And finally the URL is... http://www.dougalmatthews.com/hp/pma/ > > > > > > Depending on the feedback and what you guys think, I am hoping to > > > continue this project in the summer and fix all the problems and add > > in > > > cross browser support. I also hope to reduce the size of the > > JavaScript > > > by eliminating some of the library use. > > > > > > Thanks > > > > > > Dougal > > > > Hello Dougal, > > I am testing with FF 2.0.0.3 on Win XP. > > > > I click Add/Remove Tables. > > I tick table1 and get > > TypeError > > QB::addTable - Error adding table > > Table::Constructor - type error: pId must be a Number > > Undefined(undefined) > > qb::manage - Adding table1 > > > > Then I close the Add/remove tables window and cannot do anything else. > > > > Marc Delisle > > > > > > -- > Website : www.dougalmatthews.com -- Website : www.dougalmatthews.com

1 0

[Phpmyadmin-devel] false alarm for deep recursion
by Marc Delisle 01 May '07

01 May '07

Hi, In this bug: http://sourceforge.net/tracker/index.php?func=detail&aid=1709463&group_id=2… there are many fields involved and we get a false alarm "possible deep recursion attack". Do we really need to protect from 1000 recursions overall? I think that protecting from 1000 recursions for each superglobal would be correct. Proposed patch which resets the recursive counter: Index: common.lib.php =================================================================== --- common.lib.php (revision 10333) +++ common.lib.php (working copy) @@ -269,9 +269,12 @@ * @param array $array array to walk * @param string $function function to call for every array element */ -function PMA_arrayWalkRecursive(&$array, $function, $apply_to_keys_also = false) +function PMA_arrayWalkRecursive(&$array, $function, $apply_to_keys_also = false, $reset_static = false) { static $recursive_counter = 0; + if ($reset_static) { + $recursive_counter = 0; + } if (++$recursive_counter > 1000) { die('possible deep recursion attack'); } @@ -2604,10 +2607,10 @@ // remove quotes added by php if (get_magic_quotes_gpc()) { - PMA_arrayWalkRecursive($_GET, 'stripslashes', true); - PMA_arrayWalkRecursive($_POST, 'stripslashes', true); - PMA_arrayWalkRecursive($_COOKIE, 'stripslashes', true); - PMA_arrayWalkRecursive($_REQUEST, 'stripslashes', true); + PMA_arrayWalkRecursive($_GET, 'stripslashes', true, true); + PMA_arrayWalkRecursive($_POST, 'stripslashes', true, true); + PMA_arrayWalkRecursive($_COOKIE, 'stripslashes', true, true); + PMA_arrayWalkRecursive($_REQUEST, 'stripslashes', true, true); } /** * In some cases, this one is not set

2 3