Hi everybody
During testing of my patch I found also some bugs or thinks which I think
should be done different.
Here is short summary of them:
PDF related problems
- when $cfg['Servers'][$i]['table_coords'] is set and
$cfg['Servers'][$i]['pdf_pages'] is not set it produces just MySQL error
message, but IMHO it should report that it is wrong configured
- when I want to have just one table in pdf and it doesn't have any relations
I get just "Undefined PDF page number!" error
- is it possible to have one table on more pages?
- when I edit tables which will be displayed on some page and I select table
instead of one already selected it is added, not replaced
- is there any easy possibily how to use it in just few databases without
getting errors in the others?
- it works only with iso-8859-1 charset :-(
Syntaxcoloring
- (this is not bug just suggestion) Do you realy think that blue color as
default for some types ("colorKeywords" and "colorAdd") is good? It looks as
links, what about using for example: #990099
- when I create table with comment, the comment is not displayed (when
coloring switched off it is displayed correctly).
Other
$cfg['Servers'][$i]['column_comments'] - will it be used or it shouldn't be
in config?
How about adding links to db/table structure in left frame? I mostly use this
page in PMA and in 2.3.0 it's one more click for me :-(.
When I want to unmark marked row in browse mode it will get pointer not
original color and it can not be marked anymore.
I'm sorry, but I'm too lazy to add all of these bugs/comments to sf bugtrack.
Regards
Michal Cihar
nijel at users dot sourceforge dot net
http://cihar.liten.cz
> Could you change that functionality slightly?
> IF no parameters argc == 0,
> then display a help message
> IF option = -a
> then convert all *.php3 files
> ELSE if option = filename
> convert single file
Ok, in now has this functionality.
Michal
Hi
> > - ANY mysql function that takes or returns string must be replaced by PMA_mysql* function. To do this automatically there is available shell script http://cihar.liten.cz/PMA-patch/01-mysql-wrappers/PMA-cvt
>
> I was wondering if PMA-cvt can be done more than once on the same file.
Yes, you can run it as much times as you want ;-) It doesn't work with one file, but with every *.php3 in current directory and its subdirectories (except file mysql_wrappers.lib.php3 where are those wrappers).
Michal
Hi
as my patch was today commited into cvs here are few important notes about it:
- ANY mysql function that takes or returns string must be replaced by PMA_mysql* function. To do this automatically there is available shell script http://cihar.liten.cz/PMA-patch/01-mysql-wrappers/PMA-cvt
- ANY link (or form) should contain convcharset variable to keep this value while user uses these links
I think that second thing would cause less problems if the part of links/hidden inputs that is used everywhere (probaly: lang, server and convcharset) would be generated just once in common.lib.php3 and not in reaaly plenty places all over the code. What do you think about it?
Michal Cihar
cihar(a)email.cz
>
> remember we said that 2.3.0-RC1 is planned for June the 18th,
> so let's
> be careful about what we modify in cvs. And let's spend more time on
> tests until RC1.
june 18th? oops, i'll be diving in malta next week. as i think the tables
should be in their own db as discussed before this stuff is released to the
public that means i'll have to do this this evening and just hope it'll work
fine from the start
--
Mike Beck
mikebeck(a)users.sourceforge.net
> I played a bit with your new syntax highlighting feature.
> First of all, we should imho keep on using hex codes for
> color definitions
> in order to avoid misinterpretations. I've just changed this in CVS.
thanx
> The second thing is that the LIMIT clause is only highlighted
> if it has been
> added manually, the one that phpMyAdmin adds automatically is
> left black.
yes, because it is shown seperately, now it will be colored as well
> And finally we should not use blue for the SQL commands since
> we also use
> blue for the links above the SQL query output.
yes, i was wondering as well, but my textpad (which does a wonderful
syntaxhighlighting
if you have to use windows) uses the blue there as well, so that was what i
am used. But
feel free to choose some other colors and commit them.
> It's really a great feature!
> Happy debugging,
;-)
thank you.
as i didn't get an answer from the german php mailinglist, maybe one of you
will be able to help me to fix one bug i know of in my code there:
i need some regex that will enable me to replace ; inside a string if it
does not have ' around it.
if i have more than one query like:
select * from table where col=' ';select * from table where col=2;
i need a space after the ; that ends the first statement so i can split
them, but i don't want to add a space after of course.
can anybody tell me how to do it?
(btw: the code currently in cvs will for that reason not add any spaces
after ; which will result in the second select in the above statement not
being colored.)
--
Mike Beck
mikebeck(a)users.sourceforge.net
Hi Mike & list,
I played a bit with your new syntax highlighting feature.
First of all, we should imho keep on using hex codes for color definitions
in order to avoid misinterpretations. I've just changed this in CVS.
The second thing is that the LIMIT clause is only highlighted if it has been
added manually, the one that phpMyAdmin adds automatically is left black.
And finally we should not use blue for the SQL commands since we also use
blue for the links above the SQL query output.
It's really a great feature!
Happy debugging,
Alexander
Hi,
remember we said that 2.3.0-RC1 is planned for June the 18th, so let's
be careful about what we modify in cvs. And let's spend more time on
tests until RC1.
--
Marc Delisle
Hi,
I propose to replace these 3 messages:
$strCoordsNotSet = 'table_coords table not found or not set in
config.inc.php3';
$strInfoNotSet = 'table_info table not found or not set in config.inc.php3';
$strRelationNotSet = 'Relationtable not found or not set in
config.inc.php3';
by this:
$strNotSet = '%s table not found or not set in config.inc.php(3)';
plus, in pdf_pages.php3:
if(!isset($relex)){die(sprintf($strNotSet,'relation'));}
if(!isset($info)){die(sprintf($strNotSet,'table_info'));}
if(!isset($coords)){die(sprintf($strNotSet,'table_coords'));}
--
Marc Delisle
