> Olivier wrote:
> >still seems ok over here... (just tested with a few pma-generated
> >dumps).
>
> Indeed, whith a pma generated dump (beginning with comments)
> containing more than one query (eg create a table then inserts data)
> not using the remove_remark function make phpMyAdmin fails.
Well I find that quite strange. I had tested a bit and really thought
comments were harmless in sql queries. Well, as nobody had answered
after I had said I would suppress remove_remark(), I did it.
May be the comments contain ';'... If this is the case, there may be
no need to get remove_remark() back. (I had forgotten the possibility
of ';' in comments).
Anyway, if you try to remove comments again, you have to ignore '#' that
are in SQL strings if you don't want to bring back the # bug (#444279).
I'm sorry but I'll be unavailable through the next week because of
vacation. Good luck for the 2.2.0-final!
>mmm, seems you removed the again now ?
>(just doesn't look good)
Yep, except if the field value is empty. It doesn't work?
>Just also had to make a check if $cfgPmaAbsoluteUri is
>empty or not before adding a '/', otherwise it breaks
>many links.
Right.
I'm leaving, CU.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
>mmm, seems you removed the again now ?
>(just doesn't look good)
My fault: I commited the wrong file version. Re-commited
with the good one. Sorry.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
About last Olivier's changes:
You're right NS requires ... only if $row[$i] is empty. I was
curently working on and will repatch your change.
About Robin changes:
You forget to take into account the case with no advanced
authentification. My next commit will fix this.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hey everyone...okay, I will grab CVS and patch for the new styles with
the original colors...however, I do plan to use your logo from
phpmyadmin.com still. I have the code to make it look nice in Netscape
4, so I will throw that in, but I will have to do a brief browser sniff
to know...it is actually quite simple to add...
Dan
On 22 Aug 2001 12:10:13 -0700,
phpmyadmin-devel-request(a)lists.sourceforge.net wrote:
> Send Phpmyadmin-devel mailing list submissions to
> phpmyadmin-devel(a)lists.sourceforge.net
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> or, via email, send a message with subject or body 'help' to
> phpmyadmin-devel-request(a)lists.sourceforge.net
>
> You can reach the person managing the list at
> phpmyadmin-devel-admin(a)lists.sourceforge.net
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Phpmyadmin-devel digest..."
>
>
> Today's Topics:
>
> 1. Re: look of main.php3 (suggestion) (Ignacio Vazquez-Abrams)
>
> --__--__--
>
> Message: 1
> Date: Wed, 22 Aug 2001 15:04:12 -0400 (EDT)
> From: Ignacio Vazquez-Abrams <ignacio(a)openservices.net>
> To: <phpmyadmin-devel(a)lists.sourceforge.net>
> Subject: Re: [Phpmyadmin-devel] look of main.php3 (suggestion)
> Reply-To: phpmyadmin-devel(a)lists.sourceforge.net
>
> On Wed, 22 Aug 2001, Marc Delisle wrote:
>
> > Olivier,
> >
> > We will *always* find reasons to delay. But all the new features must be tested.
> > I think it's late for 2.2.0.
> >
> > But I also like very much the pulldown language menu :)
> >
> > Marc
>
> I'm thinking that as large an interface change as this should actually become
> 3.0.0, but I don't think it's ready to go there until we clean up existing
> code.
>
> However, having said that, I must agree that this thing is SHWEET! It looks
> _real_ slick under Mozilla. Under Navigator it looks like crap, but is anyone
> really surprised by that? ;)
>
> --
> Ignacio Vazquez-Abrams <ignacio(a)openservices.net>
>
>
>
>
> --__--__--
>
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel(a)lists.sourceforge.net
> http://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
> End of Phpmyadmin-devel Digest
Ok, i patched in the latest CVS after I got up this morning and it seems
to be working now.
But a few comments about it.
Nowhere on the pages do we actually know if it's using the socket or the
TCP/IP connection method.
I would suggest that we alter the main.php3, where it says:
"MySQL 3.23.40robbat2-log running on localhost"
to indicate if we are using the socket or the connection.
in addition to that, a configuration variable
along the lines of
$cfgServers[1]['usesocket'] = TRUE; // use socket as opposed to TCP/IP
as somebody might actually want to choose tcp/ip over sockets (or vice-versa)
just my morning $0.02
i'm gonna carry on working on my webpage contracts for my textbooks, i've
got one down, one to go to cover them. ($420 CDN in total)
--
Robin Hugh Johnson
"Robbat2"
QTOD: "I used to be an idealist, but I got mugged by reality."
E-Mail : robbat2(a)orbis-terrarum.net
ICQ# : 30269588 or 41961639
Home Page : http://www.orbis-terrarum.net
Time Zone : Pacific Daylight (GMT - 8)
-----BEGIN GEEK CODE-----
geekcode.comebb.org/ungeek
GCS/M/IT d-(+) s+:- a--- C++++
U++++ L++++ P--(+) W++ K++ PS+
N++ w--- O E---- M-(+) V-- Y++
PE++ PGP++ t-- 5 X+ R tv- b+++
D++ G++ e(*) h! r-- !y+
------END GEEK CODE------
-----PGP INFO-{---
Key ID:0x7E20DFA1
FingerPrint:
5447C73A 30FB144C 89521B69 2D6A615E 7E20DFA1
---}-PGP INFO-----
>Sorry, this happens when the trailing '/' is not in
>$cfgPmaAbsoluteUri.
Hey Marc, it seems my little english sentences about this
variables are really ununderstandable ;)
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
$connect_func() is defined in lib.inc.php3
and used there and in main.php3
BUT mysql_connect() is also used in main.php3 lines 158,183 & 189
is this intended or a coding inconsistancy ?
--
Robin Hugh Johnson
"Robbat2"
QTOD: "I used to be an idealist, but I got mugged by reality."
E-Mail : robbat2(a)orbis-terrarum.net
ICQ# : 30269588 or 41961639
Home Page : http://www.orbis-terrarum.net
Time Zone : Pacific Daylight (GMT - 8)
-----BEGIN GEEK CODE-----
geekcode.comebb.org/ungeek
GCS/M/IT d-(+) s+:- a--- C++++
U++++ L++++ P--(+) W++ K++ PS+
N++ w--- O E---- M-(+) V-- Y++
PE++ PGP++ t-- 5 X+ R tv- b+++
D++ G++ e(*) h! r-- !y+
------END GEEK CODE------
-----PGP INFO-{---
Key ID:0x7E20DFA1
FingerPrint:
5447C73A 30FB144C 89521B69 2D6A615E 7E20DFA1
---}-PGP INFO-----
I like that look, for how clean it is. In followup to both this e-mail
and the one about specifiying whether a socket is being used or not, I
have this to suggest.
http://65.5.154.16/phpMyAdmin/
I realize the colors are totally different, but take more of the idea of
the summary bar up top which shows if you are connected, who you are
connected as, the socket and the versions. Also, I took the graphic
from the phpMyAdmin home page and used it to spruce of the lists. I am
a bit on the bleeding edge of styles so some versions of netscape 4 will
throw up, but that doesn't concern me for my site, but again, maybe just
take the idea...and did the drop down box for languages ever squeeze in
there???
Dan Allen
--having an extremely crazy week...bare with me
> --__--__--
>
> Message: 2
> Date: Tue, 21 Aug 2001 22:40:58 +0200
> From: "Olivier M." <qmail(a)orion.8304.ch>
> To: phpmyadmin-devel(a)lists.sourceforge.net
> Subject: [Phpmyadmin-devel] look of main.php3 (suggestion)
> Reply-To: phpmyadmin-devel(a)lists.sourceforge.net
>
> Hello,
>
> I don't know what you think, but I find that the current
> main.php3 look is not really nice... :)
>
> Just replaced the <ul> by tables, and it looks like that now:
> (not in cvs, just as test):
> http://www.omnis.ch/stuff/pmatest/
>
>
> Do you like that ? The source (*very* bad html) is under
> http://www.omnis.ch/stuff/pmatest/main.php3.txt : if an html
> wizard would like to make that clean, you're welcome!
>
> Olivier
> --
> _________________________________________________________________
> Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
> qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
>
>
