- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] load data bug
by Dan Allen 14 Aug '01

14 Aug '01

I came across a bug today in the load data from infile. I had data in a text file that had rows terminated with a line feed (\n). When the query was executed, it echoed ...LINES TERMINATED BY "\\n" however, that is incorrect because it is escaping the \ so that it is not interpreted as a line fed but literately as "\n" The problem is, when the line termination varibable goes into ldi_check.php, it strips the slashes if magic quote are enabled...and then it runs the sql_addslashes function, however, this is not correct...it should only add slashes for the single quotes and not for the backslashes if it is backslash \n \r or both...Anyway...check out the patch to the CVS version Dan Allen __________________________________________________ Do You Yahoo!? Make international calls for as low as $.04/minute with Yahoo! Messenger http://phonecard.yahoo.com/

1 0

[Phpmyadmin-devel] Bug #449858, Error Changing Column DataType
by Robin Johnson 14 Aug '01

14 Aug '01

Could somebody else please have a look at the sf bug page for this one, and see if they have any other possible solutions that could be used for this bug? I'll give 12 hours before I work on it. -- Robin Hugh Johnson QTOD: "I used to be an idealist, but I got mugged by reality." E-Mail : robbat2(a)orbis-terrarum.net ICQ# : 30269588 or 41961639 Home Page : http://www.orbis-terrarum.net/ Time Zone : Pacific Daylight (GMT - 8) -----BEGIN GEEK CODE----- geekcode.com ebb.org/ungeek GCS/M/IT d-(+) s+:- a--- C++++ U++++ L++++ P--(+) W++ K++ PS+ N++ w--- O E---- M-(+) V-- Y++ PE++ PGP++ t-- 5 X+ R tv- b+++ D++ G++ e(*) h! r-- !y+ ------END GEEK CODE------ -----PGP INFO---- Key ID:0x7E20DFA1 FingerPrint: 5447C73A 30FB144C 89521B69 2D6A615E 7E20DFA1 ----PGP INFO-----

2 4

[Phpmyadmin-devel] Rejoining
by Robin Johnson 13 Aug '01

13 Aug '01

Hi All, After a long sabbatical from developing on phpMyAdmin, due to final exams and a month long vacation in South Africa [able to check my email only with a 14.4 modem :-( ], I'm now coming back to carry on working. I have noticed a few new bits popping into phpMyAdmin since i've been using it as a user while I have been doing other things, and some of the new bits are definetly getting places. Just looking at the current status, 2.2.0-rc4, I'd assume we're working on fixing as many bugs as possible to be ready for -final. What are the most pressing issues that I can get to work on, and when are we aiming to release -final by? -- Robin Hugh Johnson QTOD: "I used to be an idealist, but I got mugged by reality." E-Mail : robbat2(a)orbis-terrarum.net ICQ# : 30269588 or 41961639 Home Page : http://www.orbis-terrarum.net/ Time Zone : Pacific Daylight (GMT - 8) -----BEGIN GEEK CODE----- geekcode.com ebb.org/ungeek GCS/M/IT d-(+) s+:- a--- C++++ U++++ L++++ P--(+) W++ K++ PS+ N++ w--- O E---- M-(+) V-- Y++ PE++ PGP++ t-- 5 X+ R tv- b+++ D++ G++ e(*) h! r-- !y+ ------END GEEK CODE------ -----PGP INFO---- Key ID:0x7E20DFA1 FingerPrint: 5447C73A 30FB144C 89521B69 2D6A615E 7E20DFA1 ----PGP INFO-----

4 8

[Phpmyadmin-devel] HTTP compilance
by Benjamin Gandon 13 Aug '01

13 Aug '01

I've just pointed out that we use the "Location:" HTTP header field in a manner that is not HTTP complilant. It seems that it work because browsers seem to respect Postel's advice ("be conservative in what you send and liberal in what you accept"). rfc 2816 says: Location = "Location" ":" absoluteURI An example is: Location: http://www.w3.org/pub/WWW/People.html And we use for example: tbl_select.php3:181: header('Location: sql.php3?' . $url_query); And that is quite not an absolute URI... I didn't find any suitable header in rfc2616 that could replace the "Location:" one and accept relative URI. ("Content-Location:" is quite good but it does not specify a replacement for the original requested URI). It seems that in order to have phpMyAdmin generate absolute URI in "Location:" HTTP headers, we have to introduce a configuration variable that would hold the absolute path (server name + path!). I don't think solving this is urgent because it works fine like that (except lynx who warns the user that the Location URL is not absolute and then goes to the right place). We can postpone that for a later version or let it go and just document that we do that (My lazyness would recommend letting it go :)).

2 1

[Phpmyadmin-devel] problem with expand_sql_query()
by Marc Delisle 13 Aug '01

13 Aug '01

Hi, trying this with current cvs: CREATE TABLE Binary_Table ( ID mediumint(8) unsigned NOT NULL auto_increment, MyData blob NOT NULL, PRIMARY KEY (ID) ) TYPE=MyISAM; I get an allocation memory error in lib.inc.php3, line 1608. Marc

2 2

[Phpmyadmin-devel] query results
by Dan Allen 12 Aug '01

12 Aug '01

Sorry for so many posts, but I have a lot of suggestions... Right now, if you run a query (and not just a browse), it does not return the total results...it only shows you 0 to 30 and then the navigation buttons appear depending on whether there are more than 30 results. The reason for this is in lib.inc.php in the dispaly_table function. This is how it should be.... if (!$is_simple&&!empty($db)) { $result = mysql_query($sql_query); $total = mysql_num_rows($result); } // end if whereas before it only ran the query for a browse by just counting all the rows in the table...in fact, what needs to happen is the query needs to be run again without LIMIT 30,0 to get the total number of rows...it should be quite fast and maybe this can be a configuration option to always calculate the total results returned...This way, you can add a "Show All" button that will break out of the LIMIT, useful when you want to get all the rows from a search repeatedly... Dan Allen

2 1

[Phpmyadmin-devel] 2.2.0 ever?
by Marc Delisle 11 Aug '01

11 Aug '01

Hi, let's talk about 2.2.0 (again :) Will it be bug-free? I don't think so. Will it be the last phpMyAdmin version? I don't think so. Will 2.2.1 be better? I think yes. Can we agree about which bugs are showstoppers? Let's try :) Marc

3 2

RE: [Phpmyadmin-devel] left.php suggestions
by Benjamin Gandon 11 Aug '01

11 Aug '01

> I like the idea of the drop-down language selection, because just > showing > the iso codes can be confusing. I agree with that. (I know it' not such a hard thing to add but maybe we should concentrate on current bugs)

3 2

RE: [Phpmyadmin-devel] Bug avalanche
by Benjamin Gandon 10 Aug '01

10 Aug '01

Well, not such an avalanche. Just browse unassigned ones! :)) > - some bugs are dupes or similar (444354 and 446830 ? 443499 > and 448226 ? ...) No, #443499 (Unable to "Insert textfile into table") is not the same as #448226 ((RC3) Missing MySQL error messages) I'm waiting for a response to close the bug, but maybe I'll do it before that. Anyway I agree with you and I'll try to close those assigned to me asap.

1 0

RE: [Phpmyadmin-devel] removing remarks is useless
by Benjamin Gandon 10 Aug '01

10 Aug '01

> I did a bit of poking around in the online documentation, and > certainly nothing in the 3.2x's cares. Nobody is against, so I'll drop remove_remarks() code in lib.inc.php3, suppress one line in db_readdump.php3 and close bug #444279 (# problem in uploaded file). (in an effort to close bugs :))

1 0