Hi Olivier & all!
>Problems were: PMA_INT_VERSION < 30010 instead of
>PMA_INT_VERSION >= 30010 :)
I'm afraid this isn't true ;) The socket setting is available since
php 3.0.10 only then $server_socket should be empty if
PMA_INT_VERSION < 30010.
>and fact that $connect_func() is used twice in lib.inc.php3
Oups, you're right... I must be drunk we I merged the patch.
But the name of this second link is $link and not $dbh.
OK, I've done some advanced tests with the socket patch and
found also that phpMyAdmin runs even with a garbage socket
path. It seems that php try to use a kind of default socket path
if the one defined in the phpMyAdmin configuration file is not
valid or scans all available sockets till it finds the convenient one
(indeed it takes far much time to load phpMyAdmin whith an
invalid socket path).
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Looks like the socket patch made it in. Good luck with the release of
2.2.0 and once I get some sleep (sleep? what is that) I will try to get
back to working on patches for suggestions I had for after the release
since I know you guys are really trying to polish up this one. Great
job everyone!
Dan
> Hi again!
>
> Some time ago, Dan Allen suggested a light patch that allows to define
> the socket phpMyAdmin should use in this list. Does anybody already
> tried to merge it into the current version or not?
>
> Loïc
>
A long time ago, Benjamin Gandon noted that the way location http
headers are used does not fit rfc 2816. I've just commited the fix
into the CVS tree.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
I've also merged this patch into the CVS tree. It would be nice if
someone can test the changes because I'm not a socket specialist ;)
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi again!
Some time ago, Dan Allen suggested a light patch that allows to define
the socket phpMyAdmin should use in this list. Does anybody already
tried to merge it into the current version or not?
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
Hi Olivier & all!
[About user administration pages]
>Would it be possible to make it work also without javascript ?
>For example the "Go" button on "add user" is not a standard submit
>button, and this user administration page would be quite practical
>on sysadmin work, on console+lynx... :)
This MUST be done... but rewritting this script in a convenient format with
such requirements is at least a one full day work. And I don't have so many
free times now :(
>Other small anoying thing: on file upload, the whole file (even if 2MB big)
>is displayed in the "Your SQL-query has been executed successfully"
>box and in the "Run SQL query/queries on database ____" textarea.
>...
>For example on file upload, only display "File uploaded successfully, xxx
>rows loaded" + mysql message if any, and keep the textarea empty ?
Nice idea :)
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
I am not happy with this phrase:
"MySQL passwords cannot be decrypted easily, so there's no chance
for a normal user to look at other users' plaintext passwords."
This phrase could make someone believe that with phpMyAdmin in advanced auth, normal users can have
a look at encrypted passwords, which is not true.
If config.inc.php3 is properly protected (as explained in the doc), users can't even see the stduser
password.
Maybe we should remove this phrase, and add something telling the sysadmin to put PHP in safe mode
after:
"Your config.inc.php3 file should be chmod 660"
Marc
Ok, looking under 'Support Requests' (#447076) there is a note about using
ereg instead of preg, so i went back to convert my lone instance of a preg
in the code.
But try as hard as I might, I can't manage to use eregi_replace to do the
same thing as my bit of code.
lib.inc.php3 - line 694
$sql = preg_replace(
'/\W'.$data[1].'\./i',
' '.$data[0].'.',
$sql);
Could somebody else make a suggestion about the query I can use?
my best conversion of the pcre was "[!a-zA-Z0-9_]".$data[1]."\." but that
doesn't work :-(.
I have also realized that my code adds a nasty little bug.
this is the SQL i was using to test the above:
SELECT c.id, s.id FROM classes c, staff s WHERE c.staff = s.id ORDER BY
s.id
now if i change the fields section at the start just slightly, and the
where clause by taking out some of the white space:
SELECT c.id,s.id FROM classes c, staff s WHERE c.staff=s.id ORDER BY s.id
then the ',' in the fields gets replaced with a space, and your perfectly
valid query is now invalid. The same thing happens with the '=' in the
where clause. We need to find a way to preserve the other character that
matched the \W in the pcre as well as add a space after it. I had the \W
in there so that trying to match 's.' would not match 'foods.' . Any
suggestions on this one?
--
Robin Hugh Johnson
QTOD: "I used to be an idealist, but I got mugged by reality."
E-Mail : robbat2(a)orbis-terrarum.net
ICQ# : 30269588 or 41961639
Home Page : http://www.orbis-terrarum.net/
Time Zone : Pacific Daylight (GMT - 8)
-----BEGIN GEEK CODE-----
geekcode.comebb.org/ungeek
GCS/M/IT d-(+) s+:- a--- C++++
U++++ L++++ P--(+) W++ K++ PS+
N++ w--- O E---- M-(+) V-- Y++
PE++ PGP++ t-- 5 X+ R tv- b+++
D++ G++ e(*) h! r-- !y+
------END GEEK CODE------
-----PGP INFO----
Key ID:0x7E20DFA1
FingerPrint:
5447C73A 30FB144C 89521B69 2D6A615E 7E20DFA1
----PGP INFO-----
Olivier, there were some problems with your fix for file upload. I've fixed
them.
Loïc
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
