Developers June 2002

developers@phpmyadmin.net

18 participants
58 discussions

[Phpmyadmin-devel] Bugs from Michael
by mike.a.beck＠t-online.de 15 Jun '02

15 Jun '02

> PDF related problems the whole relation/bookmark/pdf stuff has been widely rewritten by me now because of moving the tables to a central db so a lot has changed there ... > - when $cfg['Servers'][$i]['table_coords'] is set and > $cfg['Servers'][$i]['pdf_pages'] is not set it produces just MySQL error > message, but IMHO it should report that it is wrong configured shouldn't happen anymore because of the different way that i check this in libraries/relation.inc.php3 > - when I want to have just one table in pdf and it doesn't have any > relations > I get just "Undefined PDF page number!" error please see if this will still happen with the new code, even then i think this is more a problem of giving a decent errormessage than of actually changing a lot there - there is not much sense in creating pdfs of only one table. if you want a column list of one table have a look at tbl_printview > - is it possible to have one table on more pages? yes it is, but should allready have been possible with the code you have this is what we created the pdf_pages table for. > - when I edit tables which will be displayed on some page and I select table > instead of one already selected it is added, not replaced ? i was sure i had tested that. i hope i can test this again later when i finished all the other changes > - is there any easy possibily how to use it in just few databases without > getting errors in the others? this will work without problems now with the new centralized pma_db > - it works only with iso-8859-1 charset :-( because of the fpdf library that is used there as told in the documentation. could you enable this library to use other charsets? > Syntaxcoloring > - (this is not bug just suggestion) Do you realy think that blue color as > default for some types ("colorKeywords" and "colorAdd") is good? It looks as > links, what about using for example: #990099 ;-) rabus allready said this, please feel free to change the color and commit > - when I create table with comment, the comment is not displayed (when > coloring switched off it is displayed correctly). it is? oops, mea culpa.. hmm don't have an immediate idea why this should happen... > Other > $cfg['Servers'][$i]['column_comments'] - will it be used or it shouldn't be > in config? well i want to do this for 2.3.0 allthough time is running out - as mentioned before i will be in malta diving for one week starting tomorrow, and i still have to work in a bar tonight. so in a few hours i will have to stop. if i cannot make it until then, you want to release on the 18th as planned and nobody else finds the time to add this to tbl_relation (to enter comments) and tbl_printview (to show them) just remove this > How about adding links to db/table structure in left frame? I mostly use > this page in PMA and in 2.3.0 it's one more click for me :-(. me too, but i don't want to have more than one link per table on the left side - i have databases with about 30 tables and i want to have them all on one side. but we could have a vote of wether it is more practical to get to structure or to get to sql page cheers Mike Beck mikebeck(a)users.sourceforge.net

2 1

[Phpmyadmin-devel] "Few" questions/bugs
by Michal Cihar 15 Jun '02

15 Jun '02

Hi everybody During testing of my patch I found also some bugs or thinks which I think should be done different. Here is short summary of them: PDF related problems - when $cfg['Servers'][$i]['table_coords'] is set and $cfg['Servers'][$i]['pdf_pages'] is not set it produces just MySQL error message, but IMHO it should report that it is wrong configured - when I want to have just one table in pdf and it doesn't have any relations I get just "Undefined PDF page number!" error - is it possible to have one table on more pages? - when I edit tables which will be displayed on some page and I select table instead of one already selected it is added, not replaced - is there any easy possibily how to use it in just few databases without getting errors in the others? - it works only with iso-8859-1 charset :-( Syntaxcoloring - (this is not bug just suggestion) Do you realy think that blue color as default for some types ("colorKeywords" and "colorAdd") is good? It looks as links, what about using for example: #990099 - when I create table with comment, the comment is not displayed (when coloring switched off it is displayed correctly). Other $cfg['Servers'][$i]['column_comments'] - will it be used or it shouldn't be in config? How about adding links to db/table structure in left frame? I mostly use this page in PMA and in 2.3.0 it's one more click for me :-(. When I want to unmark marked row in browse mode it will get pointer not original color and it can not be marked anymore. I'm sorry, but I'm too lazy to add all of these bugs/comments to sf bugtrack. Regards Michal Cihar nijel at users dot sourceforge dot net http://cihar.liten.cz

1 0

RE: RE: Re: [Phpmyadmin-devel] Charsets patch
by Michal Cihar 14 Jun '02

14 Jun '02

> Could you change that functionality slightly? > IF no parameters argc == 0, > then display a help message > IF option = -a > then convert all *.php3 files > ELSE if option = filename > convert single file Ok, in now has this functionality. Michal

2 1

RE: Re: [Phpmyadmin-devel] Charsets patch
by Michal Cihar 14 Jun '02

14 Jun '02

Hi > > - ANY mysql function that takes or returns string must be replaced by PMA_mysql* function. To do this automatically there is available shell script http://cihar.liten.cz/PMA-patch/01-mysql-wrappers/PMA-cvt > > I was wondering if PMA-cvt can be done more than once on the same file. Yes, you can run it as much times as you want ;-) It doesn't work with one file, but with every *.php3 in current directory and its subdirectories (except file mysql_wrappers.lib.php3 where are those wrappers). Michal

2 1

[Phpmyadmin-devel] Charsets patch
by Michal Cihar 14 Jun '02

14 Jun '02

Hi as my patch was today commited into cvs here are few important notes about it: - ANY mysql function that takes or returns string must be replaced by PMA_mysql* function. To do this automatically there is available shell script http://cihar.liten.cz/PMA-patch/01-mysql-wrappers/PMA-cvt - ANY link (or form) should contain convcharset variable to keep this value while user uses these links I think that second thing would cause less problems if the part of links/hidden inputs that is used everywhere (probaly: lang, server and convcharset) would be generated just once in common.lib.php3 and not in reaaly plenty places all over the code. What do you think about it? Michal Cihar cihar(a)email.cz

3 2

[Phpmyadmin-devel] merging in cvs
by Marc Delisle 13 Jun '02

13 Jun '02

Hi, if you can, please don't touch the cvs for about 2 hours, I am merging a big patch from Michal. Please wait for my next message. Marc

1 1

AW: [Phpmyadmin-devel] about the RC1 freeze
by Beck, Mike 13 Jun '02

13 Jun '02

> > remember we said that 2.3.0-RC1 is planned for June the 18th, > so let's > be careful about what we modify in cvs. And let's spend more time on > tests until RC1. june 18th? oops, i'll be diving in malta next week. as i think the tables should be in their own db as discussed before this stuff is released to the public that means i'll have to do this this evening and just hope it'll work fine from the start -- Mike Beck mikebeck(a)users.sourceforge.net

1 0

AW: [Phpmyadmin-devel] Syntax Highlighting
by Beck, Mike 13 Jun '02

13 Jun '02

> I played a bit with your new syntax highlighting feature. > First of all, we should imho keep on using hex codes for > color definitions > in order to avoid misinterpretations. I've just changed this in CVS. thanx > The second thing is that the LIMIT clause is only highlighted > if it has been > added manually, the one that phpMyAdmin adds automatically is > left black. yes, because it is shown seperately, now it will be colored as well > And finally we should not use blue for the SQL commands since > we also use > blue for the links above the SQL query output. yes, i was wondering as well, but my textpad (which does a wonderful syntaxhighlighting if you have to use windows) uses the blue there as well, so that was what i am used. But feel free to choose some other colors and commit them. > It's really a great feature! > Happy debugging, ;-) thank you. as i didn't get an answer from the german php mailinglist, maybe one of you will be able to help me to fix one bug i know of in my code there: i need some regex that will enable me to replace ; inside a string if it does not have ' around it. if i have more than one query like: select * from table where col=' ';select * from table where col=2; i need a space after the ; that ends the first statement so i can split them, but i don't want to add a space after   of course. can anybody tell me how to do it? (btw: the code currently in cvs will for that reason not add any spaces after ; which will result in the second select in the above statement not being colored.) -- Mike Beck mikebeck(a)users.sourceforge.net

1 0

[Phpmyadmin-devel] Syntax Highlighting
by Rabus 12 Jun '02

12 Jun '02

Hi Mike & list, I played a bit with your new syntax highlighting feature. First of all, we should imho keep on using hex codes for color definitions in order to avoid misinterpretations. I've just changed this in CVS. The second thing is that the LIMIT clause is only highlighted if it has been added manually, the one that phpMyAdmin adds automatically is left black. And finally we should not use blue for the SQL commands since we also use blue for the links above the SQL query output. It's really a great feature! Happy debugging, Alexander

1 0

[Phpmyadmin-devel] about the RC1 freeze
by Marc Delisle 12 Jun '02

12 Jun '02

Hi, remember we said that 2.3.0-RC1 is planned for June the 18th, so let's be careful about what we modify in cvs. And let's spend more time on tests until RC1. -- Marc Delisle

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers June 2002