June 2011 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] Recent tables list doesn't honor current server
by Piotr Przybylski 21 Jun '11

21 Jun '11

Hi, I just noticed - when I change servers on demo server (eg. MySQL -> MariaDB) and select a recent table that's only in MySQL, I am redirected to table list with no database selected and no tables, and then to proper database list. It should change servers and show this table, or not show any tables from other servers (work per server). -- Regards, Piotr Przybylski

5 9

[Phpmyadmin-devel] Row not highlighted in browse-mode
by Aris Feryanto 21 Jun '11

21 Jun '11

Hi, Just noticed in current master, if we have cfg_BrowsePointerEnable=true (it is default to true) and browse a table, the row is not highlighted completely when we hover a row. From the git bisect, I found it happen first time after: commit f771e68a73dfca6199030c1598b23e92de50f64c : - Fix for: If the moseout event on the row highlighting fails to get called (e.g. when having html code in the row), the toggle class will wrongly assign the hover class next time the element is being hovered over - Better formatted PMA_createChart() -- Aris Feryanto

3 5

[Phpmyadmin-devel] New code documentation
by Michal Čihař 21 Jun '11

21 Jun '11

Hi all I've just adjusted script to daily generate documentation from our sources so that it does not use phpdoc, which tend to consume too much memory and switched to [DocBlox][1]. The new (daily updated) documentation is available at same location: http://www.phpmyadmin.net/phpdoc/ You can also check build failures in the build.log: http://www.phpmyadmin.net/phpdoc/build.log As you can see, way to many things end up in Default package, what might be worth fixing :-). [1]:http://www.docblox-project.org/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 3

Re: [Phpmyadmin-devel] On the @uses comment tag
by Tyron Madlener 21 Jun '11

21 Jun '11

On Tue, Jun 21, 2011 at 10:38 AM, Michal Čihař <michal(a)cihar.com> wrote: > Hi > > please keep reply on the mailing list :-) I wish I could tell gmail to automatically use the mailing list address :/ > > Dne Tue, 21 Jun 2011 10:35:41 +0200 > Tyron Madlener <tyronx(a)gmail.com> napsal(a): > >> On Tue, Jun 21, 2011 at 10:11 AM, Michal Čihař <michal(a)cihar.com> wrote: >> > Hi >> > >> > Dne Mon, 20 Jun 2011 17:55:57 +0200 >> > Tyron Madlener <tyronx(a)gmail.com> napsal(a): >> > >> >> Since they are all in the same format and unique we could just run a >> >> regexp over all pma php files that removes those lines. >> >> Something like this (untested): >> >> >> >> replace('.'); >> >> function replace($dir) { >> >> $rdir = opendir($dir); >> >> while($file=readdir($rdir)) { >> >> if(is_dir($dir.'/'.$file) && $file!='.' && $file!='..') >> >> replace($dir.'/'.$file); >> >> else { >> >> $text = file_get_contents($file); >> >> $fp = fopen($file,'w'); >> >> fwrite($fp, preg_replace("/^\s*\*\s*(a)uses.*/m",'',$text)); >> >> fclose($fp); >> >> } >> >> } >> > >> > Well there are many ways to remove it, but the question is whether we >> > want to :-). >> > >> > PS: I would rather use: >> > >> > find . -name '*.php' | xargs sed -i '/^[[:space:]]*\* @uses /D' >> >> Well that one liner totally owns my php code snippet of course :( >> >> I'd also agree in removing those, the time invested in keeping them >> up-to-date is probably greater than any time advantages gained in >> having them. >> >> > >> > -- >> > Michal Čihař | http://cihar.com | http://blog.cihar.com >> > >> > > > -- > Michal Čihař | http://cihar.com | http://blog.cihar.com >

1 0

[Phpmyadmin-devel] Column resizing & reordering
by Aris Feryanto 21 Jun '11

21 Jun '11

Hi all, I pushed my work on two related features: column resizing & reordering. I tried (and struggled :) ) to make these features as compatible as possible with inline editing and vertical display mode. The features currently work in Browse, SQL and Search tab. I also integrate it with current ajax pagination and sorting. You may try the demo at [0]. Your comments and suggestions are really appreciated. Note: In vertical display mode, column reordering reorders the table header in the left of the table. [0] http://demo.phpmyadmin.net/gsoc-aris -- Aris Feryanto

5 80

[Phpmyadmin-devel] GSoC 2011: Routines functionality is complete
by Rouslan Placella 21 Jun '11

21 Jun '11

Hi there, In my opinion the routines functionality is complete and is ready to be merged with master. I will now be moving on to work on support for events. Please let me know what you think. Rouslan

3 5

[Phpmyadmin-devel] phpMyAdmin 3.4.3-rc1 is released
by Marc Delisle 20 Jun '11

20 Jun '11

Welcome to the first release candidate of phpMyAdmin 3.4.3, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] ready for 3.4.3-rc1
by Marc Delisle 20 Jun '11

20 Jun '11

... for today? -- Marc Delisle http://infomarc.info

2 1

Re: [Phpmyadmin-devel] GSOC 2011 Drizzle : remarks
by Piotr Przybylski 19 Jun '11

19 Jun '11

2011/6/19 Dieter Adriaenssens <dieter.adriaenssens(a)gmail.com>: > Hi Piotr, > > I hope you are doing well. How did your finals go? I couldn't schedule them for the date I wanted, but at least I am almost done with my master's thesis. > > I have some questions, remarks and suggestion about your latest commits : > > * commit 2e01d01b322 : Change all calls of SHOW KEYS/INDEX that use > MySQL-specific fields to use query generation function > > in db_datadict.php : > > - $indexes_info[$row['Key_name']]['Non_unique'] = > $row['Non_unique']; > + $indexes_info[$row['Key_name']]['Non_unique'] = > PMA_DRIZZLE ? $row['Unique'] : $row['Non_unique']; > > Shouldn't $row['Unique'] be inverted? In a later commit I changed the query used here to mimic MySQL's SHOW INDEXES, so I fixed it by using $row['Non_unique'] always. > * commit d607fa3e5c : Make live query chart work in Drizzle > > Please use CONCAT(), it makes the query better readable. Probably depends on what one is used to, for me "||" is a normal operator :) Changed. > * commit a5342c70ea : Server Status: remove warnings, make process > list and query stats work (Drizzle) > > 1) Same remark about CONCAT(). > > 2) > - <td><?php echo $process['User']; ?></td> > + <td><?php echo PMA_DRIZZLE ? $process['Username'] : > $process['User']; ?></td> > > Is there a way of changing 'Username' to 'User' where the process > array is generated? > I think it's better to have as little PMA_DRIZZLE code in the front > end (i.e. html-generating) php files as possible, and try to catch the > differences in the libraries instead. This makes the html-generating > code better readable, and your project more easy to merge with master. Changed - now I use data_dictionary views to generate that information. As a bonus, I got to report two Drizzle bugs. > On a side note : I've been thinking about what you did for main.php. > Could you create a lib-function for the servertype check? What should it return? 'MySQL', 'MariaDB' and 'Drizzle' strings? -- Regards, Piotr Przybylski

2 2

[Phpmyadmin-devel] GSOC 2011 Drizzle : remarks
by Dieter Adriaenssens 19 Jun '11

19 Jun '11

Hi Piotr, I hope you are doing well. How did your finals go? I have some questions, remarks and suggestion about your latest commits : * commit 2e01d01b322 : Change all calls of SHOW KEYS/INDEX that use MySQL-specific fields to use query generation function in db_datadict.php : - $indexes_info[$row['Key_name']]['Non_unique'] = $row['Non_unique']; + $indexes_info[$row['Key_name']]['Non_unique'] = PMA_DRIZZLE ? $row['Unique'] : $row['Non_unique']; Shouldn't $row['Unique'] be inverted? * commit d607fa3e5c : Make live query chart work in Drizzle Please use CONCAT(), it makes the query better readable. * commit a5342c70ea : Server Status: remove warnings, make process list and query stats work (Drizzle) 1) Same remark about CONCAT(). 2) - <td><?php echo $process['User']; ?></td> + <td><?php echo PMA_DRIZZLE ? $process['Username'] : $process['User']; ?></td> Is there a way of changing 'Username' to 'User' where the process array is generated? I think it's better to have as little PMA_DRIZZLE code in the front end (i.e. html-generating) php files as possible, and try to catch the differences in the libraries instead. This makes the html-generating code better readable, and your project more easy to merge with master. On a side note : I've been thinking about what you did for main.php. Could you create a lib-function for the servertype check? -- Kind regards, Dieter Adriaenssens

1 0