Developers August 2013

developers@phpmyadmin.net

16 participants
70 discussions

[Phpmyadmin-devel] Issue with event editing

by Ayush Chaudhary

Hi, I was writing Selenium tests for editing an event. While creating an event, I created it with the clause 'EVERY 2 MINUTE_SECOND' and it worked fine. However, MySQL stores it as '0:2', so when I go to edit the event, the default value for interval field is '0:2', and then when I submit the edit form, our code takes the intval from 0:2 and forms the query 'EVERY 0 MINUTE_SECOND' and this creates an error. Is there a specific reason why intval is being used in rte_events.lib.php on Line 585? If not, should I remove that and issue a pull request? -- Ayush Chaudhary

10 years, 11 months

[Phpmyadmin-devel] refactoring server_databases.php

by Marc Delisle

Hi Bin, these chunks need refactoring: - the $sort_by and $sort_order logic - the drops multiple databases logic -- Marc Delisle http://infomarc.info

10 years, 11 months

[Phpmyadmin-devel] Refactoring server_privileges.php

by Marc Delisle

Hi Bin, there are still some chunks of code that need refactoring. -- Marc Delisle http://infomarc.info

10 years, 11 months

[Phpmyadmin-devel] Are we a non commercial entity

by Mohamed Ashraf

I was looking at the licensing terms of a js charts library and it stated that is not free for commercial use. I wanted to use this library in the error reporting server because the nearest free and opensource counterpart is lacking. I was working with g.raphael.js [0] so as to not entangle myself in this matter of licensing but I found myself doing more and more just to do simple tasks such as having an axis on a bar chart. I wanted to see if it was possible to use highcharts [1] as a the javascript charting library. This is the link to the faq [2] where it explains non commercial use. I was asking if we fall under the non commercial category in the error reporting server. [0] http://g.raphaeljs.com/ [1] http://www.highcharts.com/products/highcharts [2] http://shop.highsoft.com/faq#what-is-non-commercial -- Mohamed Ashraf

10 years, 11 months

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #4205

by michal＠cihar.com

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/4205/changes> Changes: [mcihar] End sentence with stop ------------------------------------------ Started by GitHub push by nijel Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@6c5ee70d Using strategy: Default Last Built Revision: Revision 118905e355a6b781189bbc1a6012ec06f63aa9b5 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision d3432b7f739bbddd733850206969089789d87e1b (origin/master) Checking out Revision d3432b7f739bbddd733850206969089789d87e1b (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson578780627122283938.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-7-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] Enabling headers testing... [exec] [exec] [exec] [exec] [exec] [exec] [exec] [exec] [exec] PHPUnit 3.7.22 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] ............................................................[33;1mI[0m 61 / 2071 ( 2%) [exec] ............................................................. 122 / 2071 ( 5%) [exec] ............................................................. 183 / 2071 ( 8%) [exec] ............................................................. 244 / 2071 ( 11%) [exec] ............................................................. 305 / 2071 ( 14%) [exec] ............................................................. 366 / 2071 ( 17%) [exec] ............................................................. 427 / 2071 ( 20%) [exec] ............................................................. 488 / 2071 ( 23%) [exec] ............................................................. 549 / 2071 ( 26%) [exec] ............................................................. 610 / 2071 ( 29%) [exec] .......................................[33;1mI[0m..................... 671 / 2071 ( 32%) [exec] ............................................................. 732 / 2071 ( 35%) [exec] ............................................................. 793 / 2071 ( 38%) [exec] ............................................................. 854 / 2071 ( 41%) [exec] ............................................................. 915 / 2071 ( 44%) [exec] ............................................................. 976 / 2071 ( 47%) [exec] ............................................................. 1037 / 2071 ( 50%) [exec] ............................................................. 1098 / 2071 ( 53%) [exec] ............................................................. 1159 / 2071 ( 55%) [exec] ............................................................. 1220 / 2071 ( 58%) [exec] ............................................................. 1281 / 2071 ( 61%) [exec] ............................................................. 1342 / 2071 ( 64%) [exec] ............................................................. 1403 / 2071 ( 67%) [exec] ............................................................. 1464 / 2071 ( 70%) [exec] ............................................................. 1525 / 2071 ( 73%) [exec] ............................................................. 1586 / 2071 ( 76%) [exec] ............................................................. 1647 / 2071 ( 79%) [exec] ............................................................. 1708 / 2071 ( 82%) [exec] ............................................................. 1769 / 2071 ( 85%) [exec] ............................................................. 1830 / 2071 ( 88%) [exec] ............[41;37mF[0m................................................ 1891 / 2071 ( 91%) [exec] ......................[33;1mI[0m...................................... 1952 / 2071 ( 94%) [exec] ............................................................. 2013 / 2071 ( 97%) [exec] .........................................................[33;1mI[0m [exec] [exec] Time: 30 seconds, Memory: 105.00Mb [exec] [exec] There was 1 failure: [exec] [exec] 1) PMA_ServerPrivileges_Test::testPMAGetMessageAndSqlQueryForPrivilegesRevoke [exec] Failed asserting that two strings are equal. [exec] --- Expected [exec] +++ Actual [exec] @@ @@ [exec] -'You have revoked the privileges for 'pma_username'@'pma_hostname'' [exec] +'You have revoked the privileges for 'pma_username'@'pma_hostname'.' [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_se…>:364 [exec] [exec] -- [exec] [exec] [exec] There were 4 incomplete tests: [exec] [exec] 1) PMA_ConfigTest::testCheckPermissions [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:943 [exec] [exec] 2) PMA_AuthenticationCookie_Test::testBlowfishDecrypt [exec] Not testing mcrypt support [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:1097 [exec] [exec] 3) PMA_TblColumnsDefinitionFormTest::testGetFormParamsForOldColumn [exec] Not yet implemented! [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_tb…>:1114 [exec] [exec] 4) Environment_Test::testSession [exec] No session testing [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/Environment_test…>:83 [exec] [exec] [37;41m[2KFAILURES! [exec] [0m[37;41m[2KTests: 2071, Assertions: 4698, Failures: 1, Incomplete: 4. [exec] [0m[2K BUILD FAILED <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>:28: exec returned: 1 Total time: 43 seconds Build step 'Invoke Ant' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Computing warning deltas based on reference build #4204 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #4204 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [INFO] - Check 'Failed Tests' threshold. [xUnit] [INFO] - Check 'Skipped Tests' threshold. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

10 years, 11 months

Re: [Phpmyadmin-devel] New look for the phpmyadmin error reporting server

by J. M.

> From: mohamed.ashraf.213(a)gmail.com > Date: Thu, 22 Aug 2013 07:26:52 +0200 > To: phpmyadmin-devel(a)lists.sourceforge.net > Subject: [Phpmyadmin-devel] New look for the phpmyadmin error reporting server > > Recently we have deployed an updated version of the error reporting > server at [0]. > I fixed the previous comments, added syntax highlighting to the > stacktraces. I also added pie charts for visualization and added a new > html view for incidents. I also now try my best to show only different > stacktraces. > > I would like your input on this version since this is as close to a > final version as could be. The database has been seeded with a few > reports that are fake but the last one is actually real to give you > some feel about how a real report looks like. > > I am not exactly the best designer out there, but I did my best. If > anyone has any new ideas for improvement that would be great. Thanks for the update. I like the look!Ideas: - How about updating to the recently released Bootstrap 3? No requirement, don't get me wrong. :)- In the select box above "Exception name", why do I see both names and IDs? Suggestion: Concatenate them to 1 row per row, such as "Reference Error [1]".- As mentioned in my last remarks, can you move the select boxes right under the table headers? This will make the connection clearer.- ID column navigator: Good to use <input type="number">. As there are no issues "0" or negative, why not add the min="1" attribute? Best, J.M. > > [0] http://reports.phpmyadmin.net/ > > -- > Mohamed Ashraf > > ------------------------------------------------------------------------------ > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk > _______________________________________________ > Phpmyadmin-devel mailing list > Phpmyadmin-devel(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

10 years, 11 months

[Phpmyadmin-devel] New look for the phpmyadmin error reporting server

by Mohamed Ashraf

Recently we have deployed an updated version of the error reporting server at [0]. I fixed the previous comments, added syntax highlighting to the stacktraces. I also added pie charts for visualization and added a new html view for incidents. I also now try my best to show only different stacktraces. I would like your input on this version since this is as close to a final version as could be. The database has been seeded with a few reports that are fake but the last one is actually real to give you some feel about how a real report looks like. I am not exactly the best designer out there, but I did my best. If anyone has any new ideas for improvement that would be great. [0] http://reports.phpmyadmin.net/ -- Mohamed Ashraf

10 years, 11 months

[Phpmyadmin-devel] icon for table hide

by Marc Delisle

Hi, I just realized that using a X icon for table hide is scary (makes me think I'm about to delete the table, before I see the hint). Elsewhere I have seen an icon of an eye (open or closed) but we are already using this for tracking, so I don't have another suggestion right now. -- Marc Delisle http://infomarc.info

10 years, 11 months

[Phpmyadmin-devel] ctype and mbstring dependencies

by Michal Čihař

Hi all I see that we've documented ctype and mbstring as dependencies, while we still have huge amount of code (PMA_String and related classes) to be able to handle situations when those are not available. This situation should be fixed for next release :-). But there are some open questions: - there is no check that ctype is actually loaded, so we don't enforce this dependency, so do we really want it as hard dependency? - mbstring is required for gettext so this one probably has to be there - the PMA_String class could mostly go away in case we would directly use ctype and mbstring functions - removing one abstraction layer and gaining back a little bit of performace -- Michal Čihař | http://cihar.com | http://blog.cihar.com

10 years, 11 months

[Phpmyadmin-devel] Turn off tree view?

by Marc Delisle

Hi, see this thread: https://sourceforge.net/p/phpmyadmin/discussion/Help/thread/ae8b9e05/ -- Marc Delisle http://infomarc.info

10 years, 11 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers August 2013