Developers August 2013

developers@phpmyadmin.net

16 participants
70 discussions

[Phpmyadmin-devel] error reports from different phpmyadmin version

by Mohamed Ashraf

For bug reports. I currently group bug incidents that occur on the same file in the same line into one bug report since they are most likely the same. I do not however take into account phpma version. should I only group bug incidents from the same file and line if they share a phpma version?. I looked at [0]. I am not sure how they group bug incidents but every report has a single kernel version. I think I should do the same and rely on manual interference by developers to mark the bug reports in different versions as the same. [0] http://oops.kernel.org/browse-reports/ -- Mohamed Ashraf

10 years, 11 months

[Phpmyadmin-devel] Designer troubles

by Isaac Bennetch

Hi, I'm seeing an odd behavior with Designer. Trying to create a relation, I click the Create relation button (about four in from the left in the menu), then select a table's primary key and then click on a column in a different table. I get a prompt: "Create relation OK / Cancel" -- selecting OK does not create the relation and instead opens a new browser window with the main phpMyAdmin page loaded. Does anyone else see this behavior?

10 years, 11 months

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #4063

by michal＠cihar.com

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/4063/changes> Changes: [Michal Čihař] Remove no longer used SQP CSS rules [Michal Čihař] Drop no longer used config for SQP CSS [Michal Čihař] Update CodeMirror to 3.15 [Michal Čihař] Replace getCssCodeMirror by inline CSS [Michal Čihař] Drop no longer used $cfg['SQP']['fmtColor'] [Michal Čihař] Drop $cfg['SQP']['fmtType'] ------------------------------------------ Started by GitHub push by nijel Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@4abd7e7c Using strategy: Default Last Built Revision: Revision 2711010c058cf1d1c3afebac6f6c66f980678d5d (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision b8ea23ab9f0800fdcf7309de0dded4769eb45be4 (origin/master) Checking out Revision b8ea23ab9f0800fdcf7309de0dded4769eb45be4 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson6720356640829130492.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] Enabling headers testing... [exec] PHP Parse error: syntax error, unexpected '{' in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/Util.class.…> on line 1025 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:797 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:873 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] Result: 255 phpcpd: [exec] phpcpd 1.4.2 by Sebastian Bergmann. [exec] [exec] Found 32 exact clones with 576 duplicated lines in 39 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-143 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2782-2793 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:155-272 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:160-277 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:119-130 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:121-132 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:202-208 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:313-319 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:159-173 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:243-257 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:28-41 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:30-43 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/server_priv…>:3903-3916 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/ServerStatu…>:367-380 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:602-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:620-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-966 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:935-972 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-972 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:807-850 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:460-467 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:661-689 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/tbl_row_action.php>:127-133 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/tbl_select.php>:63-69 [exec] [exec] 0.39% duplicated lines out of 147971 total lines of code. [exec] [exec] Time: 6 seconds, Memory: 130.50Mb [exec] Result: 1 phpcs: [exec] Time: 01:16, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 426 [exec] [exec] Lines of Code (LOC): 147971 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 46302 [exec] Non-Comment Lines of Code (NCLOC): 101669 [exec] [exec] Namespaces: 0 [exec] Interfaces: 5 [exec] Traits: 0 [exec] Classes: 208 [exec] Abstract: 28 (13.46%) [exec] Concrete: 180 (86.54%) [exec] Average Class Length (NCLOC): 223 [exec] Methods: 1818 [exec] Scope: [exec] Non-Static: 1538 (84.60%) [exec] Static: 280 (15.40%) [exec] Visibility: [exec] Public: 1414 (77.78%) [exec] Non-Public: 404 (22.22%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.20 [exec] [exec] Anonymous Functions: 2 [exec] Functions: 700 [exec] [exec] Constants: 167 [exec] Global constants: 107 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 1 minute 31 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2633 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #4062 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 55 warnings. [DRY] Computing warning deltas based on reference build #4062 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 690 files to scan for tasks [TASKS] Found 202 open tasks. [TASKS] Computing warning deltas based on reference build #4062 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #4062 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

10 years, 11 months

[Phpmyadmin-devel] Need feedback on error reporting server

by Mohamed Ashraf

We have deployed an early version of the error reporting server at [0]. while there are still a few things not implemented the view will not change much from what is currently there. I have filled the database with fake reports to help you see how things will look in the real world. Since I am finishing up with the features I need feedback on the currently implemented functionality and if anyone has any idea on how to do something differently please feel free to say it. currently there is a list of reports and clicking on the id of the report you get redirected to a view containing the summary of the related reports. you can submit error reports to the sourceforge bug tracker. if anyone thinks there is missing functionality or if something needs to be displayed in a better way, please tell me so as to schedule the change in the coming weeks. [0] http://reports.phpmyadmin.net/ -- Mohamed Ashraf

10 years, 11 months

Re: [Phpmyadmin-devel] Need feedback on error reporting server

by J. M.

> -----Original Message----- > From: Mohamed Ashraf [mailto:mohamed.ashraf.213@gmail.com] > Sent: Saturday, August 3, 2013 3:53 PM > To: phpmyadmin-devel(a)lists.sourceforge.net > Subject: [Phpmyadmin-devel] Need feedback on error reporting server > > We have deployed an early version of the error reporting server at [0]. while > there are still a few things not implemented the view will not change much > from what is currently there. I have filled the database with fake reports to > help you see how things will look in the real world. > > Since I am finishing up with the features I need feedback on the currently > implemented functionality and if anyone has any idea on how to do something > differently please feel free to say it. > > currently there is a list of reports and clicking on the id of the report you > get redirected to a view containing the summary of the related reports. you > can submit error reports to the sourceforge bug tracker. > > if anyone thinks there is missing functionality or if something needs to be > displayed in a better way, please tell me so as to schedule the change in the > coming weeks. > > [0] http://reports.phpmyadmin.net/ > > -- Mohamed Ashraf > Hello Mohamed, Thanks for this! It looks nice and works properly. Things I have noticed, from a user interface perspective: 1. The drop downs for filtering, can you place them directly below the headline? Like this: ID ....... Reference Name ... [ v] .... [ v ] ... 2. Can you allow the whole "ID" cell to be clickable? (using "display: block" for the link) This will make clicking easier, especially for low numbers. 3. The Sourceforge link "Sourceforge Report [Submit report] " does not work yet. I read: Error: The requested address '/source_forge/new_ticket/2?url=%2Fsource_ forge%2Fnew_ticket%2F2' was not found on this server. Best, JM

10 years, 11 months

[Phpmyadmin-devel] phpMyAdmin 4.0.5 is released

by Marc Delisle

Welcome to phpMyAdmin 4.0.5, a bugfix and security fix version (see the upcoming PMASA-2013-10 advisory). Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

10 years, 11 months

[Phpmyadmin-devel] Jessica Kerr's Git happens

by Marc Delisle

Hi, I'm watching http://www.youtube.com/watch?v=Dv8I_kfrFWw This is a very good (IMO) presentation of the vocabulary of Git, necessary to understand its documentation. -- Marc Delisle http://infomarc.info

10 years, 11 months

[Phpmyadmin-devel] origin of $fields_meta in tbl_columns_definition_form.inc.php

by Supun Nakandala

Hi devs, I am refactoring tbl_columns_definition_form.inc.php. At https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/tbl_columns_… the $fields_meta variable is checked for moving, load all available column names. But as far as I could find this feature is set in table structure tab and is handled by tbl_structure.php . Is this dead code ? Regards Supun.

10 years, 11 months

[Phpmyadmin-devel] license/copyright of error reporting server

by Dieter Adriaenssens

Hi all, The error reporting server is based on cakePHP which is licensed under MIT license [0]. It is compatible with GPL, the license under which phpMyAdmin is licensed. Under which license shall we license the code that is added to create the error reporting server? Both licensing under GPL or MIT is a possibility. It makes sense to license under GPL because phpMyAdmin itself is licensed under GPL. But it might be easier to use the MIT license, especially for files with mixed copyright (original cakePHP files being modified creating the error reporting server). BTW : Conservancy allows us to license under the MIT license. Anyway, there should be a license file (LICENSE and/or COPYING) in the root dir of error reporting server repo. And the files added to create the error reporting server should contain a header indicating the licensing info. [0] http://opensource.org/licenses/mit-license.php -- Kind regards, Dieter Adriaenssens

10 years, 11 months

[Phpmyadmin-devel] selflink not included in some pages

by Mohamed Ashraf

I noticed that the selflink is not appearing in some pages like for example tbl_addfield.php. It took me a couple of hours to find out why and it was because a global variable was set which was $checked_special it was set in the checkParameters method in Util.class.php I am not sure what this variable means. anyways this variable gets checked in getDisplay in the footer class and if it is true the self link is not shown. can someone tell me if this is correct behavior and why should we not show the self link in those pages. I need the self link to get the current token so it is important that the self link should be available in all pages. -- Mohamed Ashraf

10 years, 11 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers August 2013