- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] GSoC: github tree
by Alex Marin 21 May '12

21 May '12

Hello, I have a question regarding [1]. In our tree, should we only add our own commits regarding the GSoC project we are assigned? The problem I see here is that there are chances that the files we modify in our tree will also be modified in PMA/master, so merge conflicts will appear that will have to be solved at the final merge at the end of GSoC. And also, the local tree will be a little out of date. The alternative would be to merge [2] continuously to our tree and mix our commits with the ones from the PMA master branch, but then again if someone modifies a file you committed changes to, you have to locally solve conflicts or rebase your commit. Will the final merge be safe in this case? Or is there no such thing as a final merge, and our good commits will be merged to PMA/master periodically? I can imagine that would be more difficult in some cases where some functionalities can't be partially merged if they are more complex. [1] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_reposi… [2] https://github.com/phpmyadmin/phpmyadmin/commits/master Thanks, Alex

2 1

[Phpmyadmin-devel] Duplicate code in CSS themes
by Michal Čihař 19 May '12

19 May '12

Hi all I think it is pretty obvious that all themes will share quite big load of CSS. Originally I though about extracting these bits to Theme class methods, but now I think it would make things even harder to maintain. What I feel would be better to create core CSS file, which would be always included and theme authors will just override/extend it. This way, we can make changes in core without breaking older themes too much - maybe some things will not look 100% intergrated, but at least the layout won't be broken. Currently original and pmahomme themes share about 2500 lines, they differ in 1000/500 (pmahomme/original) lines. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 6

[Phpmyadmin-devel] Table zoom search option is broken
by Atul Pratap Singh 16 May '12

16 May '12

Hi Madhura, The Table zoom search option is broken after function name fixes done in the commit 60f84a045ec53be94c4cb837d8f70ad210990f7a. Please fix the function names in tbl_zoom_select.php (line 178). Regards -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.

2 1

[Phpmyadmin-devel] refactoring insert/edit: BLOB upload
by Marc Delisle 15 May '12

15 May '12

Thilina, I made an insert test with a table that contains a BLOB; the maximum size for the upload is not displayed. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Naming convention standard for methods
by Chanaka Dharmarathna 13 May '12

13 May '12

Hi All, While I'm refactoring some files relating to display query results (currently display_tbl.lib.php, common.lib.php), I can method names are used regardless of the inside functionality. Ex :- "PMA_displayHtmlRadio" in common.lib.php method return a string of HTML content. But the name tells the function displays HTML itself. As I feel these things should be modified. As library files, they never should render HTML inside the functions themselves. Better thing is to return a string of PHP having the HTML content. So my suggestion is to use the phrase "get" for the every method which return any data type. So that developer can understand it returns something just looking at the name. Following are some suggested names. (Some of them are already discussed in this mailing list) Ex: PMA_displayHtmlRadio -> PMA_getRadioFields PMA_generateSliderEffect -> PMA_getDivForSliderEffect PMA_generateHtmlDropdown -> PMA_getDropdown PMA_displayTableNavigationButton -> getTableNavigationButton (All above functions return strings) Hope to join a discussion on this. Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

2 4

[Phpmyadmin-devel] Duplicate CSS print files?
by Rouslan Placella 12 May '12

12 May '12

Hi all, Just a quick question about the printing-related CSS files that we have in the code base. We have "print.css" which is globally included and then we also have a "theme_print.css.php" file in each theme. So couldn't we just drop the latter? Or am I missing something? Bye, Rouslan

4 4

[Phpmyadmin-devel] Can't log in to pma?
by Tyron Madlener 12 May '12

12 May '12

After a update on my server I can't seem to log in to phpMyAdmin. Whatever user or pass I type in, it just reloads the page without showing any errors. It seems as if the session is not being saved, because I can see a new token being generated every time. Anyone had a similar problem like this?

2 2

[Phpmyadmin-devel] refactoring and superglobals
by Marc Delisle 11 May '12

11 May '12

Hi, We previously had a script called grab_globals.lib.php, which created global variables from a few superglobals arrays. When this script was removed a few weeks ago, we added at the beginning of other scripts some code, for example in tbl_change.php: if (isset($_REQUEST['where_clause'])) { $where_clause = $_REQUEST['where_clause']; } In the upcoming refactoring efforts, we should avoid this, because, looking at the code further in the script, it's difficult to see the origin of $where_clause. So, we should only refer to $_REQUEST['where_clause'] (except in the situations where the global is modified afterwards). Another benefit is that this variable would not need to be passed as a parameter to functions. -- Marc Delisle http://infomarc.info

3 4

[Phpmyadmin-devel] Configurations for phpMyAdmin Demo Server project
by Chanaka Dharmarathna 10 May '12

10 May '12

Hi, I'm working on "Refactoring: Displaying query results" [0] project idea under GSoC 2012. In my demo server project [1] the configurations for extended features like "Creation of PDFs", "Browser transformation", "Bookmarked SQL query" etc are already done *without "User preferences".* As well a new user "pma" is already created there, but with a different password instead of general "pmapass". In my local machine I just enable these all extended features and "error displaying" by introducing "config.inc.php" file. And set the control user (pma) password to general one (pmapass). If I commit this configuration file, the demo server project configurations will be override. ("error displaying" , "User preferences", "control user password" will change) So is it a good idea to commit these changes ? Your suggestions are welcome. [0] : http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka7… [1] : http://demo.phpmyadmin.net/gsoc-chanaka/ Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

3 6

[Phpmyadmin-devel] refactoring tbl_change.php
by Marc Delisle 09 May '12

09 May '12

Thilina, please move all your functions from tbl_change.php to libraries/insert_edit.lib.php. I suspect that other functions from refactoring tbl_replace.php and tbl_replace_fields.inc.php will go there as well. -- Marc Delisle http://infomarc.info

3 4