Developers

developers@phpmyadmin.net

5 participants
7032 discussions

[Phpmyadmin-devel] Re: warning in display_tbl.lib.php3

by Loïc

Hi Garvin! >I just wanted to kindly ask if I can get a "credit" for this patch Hum, I don't know.... ;) Of course and I've just done it. Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 9 months

[Phpmyadmin-devel] Vertical browse patch

by Garvin Hicking

Hi! I just reviewed the changes made for my vertical browsing patch. I found an error in line 556, it says: ---- . '&dontlimitchars' . $dontlimitchars ---- but it should be --- . '&dontlimitchars=' . $dontlimitchars --- (note the equal sign, which got overwritten by the patch) As for the last mail, you have to replace line 925 --- $verticaldisplay["rowdata"][$i][$foo] .= $verticaldisplay["data"][$foo][$i]; --- by: --- if(isset($verticaldisplay["rowdata"][$i][$foo])) { $verticaldisplay["rowdata"][$i][$foo] .= $verticaldisplay["data"][$foo][$i]; }else{ $verticaldisplay["rowdata"][$i][$foo] = $verticaldisplay["data"][$foo][$i]; } --- As well change --- // 4. Gather links of del_urls and edit_urls in an array for later output $verticaldisplay["edit"][$foo] .= ' <td bgcolor="' . $bgcolor . '">' . "\n"; --- into --- // 4. Gather links of del_urls and edit_urls in an array for later output if (!isset($verticaldisplay["edit"][$foo])) { $verticaldisplay["edit"][$foo] = ""; $verticaldisplay["delete"][$foo] = ""; } $verticaldisplay["edit"][$foo] .= ' <td bgcolor="' . $bgcolor . '">' . "\n"; --- (Hope this isn't too ugly coding...if it is, I would like to know a better way. :-) Bye, Garvin. --------------------------------------------- Garvin Hicking / Mediengestalter Faktor E AG email: hicking(a)faktor-e.de | me(a)supergarv.de www.faktor-e.de | www.supergarv.de

22 years, 9 months

Re: [Phpmyadmin-devel] warning in display_tbl.lib.php3

by Loïc

Hi List! Please don't change too much the CVS now: I'll commit some fixes for the vertical display mode within a few hours. Thanks, Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 9 months

[Phpmyadmin-devel] warning in display_tbl.lib.php3

by Steve Alberty

Hi, Since one of the last cvs updates, phpMyAdmin result on selects: Warning: Undefined index: rowdata in phpMyAdmin/libraries/display_tbl.lib.php3 on line 925 Warning: Undefined offset: 0 in phpMyAdmin/libraries/display_tbl.lib.php3 on line 925 -- $verticaldisplay["rowdata"][$i][$foo] .= $verticaldisplay["data"][$foo][$i]; -- Because $verticaldisplay is uninitialized. Regards, -- Steve Alberty

22 years, 9 months

[Phpmyadmin-devel] privileges on a table

by Marc Delisle

Hi, Is this a known bug or is it me? I want to give a user access to just a table, so I give him SELECT on base9.table9 but no access to base9. This user can select this table (tested in a phpMyAdmin query box), but can't see the db name in the left frame. Marc

22 years, 9 months

[Phpmyadmin-devel] Offering a "patch" for new vertical table browsing

by Garvin Hicking

Hi! I took the time to integrate a change I did long ago to an older version of PhpMyAdmin into the latest "stable" release. Sadly, I didn't do it in the latest CVS-build because this port is blocked here at my office. First, what the patch does is to enhance the "Show X rows starting from Y to Z" dialog to the phrase "in [vertical/horizontal] mode and repeat headers after ZZ cells". Then the output done in the display_tbl.lib.php3 file is formated in horizontal or vertical columns, which was quite useful for me in some times I had to browse tables which huge amounts of keys, and I hate to scroll horizontally. Also, that headers are repeated after X cells is quite usefull, I think. I have done my best to make easy changes to the current structure without too much intereference. Somethings could have been done better, because they are now somehow redundant. But maybe one of the core developers can have a look at my changes and proceed at will. If I can be of any help integrating the patch, please let me know. The php-file itself can be found at http://www2.bonnet.de/garvin/display_tbl.lib.txt (I didn't know whether I'm allowed to post attachments or not) - you also have to alter the language and config files, which are appended to my E-Mail. Feedback appreciated. :-) >> config.inc.php /* BEGIN Changes for new vertical/horizontal Browse mode, Garvin Hicking <hicking(a)faktor-e.de> */ $cfgLeftWidth = 150; // left frame width $cfgDefaultDisplay = "horizontal"; // default display mode (horizontal|vertical) $cfgRepeatCells = 100; // repeat header names every X cells? (0 = deactivate) /* END Changes for new vertical/horizontal Browse mode, Garvin Hicking <hicking(a)faktor-e.de> */ >> <language>.inc.php /* BEGIN Changes for new vertical/horizontal Browse mode, Garvin Hicking <hicking(a)faktor-e.de> */ $strRowsInModePre = 'in'; $strRowsModeVertical = 'vertical'; $strRowsModeHorizontal = 'horizontal'; $strRowsInModeAfter = 'mode and repeat headers after'; $strRowsInModeCells = 'cells'; /* END Changes for new vertical/horizontal Browse mode, Garvin Hicking <hicking(a)faktor-e.de> */ Bye, Garvin. --------------------------------------------- Garvin Hicking / Mediengestalter Faktor E AG email: hicking(a)faktor-e.de | me(a)supergarv.de www.faktor-e.de | www.supergarv.de

22 years, 9 months

[Phpmyadmin-devel] should we support IE4?

by Marc Delisle

In IE4 under Windows NT Server, I browse a table, then click on a Delete link. The confirmation box appears, I click yes, then it stays there. I have to kill IE4. When I am back, I see that the record has been deleted. Should we debug this, or put an entry in the FAQ? Marc

22 years, 9 months

Re: [Phpmyadmin-devel] 2.2.4 revision

by Loïc

Hi again! Marc wrote: >Left frame and links in browse tables work ok in Konqueror 2.1.1. Fine :) >However, in Konq when clicking on Delete for a row, I get the popup >to confirm the delete, and when I click yes, the delete does not take >place: I have another confirmation question in the right frame. Arg, a Konq bug I'm afraid :( Could you have a look at the url that is used to reach the confirmation page? Does it end with "is_js_confirmed=1" (this part should have been append to the original url if you clicked yes at the js confirm box)? Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 9 months

Re: [Phpmyadmin-devel] 2.2.4 revision

by Loïc

Hi List! Marc wrote: >Maybe a 2.2.3 before 2.2.4? Maybe, yes ;) >Do you mean releasing the new version with the new config/http/cookie >mecanism? Nope it was before I add this one. So we may now wait till you have build the session wrapper and then release a 2.3.0-rc1 (isn't it a major change ?) >A 32 MB table dump (uncompressed) still gets a memory limit error on >the server.... since with phpMyAdmin 2.1.0 the same table dumps ok. OK but now you see a php error message where, most of the times, you just faced a "file not found" error before. The "improvement" I wa talking about is just that. To fix the whole problem you described here I'm afraid we have either to remove the *zipping options, either to write temporary files on the server. [About pointers] >Looks ok with NN 4 and IE 5.5, will try tonight with good old Konq :) Fine :) BTW I'm not really happy with the style of the left pointer: I don't like the flashy color so much and maybe we should add something to emphasis to db name. Any suggestions? Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 9 months

Re: [Phpmyadmin-devel] About Patch #491236 - php 4.0.3pl1 workaround

by Loïc

Hi Eduardo & List! Nope, the problem isn't related to this but it's a coding problem in a way : to be able to *zip the dump file we first need... to build that "file", ie to store the whole dump informations in memory. For big databases/tables it may lead either to exceed the maximum allowed time to execute a php script, either to exceed the maximum allowed memory usage for a thread. The possible fix, at least for the second kind of problem, would be to not store dump informations but send them to the browser immediatly as soon as the user want these statements to be displayed on screen of put in a non- *zipped file (this is the "old method") and to keep the "new method" in the other cases. Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

22 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers