[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Column->Change
Hi Marc, I worked with my 7th week task which is to implementing the "Change one column in Table structure". 1. I tried to reuse the code, which I was developed for multi_column change earlier. So I moved the common logic to changeColumns(action,$url) function which is in the tbl_structure.js file. Should I move the code to functions.js file. 2. Also I reused "*$("#append_fields_form input[name=do_save_data].ajax").live('click')*" action which was built for the multi_colum change. 3. Then I developed the "*$("#fieldsForm.ajax #tablestructure tbody tr td.edit a").live('click')*" action which loads the change dialog for the user. I pushed my changes to the repo. Please check that. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-08 14:46, Thilanka Kaushalya a écrit :
Hi Marc,
I worked with my 7th week task which is to implementing the "Change one column in Table structure".
1. I tried to reuse the code, which I was developed for multi_column change earlier. So I moved the common logic to changeColumns(action,$url) function which is in the tbl_structure.js file. Should I move the code to functions.js file. 2. Also I reused "*$("#append_fields_form input[name=do_save_data].ajax").live('click')*" action which was built for the multi_colum change. 3. Then I developed the "*$("#fieldsForm.ajax #tablestructure tbody tr td.edit a").live('click')*" action which loads the change dialog for the user.
I pushed my changes to the repo. Please check that. Thank you.
Regards, Thilanka.
Interesting feature; however I found a problematic case. Let's say you have an ENUM in the table. Try to change its structure then click on "Get more editing space", "Add a value": you can't type a new value. -- Marc Delisle http://infomarc.info
Hi Marc, Interesting feature; however I found a problematic case. Let's say you
have an ENUM in the table. Try to change its structure then click on "Get more editing space", "Add a value": you can't type a new value.
I checked with this and found that this arise because I set the "* model=true*" option in the div.dialog() and when it is set, it disables the reset of the input fields. When I removed that it fixed the bug. But I'm not sure this is correct because when I removed "*model=true*" it will not disable the rest and so there will be issues occur when the user can click on multiple change links and popping up many dialog boxes at the same time. Is there any other way of fixing this. Please help me on this. Thank you.
Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-09 12:05, Thilanka Kaushalya a écrit :
Hi Marc,
Interesting feature; however I found a problematic case. Let's say you have an ENUM in the table. Try to change its structure then click on "Get more editing space", "Add a value": you can't type a new value.
I checked with this and found that this arise because I set the "*model=true*" option in the div.dialog() and when it is set, it disables the reset of the input fields. When I removed that it fixed the bug. But I'm not sure this is correct because when I removed "*model=true*" it will not disable the rest and so there will be issues occur when the user can click on multiple change links and popping up many dialog boxes at the same time. Is there any other way of fixing this. Please help me on this. Thank you.
Regards, Thilanka.
Thilanka, maybe suhajdab's answer can help you: http://forum.jquery.com/topic/making-a-diolog-box-open-another-dialog-box-wh... P.S. In "Ajax event handler for single column change" you are using $url; it should be url because this is not a jQuery object. -- Marc Delisle http://infomarc.info
Hi Marc, maybe suhajdab's answer can help you:
http://forum.jquery.com/topic/making-a-diolog-box-open-another-dialog-box-wh...
P.S. In "Ajax event handler for single column change" you are using $url; it should be url because this is not a jQuery object.
I fixed the issue and pushed to the repo. Please check that. Thank for the
help. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-10 05:55, Thilanka Kaushalya a écrit :
Hi Marc,
maybe suhajdab's answer can help you: http://forum.jquery.com/topic/making-a-diolog-box-open-another-dialog-box-wh...
P.S. In "Ajax event handler for single column change" you are using $url; it should be url because this is not a jQuery object.
I fixed the issue and pushed to the repo. Please check that. Thank for the help.
Feature merged, thanks. A possible improvement: when you create a table having a VARCHAR column and you forget the length, you get a nice "This is not a number" message. There is no such nice message when changing a column, so you get an error that does not point to the real problem. -- Marc Delisle http://infomarc.info
Hi Marc, Feature merged, thanks.
A possible improvement: when you create a table having a VARCHAR column and you forget the length, you get a nice "This is not a number" message.
There is no such nice message when changing a column, so you get an error that does not point to the real problem.
I fixed this issue for the ajax enabled scenario by using the "*
checkTableEditForm()*" function and pushed the code to the repo. But for non ajax scenario I didn't handled yet. For applying this in the non ajax behavior I have to move the "*$("#append_fields_form input[name=do_save_data]").live('click')*" action to functions.js file in order to make accessible at the tbl_alter.php file. Is it okay to have this action in functions.js file and the other actions related to change option in tbl_structure.js file. If it is okay I'll change that. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-11 04:14, Thilanka Kaushalya a écrit :
Hi Marc,
Feature merged, thanks.
A possible improvement: when you create a table having a VARCHAR column and you forget the length, you get a nice "This is not a number" message.
There is no such nice message when changing a column, so you get an error that does not point to the real problem.
I fixed this issue for the ajax enabled scenario by using the "*
checkTableEditForm()*" function and pushed the code to the repo. But for non ajax scenario I didn't handled yet. For applying this in the non ajax behavior I have to move the "*$("#append_fields_form input[name=do_save_data]").live('click')*" action to functions.js file in order to make accessible at the tbl_alter.php file. Is it okay to have this action in functions.js file and the other actions related to change option in tbl_structure.js file. If it is okay I'll change that. Thank you.
Yes it's ok to move this section, to avoid code duplication. functions.js is cached in the browser so the downside of increased size is minimal. -- Marc Delisle http://infomarc.info
Hi Marc, Yes it's ok to move this section, to avoid code duplication.
functions.js is cached in the browser so the downside of increased size is minimal.
I did the changes and pushed to the repo. Please check that. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-11 13:32, Thilanka Kaushalya a écrit :
Hi Marc,
Yes it's ok to move this section, to avoid code duplication. functions.js is cached in the browser so the downside of increased size is minimal.
I did the changes and pushed to the repo. Please check that. Thank you.
Regards, Thilanka.
Works fine but commit 215eb80df9b5456d4b2131bb98d8448797ef2c74 needs an improvement; please avoid this kind of syntax: $($temp_div) It should be just $temp_div as this is already a jQuery object. -- Marc Delisle http://infomarc.info
Hi Marc, Works fine but commit 215eb80df9b5456d4b2131bb98d8448797ef2c74 needs an
improvement; please avoid this kind of syntax:
$($temp_div)
It should be just $temp_div
as this is already a jQuery object.
Fixed that issue and pushed to the repo. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
On Tue, 2011-07-12 at 06:57 +0530, Thilanka Kaushalya wrote:
Hi Marc,
Works fine but commit 215eb80df9b5456d4b2131bb98d8448797ef2c74 needs an
improvement; please avoid this kind of syntax:
$($temp_div)
It should be just $temp_div
as this is already a jQuery object.
Fixed that issue and pushed to the repo. Thank you.
Regards, Thilanka.
Hi Thilanka, I remember mentioning this before, but you must have forgotten about it.
From what I can see, in all parts of your project you have left footnotes in your ajax dialogs, instead of converting them to tooltips. Please find attached a screenshot that shows the difference between one and the other. If you want to use tooltips (I think it's a good idea), then you will have to convert the footnotes right after you show your ajax dialog to the user, the function that does the conversion is called initTooltips() and it resides inside functions.js. However, after a quick glance at that function, it looks to me like it needs to be modified a small bit. Right now it looks for elements across the whole of the DOM, but it would be better to be able to pass to it an optional jQuery object as a parameter, so that it is possible to make it look for footnotes and the respective markers inside a particular object only. Hope this helps :)
Bye, Rouslan
Hi Marc, I remember mentioning this before, but you must have forgotten about it.
From what I can see, in all parts of your project you have left footnotes in your ajax dialogs, instead of converting them to tooltips. Please find attached a screenshot that shows the difference between one and the other. If you want to use tooltips (I think it's a good idea), then you will have to convert the footnotes right after you show your ajax dialog to the user, the function that does the conversion is called initTooltips() and it resides inside functions.js. However, after a quick glance at that function, it looks to me like it needs to be modified a small bit. Right now it looks for elements across the whole of the DOM, but it would be better to be able to pass to it an optional jQuery object as a parameter, so that it is possible to make it look for footnotes and the respective markers inside a particular object only. Hope this helps :)
If I change the initTooltips() function by adding a jquery object parameter to it, it will be effect to the places where this function is already used. So what should I do for this. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
On Fri, 2011-07-15 at 20:51 +0530, Thilanka Kaushalya wrote:
Hi Marc,
I remember mentioning this before, but you must have forgotten about it.
From what I can see, in all parts of your project you have left footnotes in your ajax dialogs, instead of converting them to tooltips. Please find attached a screenshot that shows the difference between one and the other. If you want to use tooltips (I think it's a good idea), then you will have to convert the footnotes right after you show your ajax dialog to the user, the function that does the conversion is called initTooltips() and it resides inside functions.js. However, after a quick glance at that function, it looks to me like it needs to be modified a small bit. Right now it looks for elements across the whole of the DOM, but it would be better to be able to pass to it an optional jQuery object as a parameter, so that it is possible to make it look for footnotes and the respective markers inside a particular object only. Hope this helps :)
If I change the initTooltips() function by adding a jquery object parameter to it, it will be effect to the places where this function is already used.
Not necessarily. Recall that JavaScript does not care about missing input parameters for functions, it just treats them as undefined. You can exploit this to make the new parameter optional. An example would be: ----->%----- function myFunction($obj) { if ($obj == undefined || ! $obj instanceof jQuery || $obj.length == 0 ) { // input was invalid, so we // operate on the whole document $obj = $('body'); } $obj.find('#someID').doSomething(); } ----->%----- This will allow you to leave alone all the calls to initTooltips() that are already in the code base (and that have no arguments). Hope this makes sense. Bye, Rouslan
Le 2011-07-15 11:21, Thilanka Kaushalya a écrit :
Hi Marc,
I remember mentioning this before, but you must have forgotten about it.
From what I can see, in all parts of your project you have left footnotes in your ajax dialogs, instead of converting them to tooltips. Please find attached a screenshot that shows the difference between one and the other. If you want to use tooltips (I think it's a good idea), then you will have to convert the footnotes right after you show your ajax dialog to the user, the function that does the conversion is called initTooltips() and it resides inside functions.js. However, after a quick glance at that function, it looks to me like it needs to be modified a small bit. Right now it looks for elements across the whole of the DOM, but it would be better to be able to pass to it an optional jQuery object as a parameter, so that it is possible to make it look for footnotes and the respective markers inside a particular object only. Hope this helps :)
A change in logic will be needed as well, as the generated ids for footnotes are duplicated in some cases. For example, on the database Structure page, I already have footnotes converted to tooltips; when I click Insert for a table, the popup panel has the same ids in the ".footnotes span", compared to those that had been generated for the Structure page. -- Marc Delisle http://infomarc.info
Hi Marc and Rouslan, A change in logic will be needed as well, as the generated ids for
footnotes are duplicated in some cases. For example, on the database Structure page, I already have footnotes converted to tooltips; when I click Insert for a table, the popup panel has the same ids in the ".footnotes span", compared to those that had been generated for the Structure page.
I changed the logic of the initTooltips() function and pushed the changes to the repo. I just called the function in db->insert option in db_structure.js file. If this is okay I can use it in my other ajaxified options also. Please check that. Thanks for the help you gave. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
On Sat, 2011-07-16 at 20:48 +0530, Thilanka Kaushalya wrote:
Hi Marc and Rouslan,
A change in logic will be needed as well, as the generated ids for
footnotes are duplicated in some cases. For example, on the database Structure page, I already have footnotes converted to tooltips; when I click Insert for a table, the popup panel has the same ids in the ".footnotes span", compared to those that had been generated for the Structure page.
I changed the logic of the initTooltips() function and pushed the changes to the repo. I just called the function in db->insert option in db_structure.js file. If this is okay I can use it in my other ajaxified options also. Please check that. Thanks for the help you gave.
I tried on your demo server and as far as I can tell the tooltips are completely broken now. They are no longer generated for the normal page (but the footnotes are hidden) and they don't appear in the ajax dialog (the footnotes, again, are gone though) (ubuntu 11.04/firefox 5). Also as Marc said, with the code that you committed you would be generating duplicate IDs, I suggest you merely change those to classes to avoid possible conflicts (or you could come up with some scheme for generating unique IDs, though that sounds more complicated than is necessary). Rouslan
HI Marc and Rouslan, I tried on your demo server and as far as I can tell the tooltips are
completely broken now. They are no longer generated for the normal page (but the footnotes are hidden) and they don't appear in the ajax dialog (the footnotes, again, are gone though) (ubuntu 11.04/firefox 5).
Also as Marc said, with the code that you committed you would be generating duplicate IDs, I suggest you merely change those to classes to avoid possible conflicts (or you could come up with some scheme for generating unique IDs, though that sounds more complicated than is necessary).
I'm very sorry that earlier I made the wrong changes to the initTooltips function. I fixed the issues and pushed to the repo. Please check that. Thank you.
Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-16 21:52, Thilanka Kaushalya a écrit :
HI Marc and Rouslan,
I tried on your demo server and as far as I can tell the tooltips are
completely broken now. They are no longer generated for the normal page (but the footnotes are hidden) and they don't appear in the ajax dialog (the footnotes, again, are gone though) (ubuntu 11.04/firefox 5).
Also as Marc said, with the code that you committed you would be generating duplicate IDs, I suggest you merely change those to classes to avoid possible conflicts (or you could come up with some scheme for generating unique IDs, though that sounds more complicated than is necessary).
I'm very sorry that earlier I made the wrong changes to the initTooltips function. I fixed the issues and pushed to the repo. Please check that. Thank you.
Thilanka, there are still elements with the same id, for example in my test of the sakila database, there are two elements with id footnote_1_1. The source of the problem is the following. When db_structure.php is executed, it calls PMA_showHint() which keeps track of the number of instances for each message in a global array. However, when you call tbl_change.php via AJAX, the global variables are reset and this execution is not aware of the previously recorded instances. -- Marc Delisle http://infomarc.info
Hi Marc, there are still elements with the same id, for example in my test of the
sakila database, there are two elements with id footnote_1_1.
The source of the problem is the following. When db_structure.php is executed, it calls PMA_showHint() which keeps track of the number of instances for each message in a global array.
However, when you call tbl_change.php via AJAX, the global variables are reset and this execution is not aware of the previously recorded instances.
Hi Marc, As Rouslan said can I remove this ID's from elements and add as classes. Since my new logic in initTooltips($div) function it get the $div parameter to define the search sub domain for footnotes elements it will not conflict with multiple elements having the same class. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-18 21:47, Thilanka Kaushalya a écrit :
Hi Marc,
there are still elements with the same id, for example in my test of the
sakila database, there are two elements with id footnote_1_1.
The source of the problem is the following. When db_structure.php is executed, it calls PMA_showHint() which keeps track of the number of instances for each message in a global array.
However, when you call tbl_change.php via AJAX, the global variables are reset and this execution is not aware of the previously recorded instances.
Hi Marc,
As Rouslan said can I remove this ID's from elements and add as classes. Since my new logic in initTooltips($div) function it get the $div parameter to define the search sub domain for footnotes elements it will not conflict with multiple elements having the same class. Thank you.
Thilanka, yes, try that. P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips(). -- Marc Delisle http://infomarc.info
Hi Marc, Thilanka,
yes, try that.
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
I did the necessary changed and committed to the repo. please check that. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
On Tue, 2011-07-19 at 23:02 +0530, Thilanka Kaushalya wrote:
Hi Marc,
Thilanka,
yes, try that.
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
I did the necessary changed and committed to the repo. please check that. Thank you.
Looks good to me, for whatever that's worth. The only things that I noticed that you might want to have a look at are: * Since PMA_convertFootnotesToTooltips() now takes a parameter, you might want to add a PHPDOC header to it to explain what that parameter is for and that it can be omitted. * The 'span_id' variable in PMA_convertFootnotesToTooltips() is now misleading, since it stores a class, not an id. Rouslan
Le 2011-07-19 14:10, Rouslan Placella a écrit :
On Tue, 2011-07-19 at 23:02 +0530, Thilanka Kaushalya wrote:
Hi Marc,
Thilanka,
yes, try that.
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
I did the necessary changed and committed to the repo. please check that. Thank you.
Looks good to me, for whatever that's worth. The only things that I noticed that you might want to have a look at are:
* Since PMA_convertFootnotesToTooltips() now takes a parameter, you might want to add a PHPDOC header to it to explain what that parameter is for and that it can be omitted. * The 'span_id' variable in PMA_convertFootnotesToTooltips() is now misleading, since it stores a class, not an id.
Thilanka, 1. please follow Rouslan's suggestions; however, the variable, after the split, really contains a span id (to find the other footnote span) 2. please add a comment just before the line containing the split, explaining that this variable contains two classes at this point (for example "footnotemarker footnote_1_1") 3. also add a comment, using for example footnote_2_3 and that after the split, the variable contains 2, so will find the footnote #2 I find it a bit hazardous to use this split on a string which contains two classes. You never know, another class having an underscore could be added to this element in the future. Another thing I find unclear: in PMA_showHint() and PMA_convertFootnotesToTooltips() you have kept the principle of using the instance of the footnote, even though the goal of the instance was only to have unique ids. IMO you should get rid of the instance. -- Marc Delisle http://infomarc.info
Hi Marc, 1. please follow Rouslan's suggestions; however, the variable, after the
split, really contains a span id (to find the other footnote span)
2. please add a comment just before the line containing the split, explaining that this variable contains two classes at this point (for example "footnotemarker footnote_1_1")
3. also add a comment, using for example footnote_2_3 and that after the split, the variable contains 2, so will find the footnote #2
I did the above changes and pushed to the repo.
I find it a bit hazardous to use this split on a string which contains two classes. You never know, another class having an underscore could be added to this element in the future.
I change the logic a little, and in that case it is more safe with splitting and getting the id.
Another thing I find unclear: in and PMA_convertFootnotesToTooltips() you have kept the principle of using the instance of the footnote, even though the goal of the instance was only to have unique ids. IMO you should get rid of the instance.
I removed it and pushed my changes to the repo. Now I find two new errors with this.One is an firebug error which says w" http://localhost/phpmyadmin-gsoc/themes/pmahomme/img/ic_b_triggers 404 (Not Found)" when I click on "DB->Structure->insert". It appears in non ajax scenario also. The next one is when I go to "Sakila" database and try to insert for actor_info table it gives an error. But in ajax enabled dialog shows the json string is not parsed clearly. I cannot parse the whole data content at the "$("td.insert_table a.ajax").live('click')" action in db_structure.js file because the returned content from tbl_change.php file is not 100% an json response. That ajax response was passed at the line 604 in common.lib.php and it seems not parsing correctly. Can you please help me on this issue. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
On Thu, Jul 21, 2011 at 2:40 PM, Thilanka Kaushalya <lgtkaushalya@gmail.com> wrote:
Hi Marc,
1. please follow Rouslan's suggestions; however, the variable, after the split, really contains a span id (to find the other footnote span)
2. please add a comment just before the line containing the split, explaining that this variable contains two classes at this point (for example "footnotemarker footnote_1_1")
3. also add a comment, using for example footnote_2_3 and that after the split, the variable contains 2, so will find the footnote #2
I did the above changes and pushed to the repo.
I find it a bit hazardous to use this split on a string which contains two classes. You never know, another class having an underscore could be added to this element in the future.
I change the logic a little, and in that case it is more safe with splitting and getting the id.
Another thing I find unclear: in and PMA_convertFootnotesToTooltips() you have kept the principle of using the instance of the footnote, even though the goal of the instance was only to have unique ids. IMO you should get rid of the instance.
I removed it and pushed my changes to the repo. Now I find two new errors with this.One is an firebug error which says w"http://localhost/phpmyadmin-gsoc/themes/pmahomme/img/ic_b_triggers 404 (Not Found)" when I click on "DB->Structure->insert". It appears in non ajax scenario also.
I probably caused that when Michal merged my repo to master. The problem is in tbl_links.inc.php where 'ic_b_triggers' is assigned as icon. So to fix it either rename it to b_triggers.png or just wait for my css sprites changes to be merged to master (assuming that it is going to be merged)
The next one is when I go to "Sakila" database and try to insert for actor_info table it gives an error. But in ajax enabled dialog shows the json string is not parsed clearly. I cannot parse the whole data content at the "$("td.insert_table a.ajax").live('click')" action in db_structure.js file because the returned content from tbl_change.php file is not 100% an json response. That ajax response was passed at the line 604 in common.lib.php and it seems not parsing correctly. Can you please help me on this issue. Thank you. Regards, Thilanka.
-- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka
Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-21 07:40, Thilanka Kaushalya a écrit :
Hi Marc,
1. please follow Rouslan's suggestions; however, the variable, after the
split, really contains a span id (to find the other footnote span)
2. please add a comment just before the line containing the split, explaining that this variable contains two classes at this point (for example "footnotemarker footnote_1_1")
3. also add a comment, using for example footnote_2_3 and that after the split, the variable contains 2, so will find the footnote #2
I did the above changes and pushed to the repo.
Code has been merged to origin/master, thanks.
The next one is when I go to "Sakila" database and try to insert for actor_info table it gives an error. But in ajax enabled dialog shows the json string is not parsed clearly. I cannot parse the whole data content at the "$("td.insert_table a.ajax").live('click')" action in db_structure.js file because the returned content from tbl_change.php file is not 100% an json response. That ajax response was passed at the line 604 in common.lib.php and it seems not parsing correctly. Can you please help me on this issue. Thank you.
I'm not sure you realize that actor_info is a view. The returned error is normal. Also, this error comes from a POST of tbl_replace.php (not tbl_change.php) and this is handled in db_structure.js at this section: $("#insertForm .insertRowTable.ajax input[value=Go]").live('click') -- Marc Delisle http://infomarc.info
Hi Marc I'm not sure you realize that actor_info is a view. The returned error
is normal.
The error is normal with the non ajax criteria and in the common.lib.php file the ajax request is handled as follows. if($GLOBALS['is_ajax_request'] == true) { PMA_ajaxResponse($error_msg_output, false); } If I can change this to a normal response such as if($GLOBALS['is_ajax_request'] == true) { echo $error_msg_output; exit; } it will not parse json and works as the proper error message error Also, this error comes from a POST of tbl_replace.php (not
tbl_change.php)
This does not get form posting for tbl_replace.php. You can check it by checking the "Insert" link, and the url shows the tbl_change.php. and this is handled in db_structure.js at this section:
$("#insertForm .insertRowTable.ajax input[value=Go]").live('click')
I'm not sure why you said this should be handled in the above action
because the error should handle when it loads to the insert dialog. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
Le 2011-07-21 13:39, Thilanka Kaushalya a écrit :
Hi Marc
I'm not sure you realize that actor_info is a view. The returned error is normal.
The error is normal with the non ajax criteria and in the common.lib.php file the ajax request is handled as follows.
if($GLOBALS['is_ajax_request'] == true) { PMA_ajaxResponse($error_msg_output, false); } If I can change this to a normal response such as
if($GLOBALS['is_ajax_request'] == true) { echo $error_msg_output; exit; }
it will not parse json and works as the proper error message error
Also, this error comes from a POST of tbl_replace.php (not tbl_change.php)
This does not get form posting for tbl_replace.php. You can check it by checking the "Insert" link, and the url shows the tbl_change.php.
Yes but at this point, the error has not happenned. It only happens when executing tbl_replace.php.
and this is handled in db_structure.js at this section:
$("#insertForm .insertRowTable.ajax input[value=Go]").live('click')
I'm not sure why you said this should be handled in the above action because the error should handle when it loads to the insert dialog.
And how will how detect that this view cannot be inserted into? Remember that some views can be inserted into (but actor_info cannot). -- Marc Delisle http://infomarc.info
Hi Rouslan, Looks good to me, for whatever that's worth. The only things that I
noticed that you might want to have a look at are:
* Since PMA_convertFootnotesToTooltips() now takes a parameter, you might want to add a PHPDOC header to it to explain what that parameter is for and that it can be omitted.
Thank and now I added them. * The 'span_id' variable in PMA_convertFootnotesToTooltips() is
now misleading, since it stores a class, not an id.
In here even though it initially search for classes, the results are taken as ids for spans. That's why I kept it in that manner. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya@gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya@yahoo.com Blog : http://coders-view.blogspot.com/
On Tue, Jul 19, 2011 at 2:45 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2011-07-18 21:47, Thilanka Kaushalya a écrit :
Hi Marc,
there are still elements with the same id, for example in my test of the
sakila database, there are two elements with id footnote_1_1.
The source of the problem is the following. When db_structure.php is executed, it calls PMA_showHint() which keeps track of the number of instances for each message in a global array.
However, when you call tbl_change.php via AJAX, the global variables are reset and this execution is not aware of the previously recorded instances.
Hi Marc,
As Rouslan said can I remove this ID's from elements and add as classes. Since my new logic in initTooltips($div) function it get the $div parameter to define the search sub domain for footnotes elements it will not conflict with multiple elements having the same class. Thank you.
Thilanka, yes, try that.
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Magic Quadrant for Content-Aware Data Loss Prevention Research study explores the data loss prevention market. Includes in-depth analysis on the changes within the DLP market, and the criteria used to evaluate the strengths and weaknesses of these DLP solutions. http://www.accelacomm.com/jaw/sfnl/114/51385063/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-21 10:53, Tyron Madlener a écrit :
On Tue, Jul 19, 2011 at 2:45 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2011-07-18 21:47, Thilanka Kaushalya a écrit :
Hi Marc,
there are still elements with the same id, for example in my test of the
sakila database, there are two elements with id footnote_1_1.
The source of the problem is the following. When db_structure.php is executed, it calls PMA_showHint() which keeps track of the number of instances for each message in a global array.
However, when you call tbl_change.php via AJAX, the global variables are reset and this execution is not aware of the previously recorded instances.
Hi Marc,
As Rouslan said can I remove this ID's from elements and add as classes. Since my new logic in initTooltips($div) function it get the $div parameter to define the search sub domain for footnotes elements it will not conflict with multiple elements having the same class. Thank you.
Thilanka, yes, try that.
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.
Sorry, I had thought about it but afterwards forgot. I'll cherry-pick your patch and apply it to origin/master. -- Marc Delisle http://infomarc.info
Le 2011-07-21 11:01, Marc Delisle a écrit :
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.
Sorry, I had thought about it but afterwards forgot. I'll cherry-pick your patch and apply it to origin/master.
Tyron, The cherry-pick failed with conflicts between your tree and the origin. The file js/server_status.js has different modifications. -- Marc Delisle http://infomarc.info
On Thu, Jul 21, 2011 at 6:18 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2011-07-21 11:01, Marc Delisle a écrit :
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.
Sorry, I had thought about it but afterwards forgot. I'll cherry-pick your patch and apply it to origin/master.
Tyron, The cherry-pick failed with conflicts between your tree and the origin. The file js/server_status.js has different modifications.
Yea I thought so. We can wait until next time Michal merges my repo. That or just replace initTooltips with PMA_convertFootnotesToTooltips. It only appears a single time in server_status.js at the beginning somewhere. I can merge back with master afterwards to avoid merge conflicts.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-21 13:03, Tyron Madlener a écrit :
On Thu, Jul 21, 2011 at 6:18 PM, Marc Delisle<marc@infomarc.info> wrote:
Le 2011-07-21 11:01, Marc Delisle a écrit :
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.
Sorry, I had thought about it but afterwards forgot. I'll cherry-pick your patch and apply it to origin/master.
Tyron, The cherry-pick failed with conflicts between your tree and the origin. The file js/server_status.js has different modifications.
Yea I thought so. We can wait until next time Michal merges my repo. That or just replace initTooltips with PMA_convertFootnotesToTooltips.
Done.
It only appears a single time in server_status.js at the beginning somewhere. I can merge back with master afterwards to avoid merge conflicts.
-- Marc Delisle http://infomarc.info
On Thu, Jul 21, 2011 at 8:18 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2011-07-21 13:03, Tyron Madlener a écrit :
On Thu, Jul 21, 2011 at 6:18 PM, Marc Delisle<marc@infomarc.info> wrote:
Le 2011-07-21 11:01, Marc Delisle a écrit :
P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().
initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.
Sorry, I had thought about it but afterwards forgot. I'll cherry-pick your patch and apply it to origin/master.
Tyron, The cherry-pick failed with conflicts between your tree and the origin. The file js/server_status.js has different modifications.
Yea I thought so. We can wait until next time Michal merges my repo. That or just replace initTooltips with PMA_convertFootnotesToTooltips.
Done.
Thanks :-)
It only appears a single time in server_status.js at the beginning somewhere. I can merge back with master afterwards to avoid merge conflicts.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-11 21:27, Thilanka Kaushalya a écrit :
Hi Marc,
Works fine but commit 215eb80df9b5456d4b2131bb98d8448797ef2c74 needs an improvement; please avoid this kind of syntax:
$($temp_div)
It should be just $temp_div
as this is already a jQuery object.
Fixed that issue and pushed to the repo. Thank you.
Merged. -- Marc Delisle http://infomarc.info
participants (4)
-
Marc Delisle -
Rouslan Placella -
Thilanka Kaushalya -
Tyron Madlener