Hi Marc, Interesting feature; however I found a problematic case. Let's say you have an ENUM in the table. Try to change its structure then click on "Get more editing space", "Add a value": you can't type a new value. I checked with this and found that this arise because I set the "*model=true*" option in the div.dialog() and when it is set, it disables the reset of the input fields. When I removed that it fixed the bug. But I'm not sure this is correct because when I removed "*model=true*" it will not disable the rest and so there will be issues occur when the user can click on multiple change links and popping up many dialog boxes at the same time. Is there any other way of fixing this. Please help me on this. Thank you. Regards, Thilanka.

Hi Marc, maybe suhajdab's answer can help you: http://forum.jquery.com/topic/making-a-diolog-box-open-another-dialog-box-w… P.S. In "Ajax event handler for single column change" you are using $url; it should be url because this is not a jQuery object. I fixed the issue and pushed to the repo. Please check that. Thank for the help.

Hi Marc, Feature merged, thanks. checkTableEditForm()*" function and pushed the code to the repo. But for non ajax scenario I didn't handled yet. For applying this in the non ajax behavior I have to move the "*$("#append_fields_form input[name=do_save_data]").live('click')*" action to functions.js file in order to make accessible at the tbl_alter.php file. Is it okay to have this action in functions.js file and the other actions related to change option in tbl_structure.js file. If it is okay I'll change that. Thank you.

Hi Marc, Yes it's ok to move this section, to avoid code duplication. functions.js is cached in the browser so the downside of increased size is minimal. I did the changes and pushed to the repo. Please check that. Thank you. Regards, Thilanka.

Hi Marc, Works fine but commit 215eb80df9b5456d4b2131bb98d8448797ef2c74 needs an Fixed that issue and pushed to the repo. Thank you. Regards, Thilanka.

From what I can see, in all parts of your project you have left

Hi Marc, I remember mentioning this before, but you must have forgotten about it. If I change the initTooltips() function by adding a jquery object parameter to it, it will be effect to the places where this function is already used.

footnotes are duplicated in some cases. For example, on the database Structure page, I already have footnotes converted to tooltips; when I click Insert for a table, the popup panel has the same ids in the ".footnotes span", compared to those that had been generated for the Structure page.

completely broken now. They are no longer generated for the normal page (but the footnotes are hidden) and they don't appear in the ajax dialog (the footnotes, again, are gone though) (ubuntu 11.04/firefox 5). Also as Marc said, with the code that you committed you would be generating duplicate IDs, I suggest you merely change those to classes to avoid possible conflicts (or you could come up with some scheme for generating unique IDs, though that sounds more complicated than is necessary). I'm very sorry that earlier I made the wrong changes to the initTooltips

sakila database, there are two elements with id footnote_1_1. The source of the problem is the following. When db_structure.php is executed, it calls PMA_showHint() which keeps track of the number of instances for each message in a global array. However, when you call tbl_change.php via AJAX, the global variables are reset and this execution is not aware of the previously recorded instances.

yes, try that. P.S. I suggest renaming initToolTips() to a better name like PMA_convertFootnotesToTooltips().

On Tue, 2011-07-19 at 23:02 +0530, Thilanka Kaushalya wrote: Looks good to me, for whatever that's worth. The only things that I noticed that you might want to have a look at are: * Since PMA_convertFootnotesToTooltips() now takes a parameter, you might want to add a PHPDOC header to it to explain what that parameter is for and that it can be omitted. * The 'span_id' variable in PMA_convertFootnotesToTooltips() is now misleading, since it stores a class, not an id.

Hi Marc, I did the above changes and pushed to the repo. I change the logic a little, and in that case it is more safe with splitting and getting the id. I removed it and pushed my changes to the repo. Now I find two new errors with this.One is an firebug error which says w"http://localhost/phpmyadmin-gsoc/themes/pmahomme/img/ic_b_triggers 404 (Not Found)" when I click on "DB->Structure->insert". It appears in non ajax scenario also.

The next one is when I go to "Sakila" database and try to insert for actor_info table it gives an error. But in ajax enabled dialog shows the json string is not parsed clearly. I cannot parse the whole data content at the "$("td.insert_table a.ajax").live('click')" action in db_structure.js file because the returned content from tbl_change.php file is not 100% an json response. That ajax response was passed at the line 604 in common.lib.php and it seems not parsing correctly. Can you please help me on this issue. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at,       Gmail        : lgtkaushalya(a)gmail.com       Twitter       : @thilanka_k       Facebook  : Thilanka Kaushalya       Yahoo       : lgtkaushalya(a)yahoo.com       Blog          : http://coders-view.blogspot.com/ ------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

is normal.

tbl_change.php)

$("#insertForm .insertRowTable.ajax input[value=Go]").live('click') I'm not sure why you said this should be handled in the above action

noticed that you might want to have a look at are: * Since PMA_convertFootnotesToTooltips() now takes a parameter, you might want to add a PHPDOC header to it to explain what that parameter is for and that it can be omitted.

now misleading, since it stores a class, not an id.

On Tue, Jul 19, 2011 at 2:45 PM, Marc Delisle <marc(a)infomarc.info> wrote: initToolTips() was used on the status page, so that broke the status page on the master demo for now. I have already patched it in my repo.

Le 2011-07-21 11:01, Marc Delisle a écrit : Tyron, The cherry-pick failed with conflicts between your tree and the origin. The file js/server_status.js has different modifications.

-- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Le 2011-07-21 13:03, Tyron Madlener a écrit : Done.

-- Marc Delisle http://infomarc.info ------------------------------------------------------------------------------ 5 Ways to Improve & Secure Unified Communications Unified Communications promises greater efficiencies for business. UC can improve internal communications as well as offer faster, more efficient ways to interact with customers and streamline customer service. Learn more! http://www.accelacomm.com/jaw/sfnl/114/51426253/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel